Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <a1656a7c-7eb0-4a21-8c49-89014beeb7ed@embeddedor.com>
Date:   Tue, 28 Nov 2023 14:12:08 -0600
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] neighbour: Fix __randomize_layout crash in struct
 neighbour
Content-Language: en-US
To:     Joey Gouly <joey.gouly@arm.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Bill Wendling <morbo@google.com>,
        Kees Cook <keescook@chromium.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
References: <ZWJoRsJGnCPdJ3+2@work>
 <20231128111028.GA2382233@e124191.cambridge.arm.com>
From:   "Gustavo A. R. Silva" <gustavo@embeddedor.com>
In-Reply-To: <20231128111028.GA2382233@e124191.cambridge.arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


>> diff --git a/include/net/neighbour.h b/include/net/neighbour.h
>> index 07022bb0d44d..0d28172193fa 100644
>> --- a/include/net/neighbour.h
>> +++ b/include/net/neighbour.h
>> @@ -162,7 +162,7 @@ struct neighbour {
>>   	struct rcu_head		rcu;
>>   	struct net_device	*dev;
>>   	netdevice_tracker	dev_tracker;
>> -	u8			primary_key[0];
>> +	u8			primary_key[];
>>   } __randomize_layout;
>>   
>>   struct neigh_ops {
> 
> Fixes the crash for me!

Awesome. :)

--
Gustavo