Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4163146rdh; Tue, 28 Nov 2023 13:43:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IFvi/S261k0KIkLGVM9c/jPdXp8LH3SDL0ZoMcZCIgmgJIVT+0B/wlA8kFXse2hffz4E7Qm X-Received: by 2002:a17:902:ea07:b0:1cf:ef92:18d7 with SMTP id s7-20020a170902ea0700b001cfef9218d7mr5883803plg.11.1701207794872; Tue, 28 Nov 2023 13:43:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701207794; cv=none; d=google.com; s=arc-20160816; b=DMOVWWFR6znS9RosZmJ69daE2eKkZlRziP9f84iyEot9jhSnOaegHAr5jhIaYFUAdU hTIVSQNYTl6uT7Ht0qZ5bFaVUoNq1jkzK8dCf+MHqYek6C9MJkmDGjcTi92vqbizlSCy Zz26oJspjxWngxDlAVXV6dxkfYwRS4fSZztZqsiCoaWOaBu2ZhlqHaoV414q8o44Wz/t uSqNVWwinylVLHy9gA8x3NRewru2pyICWbGTGNSZNc5WCSaKegFZ7gcHafBfIuUOqAy5 rrpOtPWgqkwpTnclsOpfLqfvLeuB2iyFadVpNvqdnZ4rCaoWE7E2s81Sej5wflmy1uFK CJjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=NCV8wSoremzCgSEH4mODwdZTs0BH4ubRKcqxzytMbvw=; fh=Jhb7rxZsQO0DdPOhq7EvFSKoHEjO13TbzKhGE3E43sU=; b=Rg0evE0wtPGql5fP+aBieOyB2op4jjfVOinqsg5XFajECS3CwcP6YoNVqZcSN0StPC 0zl6btDWoI+XNPl5ulytHPaKdM84qpjGwa3/ATBHdS38wNsk6DeDFbD8fuMQatkEKPS/ MbrGCmpP1rMr7D8/GCG7n2L8Kev2KOvjNXsPDmTOgIptrrJ9KCDHhXcWQ+h7s5SbbWlX jFgUc5iBc7AOr/fKCw14BsBYtsa0AN6dFGqxaoBA1UYrxUeEv5tFa/p4xREDPvepLKyd 7ISv7tEeArWIbp6lFXSx2INzdu8J3CLmiEQlT3Uxf3d5Tvg8WkgwQMEFXMJQxx1TtHCX T1tA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id z6-20020a170903018600b001d000c817e2si1762259plg.398.2023.11.28.13.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 13:43:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 6733280A8BB8; Tue, 28 Nov 2023 13:43:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345044AbjK1Vm7 (ORCPT + 99 others); Tue, 28 Nov 2023 16:42:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229866AbjK1Vm6 (ORCPT ); Tue, 28 Nov 2023 16:42:58 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D1153BD; Tue, 28 Nov 2023 13:43:04 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F198C1FB; Tue, 28 Nov 2023 13:43:51 -0800 (PST) Received: from [10.57.2.117] (unknown [10.57.2.117]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8DC6F3F73F; Tue, 28 Nov 2023 13:43:03 -0800 (PST) Message-ID: <23b21239-4268-43e2-acc3-4ebc454944e7@arm.com> Date: Tue, 28 Nov 2023 21:44:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] thermal: trip: Drop a redundant check from thermal_zone_set_trip() Content-Language: en-US To: "Rafael J. Wysocki" Cc: LKML , Linux PM , Daniel Lezcano , Srinivas Pandruvada , Zhang Rui References: <6010559.lOV4Wx5bFT@kreacher> <4544904.LvFx2qVVIh@kreacher> From: Lukasz Luba In-Reply-To: <4544904.LvFx2qVVIh@kreacher> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 28 Nov 2023 13:43:12 -0800 (PST) On 11/28/23 13:56, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > After recent changes in the thermal framework, a trip points array is > required for registering a thermal zone that is not tripless, so the > tz->trips pointer in thermal_zone_set_trip() is never NULL and the > check involving it is redundant. Drop that check. > > No functional impact. > > Signed-off-by: Rafael J. Wysocki > --- > > New patch in v2. > > --- > drivers/thermal/thermal_trip.c | 3 --- > 1 file changed, 3 deletions(-) > > Index: linux-pm/drivers/thermal/thermal_trip.c > =================================================================== > --- linux-pm.orig/drivers/thermal/thermal_trip.c > +++ linux-pm/drivers/thermal/thermal_trip.c > @@ -153,9 +153,6 @@ int thermal_zone_set_trip(struct thermal > struct thermal_trip t; > int ret; > > - if (!tz->ops->set_trip_temp && !tz->ops->set_trip_hyst && !tz->trips) > - return -EINVAL; > - > ret = __thermal_zone_get_trip(tz, trip_id, &t); > if (ret) > return ret; > > > LGTM Reviewed-by: Lukasz Luba