Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <1b538450-3a36-40ac-9520-04d6015f3d20@intel.com>
Date:   Tue, 28 Nov 2023 14:09:39 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 01/26] selftests/resctrl: Don't use ctrlc_handler()
 outside signal handling
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-2-ilpo.jarvinen@linux.intel.com>
Content-Language: en-US
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0czbDBxc01WUFNHYU9HZXljdHNZKzBKQ2RqNHNGNDVEVFJ6ZHFNMjVPU0ZH?=
 =?utf-8?B?NWR1dENpUm1PZ1I0SVJaaFdUZGNYRG9TVGthMzRjc0QzWFkwU3E5Zm8zS0VW?=
 =?utf-8?B?SWxkclA0emdJUnJTWVlCMGVST3BqQXc0MjRVc0hMdFhXdnVhaCtNbGpEdWZj?=
 =?utf-8?B?NmRpSmhrN3B5WFB1RlFsamNsbU5PaVl5NWg1VmhkWXg0Qy9DVU9QZ0FEU0tt?=
 =?utf-8?B?WStvQ1ZORDcxc280NTNXcktnZjMzL1FBNDlzeEpybm9DYVBHcnFrV21qbEU2?=
 =?utf-8?B?MkJ6ODV6bXUxYS9hRlYySm5MTXNLRW9sMzZMVk9OVitNelJlWGNXeHdqemFD?=
 =?utf-8?B?Q0tHcEU4Q0QycTg2emtSZk1sV0xwVnpXb09KRU9iRVZuTVVhOGoxSW10OE1z?=
 =?utf-8?B?ckdIL3ZWRXB2dmpMRlZvbUtmaUFXVnFLb1JPVXF4RzZpMktGS0syaGZHZE9O?=
 =?utf-8?B?ckdJaTBFV0NDUThkRENwblhkeWRiZ0xOTUpIa2hHalp1ckMzcHBxeE5ZckxJ?=
 =?utf-8?B?RHFYOENYdDRYNUpDaVp3L1RxRUJTVUwydFJudGFSeVlnbjEvMWZyZmFLRkhL?=
 =?utf-8?B?RzVsOHJteVFzUDZpMjl5N3VlQmpOQjNIUys1VmVOc3VEZld4em5sc1ErZjNX?=
 =?utf-8?B?U0NGUUE3am5BV0ppRC9vY0RmazNob1ZKT0U4MWlaamhKU3EybGkvMHBPUlR4?=
 =?utf-8?B?Y0VJWW1Zb05kT2J2UVY1WlE3YWZXYVU2WStONkU1d3lLenRzMzE2K3hYUjk2?=
 =?utf-8?B?VUtZSzdMd0VUSkxWdEFWUEI0L2pKSWxnRksyN3krK1NiWGNNMGxxNzI5ajZW?=
 =?utf-8?B?bVpjcTJnK3REM1VJTCtlaUxTZHlyMUx0R3p6MjVmYnptc2FRYlo1eDlVVnV2?=
 =?utf-8?B?QXdYZWZYaXNMazVCWDlrblVLMmsrQWIvVXF0d3Z6cVZNUnBDUjJTM1lnWVcr?=
 =?utf-8?B?QVJ2Z0FHbGl2MUJOalp1UVBHY2hpTjJrcXdBV1pMSWxoazVCcnpjblN1NVlE?=
 =?utf-8?B?RWdNbDdlaHBIZXhMZ1orQ1RmZGpKb2orVlFvbXJDMTRjanE0ckF3NnhTTVVP?=
 =?utf-8?B?YndRb2locWo1ZWwwb0pWTDhSVzlaTUQ1N29LVS9lUThPWVBocythdjNrUHpo?=
 =?utf-8?B?NGIvNmNpcnpRVy9oK0JFMWFCbHdLRjFDZGNYOGU3bXU4QmIrTDBzMjFFOE54?=
 =?utf-8?B?blpSY0dQSzc5VVhRckN2K2xOVFNYNXZzVDhkcEhjbHBKaFgyMTdyVEhnbXhJ?=
 =?utf-8?B?NFBMcWNIanZNVC90Ujd6d2l1dkkzblVPaTZ4dWpGTUdzcjh2RE53NjJwWUlS?=
 =?utf-8?B?NWtURlhhR2RZRlFkeU9QUThFMTVJWGpzb0FsckVJeU9PSWtaYUNwYm05RW56?=
 =?utf-8?B?Tm1Ic05jMWM1VUR4Q0hZYXBxL0JuUWo2b2FFaDBFUnIxbmV1TTdYeDBCL2xF?=
 =?utf-8?B?WHRZK2NvUkZwalpaN2tpR21IQm0rdkpiMkwxZEhlbE1yWGVURFlWQlRyWU9o?=
 =?utf-8?B?MXhhWjZETUVhSDdCYTJvcTM3QmRXcTBJT25KT2EvaU5RTmd1ODdnejBNYXph?=
 =?utf-8?B?MEJ2aXNWSFM5eVN3cE8wR2MwbnNKUnVCUGJCUUY1ckRISXhReGVUNUI4bjlL?=
 =?utf-8?B?NEJiMG1rMDUxTWZtdWFhRWE1cExwYXpIdmI4dElyRUhMeHQydlZML1NkdnhR?=
 =?utf-8?B?K0VrbER1TTc3d1htdEJTOTBiTGU1SzdXaWdQZ2dBZ0RnMW5nM3N5YTVzaWVm?=
 =?utf-8?B?MzZxKzhMaVQxZFpvc2l4cm9hc1gzM3k4ZVFsVjM2SFdmNDlWenMrRC9sSW8w?=
 =?utf-8?B?QVUvMFpVN3VjY0w3OEdJMEQ3OTkrMWF4a0J2RDJ4bmJrbkZrc0FHYytuaGxD?=
 =?utf-8?B?NXQ3cG1yVHh5WnNYM21KYkZXRjhxNTh6QTNTVFBTb0dTcFcwODFVUXVOeHQ0?=
 =?utf-8?B?cjhCSEZFKzZlOW53cVRhVmVXdWpmcm9jUWI0TlNZKzZrME9NTEViTkI2dG40?=
 =?utf-8?B?eGdwRk52RmlmWHdHcTJLa3J5Sml0ekpjVGVGdVFZNjJ0VjVHVm5vZEJvWHk3?=
 =?utf-8?B?MTJQQVhjMHFwOXgrZm1HMjllQ3gwWWVzakJ0c0xuMG1JV3B2Nnp4TFkvVDVC?=
 =?utf-8?B?eG11ckJ1V2RwOWJ5MnJ4dkZpbFZZVGpZTG1MZWJKb3N6L1kvZ1ZtcFdYamgz?=
 =?utf-8?B?akE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a2d61e08-0d47-425f-7b95-08dbf05eb866
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:09:41.5888
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uWB5Ya3X0cpSDJ7/9DOl+Sr0YHWmQDsbTgwQ1rBtdMLVo8igF3M4DoL8JrMsmXJTOnxjpz+Mu1zhG90e5wjrAzb1i5jK5L7qNEAHF7eujbU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6328
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:10:11 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> perf_event_open_llc_miss() calls ctrlc_handler() to cleanup if
> perf_event_open() returns an error. Those cleanups, however, are not
> the responsability of perf_event_open_llc_miss() and it thus interferes

responsibility

> unnecessarily with the usual cleanup pattern. Worse yet,
> ctrlc_handler() calls exit() in the end preventing the ordinary cleanup
> done in the calling function from executing.
> 
> ctrlc_handler() should only be used as a signal handler, not during
> normal error handling.
> 
> Remove call to ctrlc_handler() from perf_event_open_llc_miss(). As
> unmounting resctrlfs and test cleanup are already handled properly
> by error rollbacks in the calling functions, no other changes are
> necessary.
> 
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette