Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <356eb613-a380-4389-96d3-f2667b7d18d3@intel.com>
Date:   Tue, 28 Nov 2023 14:10:20 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 02/26] selftests/resctrl: Split fill_buf to allow tests
 finer-grained control
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-3-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-3-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2R3Vm91RVBtTjRCQ2tPL2JuUVlZdGxaajVvV1BxcWtZRHpwWDRjT0dYOXJa?=
 =?utf-8?B?YjNDK2tqdGdnazhFSW1sYVl0NWhjQ1JzRUNyV2FQVzFzejNGdGFMeUdmTVd1?=
 =?utf-8?B?OGE4Q0hyNW9hQzlMY1ZZYmUxUy85S0hTSEsyNEtLUmdrRFRXV2ZLN2RIdnhF?=
 =?utf-8?B?eWtDcUV5ZUdEcmk0VndJNEJXRWx2UWw5ajZRTHVRSDZHWDIxY29zY1ZNTUd3?=
 =?utf-8?B?WW1HR1h1UkU2L2N5dm44WDVkZGczeTJaSGtDdVRBdEJES0Q4bVZLcCtWeEps?=
 =?utf-8?B?SUVHWXBhRkpsdWRnWW1xa1lIVk43MFgvN0JCc3lPRWxwSjM5Yi9RMURmd05v?=
 =?utf-8?B?V2Mzay93R1d3clZGd2QxbUV4WGIxa0t4NEVVUUR3SXNUWktra2k4Sk5hZndn?=
 =?utf-8?B?bjc3YW0yOHFDNk15aXJLazVLaStVelA3SitrVklmMi9tL0VpZ3UrakFwNUNF?=
 =?utf-8?B?dlcySkpsYmlaY2xtNWFNNEZDWVZEYS9pM1AxQUJNRGtjVHU3czdMZkVrRlNj?=
 =?utf-8?B?UlJVeHBoSlFIa3dKTVVxL2ZDNS91ckhycURuc3RkTUV2ZWtmNlJPK1RrRjVU?=
 =?utf-8?B?ZWt4R0RoVkFRVFlIbzhEV1laY0VQOUkwTExYb2NIa2NtajAzVEdYL1pDb2Y0?=
 =?utf-8?B?REFEMTVvL1F1MFZpZUNHb24zNVVraXVIN1YzakI0TnhBTmo2Uk5oSHEwWGpU?=
 =?utf-8?B?d0Mvd3U1aURZaUJEUkc2dVdBZ1J1TXNRWW9zMnhBTmozcUVuUHJlcUxsTEc5?=
 =?utf-8?B?RE1GbTg5KzVpWlpINmhObUZhd05YZjROSXRMaFFWeUVjL0p3V1lJbGtEeEtF?=
 =?utf-8?B?Rk5LYmtuVDdjMVJiNUxoLzJadDdCb0lCazltbC92dmNSTkZMbUdtdVFLOFg4?=
 =?utf-8?B?MnduQksySCtVbTMwTmg5Q3FYZVBDVFhvcWlmZWdUVmNKV2JlVkxFRmRmMUx2?=
 =?utf-8?B?RjhHSTZ4bmorZnlVdFJVellGSzVSUm9BUHJsTWN1Wm01cEVsQmF1bE9yN1k0?=
 =?utf-8?B?K3JsR3JkaVZlaWM2Zzk0UHZmdnJiMFNDb1lYZi9PWW5VT2diZ3V4YmRBMEQ4?=
 =?utf-8?B?T05NbytMNjNiN3Joays5MzdqV2tUODdIeFhXTTVBUXh0b2ozcy9PcEM5Rzli?=
 =?utf-8?B?N3dtWUpxbFAvRDlIM0RtNGFRWXB2Z2VOQm4rTDQzbUpicFJubks0VDU1L01h?=
 =?utf-8?B?SHJPckN1QVAvelllSDQvellxQXJLRi95QytKLzByU2lDRzhhbEZ2b2xEWHlk?=
 =?utf-8?B?eXR2N0hGZDYxa2NpSEpIS2dRV3dsSC9QNmNKOG91bVlHQlVpenFmeVVXQUp1?=
 =?utf-8?B?OTVaMElhUk11ZjlzQjRoOElvZmozS3ZrUWZ6Wk5OVW5zQVh4QlVjZlB2d2dy?=
 =?utf-8?B?dWdYY1dnbEc1NWxVMnlzV3lqUmZyQWZzWUlFTVNIVjRIV0gxVTM5SDIvMFI5?=
 =?utf-8?B?UGl6UTR1eExOclg0ZTc4QkJnbzVmV2E5d3hhN0RpQjhQcXM0OW0wR2dvSklG?=
 =?utf-8?B?UlZDbWo4aEJkQWFyNGZuaHptcW42Y1E4QTN0TW5xNnNsODAxRS9haS9KVjlC?=
 =?utf-8?B?ZnF5d2pmL1RwdHQwZzVhODE0WWhZVFRQc0pCT1d2aGQ2RVZlQ09peU10QVlS?=
 =?utf-8?B?WmFOTkZsdmlQVzl5c2pmQjQ2WlMvdVI5WTJxYUdiWVJkTzBXekxQYkwvUW11?=
 =?utf-8?B?cDA4cDZYVGJtYjJzakd1cC8zQTE0SnJhbEU0bGtNeFZudGJ5YWxuNk9Yajdp?=
 =?utf-8?B?a2wyYTZCTUROcWx0QVZnUjJqaWErTnlQYzNFVFNaRDJDVDF0S0M0RWtpSUFX?=
 =?utf-8?B?aGhmUmNJNEJoWjRSQmx2bExaSFc5UVFtelRnRHpQMnRxYkNtZUtLV3Nlai81?=
 =?utf-8?B?QTBNUm5FRlhUMjRDMU12UVladWVqZXVUQmtoaUcrSW5DMjRIdkh1eXlDb1pR?=
 =?utf-8?B?NEhOcDlvWEkyTXVYUnRLR09Sd0xYVkVoU2tSQTR0OFFnU2FEejF4ekJYSkor?=
 =?utf-8?B?bU1DN2VzVFp4VjZTNXFDSHR6QWNUV3h1b2t3R0kxdUR4MkZ1MmVqWHB1dm91?=
 =?utf-8?B?OGZRTW91ODVSRXRZUjAvNjFwcHBpaFcvS0Y2VXB6U3RiQ2cvQ3RaRndpVU5B?=
 =?utf-8?B?UXRLT0RtTlV6MWliOGRHbEMyQ0FlQVBPcVNHbXVhMjdXbVB1TUt2L2ZXS3N6?=
 =?utf-8?B?Rnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d2a7d8ea-c430-40c0-2995-08dbf05ed01d
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:10:21.3316
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a9/NSMNukg9oV/8kQ5DujvawZggAsCS5O62CwvFccSDcFxvfNpwtE8a2ctzEFiqFzh7uVeVo4mLIuhDhn8Zn09i+bUmFmQI8yNH2boYnybM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6328
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:10:42 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> MBM, MBA and CMT test cases call run_fill_buf() that in turn calls
> fill_cache() to alloc and loop indefinitely around the buffer. This
> binds buffer allocation and running the benchmark into a single bundle
> so that a selftest cannot allocate a buffer once and reuse it. CAT test
> doesn't want to loop around the buffer continuously and after rewrite
> it needs the ability to allocate the buffer separately.
> 
> Split buffer allocation out of fill_cache() into alloc_buffer(). This
> change is part of preparation for the new CAT test that allocates a
> buffer and does multiple passes over the same buffer (but not in an
> infinite loop).
> 
> Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Could you please list the changes to a patch in this area instead of
lumping all in the cover letter? Without this it is not clear what,
if anything, changed in the new version.

>  tools/testing/selftests/resctrl/fill_buf.c | 26 +++++++++++++---------
>  1 file changed, 15 insertions(+), 11 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c
> index 0d425f26583a..6f32f44128e1 100644
> --- a/tools/testing/selftests/resctrl/fill_buf.c
> +++ b/tools/testing/selftests/resctrl/fill_buf.c
> @@ -135,33 +135,37 @@ static int fill_cache_write(unsigned char *buf, size_t buf_size, bool once)
>  	return 0;
>  }
>  
> -static int fill_cache(size_t buf_size, int memflush, int op, bool once)
> +static unsigned char *alloc_buffer(size_t buf_size, int memflush)
>  {
>  	unsigned char *buf;
> -	int ret;
>  
>  	buf = malloc_and_init_memory(buf_size);
>  	if (!buf)
> -		return -1;
> +		return NULL;
>  
>  	/* Flush the memory before using to avoid "cache hot pages" effect */
>  	if (memflush)
>  		mem_flush(buf, buf_size);
>  
> +	return buf;
> +}
> +
> +static int fill_cache(size_t buf_size, int memflush, int op, bool once)
> +{
> +	unsigned char *buf;
> +	int ret;
> +
> +	buf = alloc_buffer(buf_size, memflush);
> +	if (!buf)
> +		return -1;
> +
>  	if (op == 0)
>  		ret = fill_cache_read(buf, buf_size, once);
>  	else
>  		ret = fill_cache_write(buf, buf_size, once);
> -
>  	free(buf);
>  
> -	if (ret) {
> -		printf("\n Error in fill cache read/write...\n");
> -		return -1;
> -	}
> -

The changelog does not motivate the removal of this error message.
It seems ok at this point since the only failing functions already
print their own error message. Without a motivation of this change
it is not clear if it is actually intended.

In any case, this looks good.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette