Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <213df261-03ee-4b13-80ac-236c2dfde09a@intel.com>
Date:   Tue, 28 Nov 2023 14:10:33 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 03/26] selftests/resctrl: Refactor fill_buf functions
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-4-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-4-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFhQTURuNlNCcXNzZ2poY0RJL2V1RVJRWW5DK2Q1OE9QRCtrK2ZzL09kZkJv?=
 =?utf-8?B?MUhQYkh2WHh6UHVVZkNtZi8wUkJPQkRZbzNyK1p5RTNvUHhqQ3VscjFhazk1?=
 =?utf-8?B?VDZjN3B3d0FyOFdIT1JmTTBWbkg4YnFmVi9SM0dEL2t0M0N2V2UzZG5wMzZZ?=
 =?utf-8?B?MFBqVlJ6MlFCUXBZTEVna1hJaDF6akxpNm1DTFZLSUZVZDlSMzdMN25uL2pu?=
 =?utf-8?B?Nll6czM3LzVWcEh1alJwU0Y1VnZYQkc2UUtCVUNTendaVndkY1RJRGxFcm1q?=
 =?utf-8?B?QmYzZ1dtSktsTVBubmthTDA4Q2tWeWE2TjhxVmNuTWJJMHhVSmViSVBPYnFL?=
 =?utf-8?B?aUV2SVlpa2xNQmdmN0x1Y3YwTEFIMFVYYmxwWXdCQlRzcm5XTkxRcVU1cjZk?=
 =?utf-8?B?Z0xOM285SjNzMnVFM3JmNHYvend1TmVvb0tjRGYzbXNBbStTUkdwZDQzbGxy?=
 =?utf-8?B?RUtrcTl1RGxiY0VRSXN2YWIzMjF5VC9VS0h2L3h6dFFnMTE0eW5mV0RnQ2xB?=
 =?utf-8?B?QnRoTmZTdkFuc202d0dEUWJNamFsUXJiV2oyNDBGNHBuS25jZnFicTNxQVoz?=
 =?utf-8?B?Y0hmMnB4SGJWNjhwWGlOaytOZC95WjVkeWlMK1Flc2wwRkJPVjhFK1lJdzhv?=
 =?utf-8?B?TGtHbGE1dGI0Wm52SWhZT3B5VldWdlAwY1A2MVZsZkNsMFdFNG9oMGxxaHp1?=
 =?utf-8?B?N1hBajV2R1dpMnhPSXM4MnJUK2NtNG1hZ3BER3dCTlhFbk5hVVV6UFR0WnBQ?=
 =?utf-8?B?UzJ0SXdoSzVYT0RSUmpBaHp2Q2NWbCtub29JMGVHblRMa1JldjdJR2FJRldW?=
 =?utf-8?B?R1kwU3ZFd1VNY1ZGamt3cFJIaHFGOG5TSjhsZU1BVXNzK3NkaHBNbTFtSmRi?=
 =?utf-8?B?aEdXQk45aTJJU1ArTUl0aHlOeFJVcHRSbDI5Nlpjc2pFTHlnNFFnS3AxVkdn?=
 =?utf-8?B?Y1hxSW56V1FWTUlHM3Q4U0o5ZHlkVDdjU1IrREhML0tQVUVwYTBLZ09HYlAw?=
 =?utf-8?B?WHM5OHR5WFVnOUpuNTFhVUMzZXNaTVlHcENKNmpWTDk3N2hUUEtEeWEvRGIz?=
 =?utf-8?B?MWJXTUtHTFg1dnJ4MVBMd2JGYnhXYU5nN3ZHbHBSQ0RKaHdySEllblh3T2pX?=
 =?utf-8?B?OU5sZ2Z2RU5NaHpZSUxHbWh0elZWQkdVSmRSNnhTN1IxZDdPQmVyVndTQlhF?=
 =?utf-8?B?NS9jNFdDU1dNTFZMM0pLc1BxWEtVVXlFWEtxOFhRSXk1OVBkTzJqTzdYdFNZ?=
 =?utf-8?B?SCttUU1oaEhiUkU1R1orYmJ1Snc3NDdVdjNIN3ZJTmNOWGFNbGZkbHhiQlls?=
 =?utf-8?B?bzVnNEEvNkRwMUNOcWdqUi9BdENIVUloZUw2RTZHT2RLbU0vR2hDUkJKKzJx?=
 =?utf-8?B?cWc0Y1pqbFR0ZHpwRDloaUg1NXlxZWpiV2Z5L3dRQ0tuR3BZMUVYWnBvRnkz?=
 =?utf-8?B?UXo0L0NhNVFEK1ZiL2pqRVVoemZ6dUZodmxqTzlHdFJNRVZUcFRmVW5RS3lQ?=
 =?utf-8?B?V2d4ZlMzZ2V0NWtxSlZHZGZnczNXc29RaXBraEVtOXFKcjVBUXM0MitJc1Fl?=
 =?utf-8?B?YXE5M2ZEK3lVU2owSjhDVlJuL3dxVWVwc1ZqaHlmZ3RBT1ovb2hkbVAyNWh6?=
 =?utf-8?B?VzBxVnhEUUc1N042T2hxeHBhVitDdXhFNnVPaXoxbi9ZbWQxOFFJd1o3ZG4r?=
 =?utf-8?B?WmdCalczbitpNDI4R0JhR2JiV1RZTHIvTkFTeWNIUE5yeEZnQWJibzM0SXNI?=
 =?utf-8?B?WWtVOUkxUER6OFBuTEFhMDdYUG9yY3hmTTVOTjUzWklIbys5M0I1VzR5cGFB?=
 =?utf-8?B?OUdwek1wWnB5VThWeHZHUjA5bndwbXBnVHU1UXBuNVMxSHZHQ3RreGdtVlNX?=
 =?utf-8?B?UnU0ZEtnRk83YXZGbGRjSVRaNno3RXA3L2tmZEVxdFRwK1Z1WS9nN1JSV3R2?=
 =?utf-8?B?M3JsMUF2empJYzAzU1pnV3pBZ29QdjVzQTJsSVM0MzdIUUpvSC9LaUV5bWdR?=
 =?utf-8?B?c1NCbVdSMXlYYjJOQmtxRU1ONGY5bU9DNE56NWZzb01VMFpnTmNDUnhNbE1u?=
 =?utf-8?B?b2c0WjhTem1vTHNHQjZkM0ZwQWs0YkhTTWdxVXEvZ1BGWmVkVUNxNnNWbDI4?=
 =?utf-8?B?KzArMzY3Y0JYUU1rVlJVK1Bpc2hmUlRheUEvZ0dnMGp5N3p0eEk5RXl4TmJR?=
 =?utf-8?B?OGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d18ecdb-d7ed-4635-0bb2-08dbf05ed7e4
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:10:34.3916
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lGsKP7KHX6SRQRzXqz5SSXcUAhZKS7BcWKoNN8qfVn5ZMfPwfQadOuY9vVIBWnxZ9cdQzrg1HlymU2jbTCbu9SPbemeHAb+zGuON501w4GQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6328
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:11:02 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> There are unnecessary nested calls in fill_buf.c:
>   - run_fill_buf() calls fill_cache()
>   - alloc_buffer() calls malloc_and_init_memory()
> 
> Simplify the code flow and remove those unnecessary call levels by
> moving the called code inside the calling function.
> 
> Resolve the difference in run_fill_buf() and fill_cache() parameter
> name into 'buf_size' which is more descriptive than 'span'. Also, while
> moving the allocation related code, rename 'p' into 'buf' to be
> consistent in naming the variables.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette