Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <9a12bc46-ed13-4386-be75-8075f8f1ca12@intel.com>
Date:   Tue, 28 Nov 2023 14:13:29 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 09/26] selftests/resctrl: Split show_cache_info() to
 test specific and generic parts
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-10-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-10-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHZvY01WNzdxZHpBSkFnV2lncjN5WWl0aUdKbjY2a2xrOXJYWVU5STkvb1ZI?=
 =?utf-8?B?dkpGWjlaTkNVWDZEbVArSzUrejgzOXBsTXJyQzl1dWI5SjBpZnA3ZFRaMitH?=
 =?utf-8?B?ckpRNVd0SjJrRld5dUx4cE02UkNWbmpPUXduSXRybDZZalpTemFzbVg3WVVG?=
 =?utf-8?B?aGxCQWE5cmdVTnJTd0tnQWVOYmNCRkt0dFBLUmxxeXNMMkZSeGoxbThiMzZM?=
 =?utf-8?B?a0pKSVNCQWVHZjFGWnVoWGlNbU9MaFNDNlVjZ0tMRmtXNGE5TytXQmxhaENQ?=
 =?utf-8?B?VzVXaVRNZ2pHTnh4aHNrelc3TkhKNlZlSEtTbWN4K2g2RXBNR1lTbEg3Uzdy?=
 =?utf-8?B?YnVXSHF1MHBrcjVKeW9xM1BtL1pod0hRUUlENE0rYWlEejdZL20ya0xXZG9M?=
 =?utf-8?B?SW4zSjE4YW5kcG9NZlJ5UFJFcjQvVSt3R1AydGhhekpBUllFZGMyQkwySUZG?=
 =?utf-8?B?aFV0TDFKVlQ2RTdtZjJjYWJNS0xTTWg0bFVWZVdySmtUUENtUkd5amIySnBJ?=
 =?utf-8?B?S1ZMZ0R0Q0E2UXBSajBERjhaSE0wOVE5ZFBwcXV0ekxldTNQSDQvNnl5Y1Z0?=
 =?utf-8?B?TWk0Y2ZDNFhxUjVGd1FGSTIvMWdld0pYcEp5RFlDZzljbElPeGN5cGJoVjM5?=
 =?utf-8?B?RkVxYWtTZ2VucjExdXk1VnJ3RWFWZkhHR1QzbjdRT0RDTG9CWGM2Mk1jQ25k?=
 =?utf-8?B?dXRUVnA4aWtnZ25ja2F0Y2JFT3VhUVZjekpmVGZrYm5Qa3k5VS9FRGYwYmFv?=
 =?utf-8?B?VWFSdWVsSXhZWUxkdllzd3BMVGNJZU9mZTlpczNaQ3FPT0dGS0RrZ1FmWGk3?=
 =?utf-8?B?Y1h1RDB5L2xPdlBJOEo1VUw0Z1pnNGdMTlJsajJKd0t3eTNodDdaRzBWNndX?=
 =?utf-8?B?OTFpdXE4Q0VCQlFJTEZudGcwTVJRb3dLQm91bzJUZlZGWk5icjh2OFBvQlVK?=
 =?utf-8?B?dm85Ni9xQkFYU2syZTBWL0E2VHpVZG1lblVrWDRzSUhXa2FjQ1NFbUpEZVIr?=
 =?utf-8?B?cExIckJmUjFLNFZQYnZNR3lBd3YrOXVRUzRDeWM2VjFYdXNlR0d3ZXdQK1JG?=
 =?utf-8?B?aWo3aUJ6WVN6eThKL2pTZWJoeW14V1kybFExd1Q4TjE2NGdIUFcyOEFlWk9k?=
 =?utf-8?B?bXNlcVdvYk9tTWhXVHBCWldBU0NKMVJUNGRpV1RKcjdVRGJEWGRZQk9Rc3Za?=
 =?utf-8?B?aGI4d1VUWGRNaVg4NXRlcXNCSitsUVhXcUVBaWhJbm91dHJFM2FXK2VaVCtT?=
 =?utf-8?B?b0MvbjJwdTBUTlNlWnlWb09Uemg1a2ZZa29BNlc1RUJtNmdsY3dhYS9oVk9O?=
 =?utf-8?B?YkZZVXFyOTJxNUI0SDV4OFNrMks3b1NuQnNsUnBTZlI3bElOUlZkdnhxYXMw?=
 =?utf-8?B?UDYzK2hOY3YzVkxnNEJKWHcrY3FpSml3WFBZTVlEdjhuZjNLVWFZYVA4dzdx?=
 =?utf-8?B?RzRVMW9SNVVZVE1GVEk0d2xuOEh1a2RqRTFKQlp6U1RoOTlUY0tZNmhtSmVp?=
 =?utf-8?B?cGsra2JFZjVwRkpUVUVVeXdxS2UyYTBFS2NwOUV4S0VNRzNHOGlQQ1Z3Y0Js?=
 =?utf-8?B?UlpOZUk1SWd1ZDM2MWdydzJLMkptMmw2UE5DaFozcTdUN3RXOE5oUDBCTmhM?=
 =?utf-8?B?SEtvUWpnTDArVUkyRjhrS281eXdpWFNrbklBbTVPWk1rQ1l1RFZMYXdKUHg5?=
 =?utf-8?B?K2xMZkRReVUycGswMUJUWlhhdGVJbDNFczg2VVp4ejJnMWxBNTZPRm91QUhj?=
 =?utf-8?B?cGN2TGJmTmJvWkJTcDVnRWNuQ0ZvZlh2dlYwSEZtbzZsQkJlSEpXZ3BlMU9O?=
 =?utf-8?B?QnUwSmt5TW96ek9BcUgyczZpNHYxdkNsV0pLVld3WnNtdkhhSEltbm42MjFh?=
 =?utf-8?B?Y0VLV3REbGViU3RSOGtDbFVGWWcyUVEyUUpmSWV6UG1mWFF5VUJCaldtZDk1?=
 =?utf-8?B?YmY1MUZMNG5WZU9GYUFpbnRDaUFjaVhFMjZTYjhCVHVtQ0tGTUZjOXdmQUxQ?=
 =?utf-8?B?d3dqTkdzTEU1WTZUNE1EQTNBNVpSU1lDWTV3L1Q1Vnlha0FwWFBMY041eFJY?=
 =?utf-8?B?a2laeFFKM1pQcS9ZWkpnSnMvU2VTdHdQVVRrNXNaK0JVcmt2Mmt2T1l2M2Vr?=
 =?utf-8?B?eXpGTmZnZUt5NzF6QzFmbisvMDJnV2dXMGlHU1J5anZrWkRSejNIRENYSEtw?=
 =?utf-8?B?QVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a393da5-8b42-456f-aec8-08dbf05f4089
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:13:29.9357
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d5U8+enFi3S8PBioxFjZO5kHOjNKa7hxY4D9cON/XkatHcTQq0g4877P/nyOa88HqbJ5gDYaKcwtvTwyP1CHtsqfl5IPFnbKlN5fQes/mxo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8284
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:13:45 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> show_cache_info() calculates results and provides generic cache
> information. This makes it hard to alter pass/fail conditions.
> 
> Separate the test specific checks into CAT and CMT test files and
> leave only the generic information part into show_cache_info().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette