Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <b5b92667-b999-4922-8109-787c3fd85aa2@intel.com>
Date:   Tue, 28 Nov 2023 14:14:48 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 10/26] selftests/resctrl: Remove unnecessary __u64 ->
 unsigned long conversion
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-11-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-11-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VW5ocnJKQnVNalNNYTZ1M3Rmak9rNU9GY0Nwb3hQc3lrNHF3SDRPdTh2YlBh?=
 =?utf-8?B?R08xUnZ3Y2xzUk5LaUdESGdzY1NmNjc0d0FVeXZySU1jL0U2dWwzNkU3Sm5i?=
 =?utf-8?B?T20vVllzTTUvVTl5ZDRFaTFRdHJPRWhGQVBuTlNBUTE4L2pvM2QySytGNlNW?=
 =?utf-8?B?cktkMW10M2xsVmRqMjBYbTJhdy9EZGx5cHpLelkwWDFucGZnS3psS0srNXhC?=
 =?utf-8?B?bTV6ckg2TzVIMVhXSTJRbDFZbFVBTnNyMUl1S2Rna2Z0SCtpN2NhaHVOOUJ1?=
 =?utf-8?B?UWFZLzBNZlVVUHNjWlljdmZIb2xEbFhoSHJiRHhGZWNZZmRZU1A5c3poUk9r?=
 =?utf-8?B?RDRFOUtGR0hrQ2tKK3NDUEkzWGMyV090TzhjMWRpYVV4VXZOSFN3Z3JYd216?=
 =?utf-8?B?RDhDR2RBOVN1THFHMm55bnBUN0NLdVZhbHJDWjhMb3ZXdGdHVjhkOTlrZHhZ?=
 =?utf-8?B?QkVWUkZOVG1OTVM0ZThrZmpqbnNYUmVOQ3VSVWdBUFJKMUJsL1NHT1hGNXZI?=
 =?utf-8?B?eG9OODYzT1AwVEZnb095bW9hU2lIWGVWekZ1Y2tXRmxnUkNNbG5sRlZQSFBt?=
 =?utf-8?B?T3NnTHZBaXJ1dDdnaDNqVXFrMFM4U2VxM2ZlWmRtcHRoNmNaczA5VTN3Ujd6?=
 =?utf-8?B?T1ptd09JaHJOTWZ3ejFlME1rRUUyM1YvT3BURjJ3bVZHV21Wc3hEelkxMFMw?=
 =?utf-8?B?bENsU2tHaitkR2hzRTByS2lielV3NHhMMzhORGtrdmNTN3hkMnE3dW9BQlo2?=
 =?utf-8?B?Mmw4alJwOXY4dkgwN29EbWQ0VkFGeFcvNWpNTmNUaEQraW9tVDVGTzUyVTVp?=
 =?utf-8?B?Szk4R2c1dFI0a0JDcldOSDRaampPMThTMnRqOEkvUTdUY2c4M0FvanBOdHpk?=
 =?utf-8?B?aUtMVDRlNll2L3VmejlCRWU3dExleUtUU2U3ZldIUmsyS0N3MnczalAyR1Vw?=
 =?utf-8?B?SkowWEdhcEFKMWVLMmFIWXkxN0NmOVVYdXVoM1RrLy9VRElTeEJpcmVBNXFx?=
 =?utf-8?B?UWVQRVc0RmdlMjFiajBpZlBsNmpNb0NiWGYyYjNmZ2NmSXExYncwZ1lyVDdv?=
 =?utf-8?B?MjVjRjFEYkNtSWx3eXZNNG5KVVpNek9mWWIyOE54bmZxbUVLQ2o5ejVoMW1h?=
 =?utf-8?B?UzA1d3RqR2ZpaWVtMGVnNkNaZEN6RnlpeUNhUm1rRkJZWjR1VGZjdW5laWZU?=
 =?utf-8?B?MVQ4U1NvZTVBUk1RV04wRndjb3JGRUo1SVJOK0tsdENvL2Z1R0xIM1Q2dDRK?=
 =?utf-8?B?QTlwSGxJbUNEbVlsdXdQaFJMdlEwUGFlV3FjMWhoVktHd0UzK0tLZ3BNU25X?=
 =?utf-8?B?YnBIV2dvTnlrMWhZWDBNOXlaY1ljU3YzNjRBUlJlem9jZ29iMUFGMnZaMDND?=
 =?utf-8?B?VVYxa2FIMWtsUENnSUNzWlNqZVh5ZjhRR0Q5eGVCNWlZQUdVcmxnYllSWEVi?=
 =?utf-8?B?TWFNNUNNU3BjNU93OE81b05Kdld4YUxLY011MmMxRitTYXNQL1pMS3Q5VlFH?=
 =?utf-8?B?dFJ0cTlmeUJMeGF0Z2ZYbmJCL0c4aC9MTVdSRnJLMVFHdGgrK0g4VThQdlFO?=
 =?utf-8?B?Z2NveG0xdjgyK3dtcWpvVWdCQ1p1UnE4RXhoVVRWekgyWkZsalBsbGI2Q21C?=
 =?utf-8?B?dkk0bHpxY0kwY3M4MXgyeFg0OGtjUWowY1FoUS91K0pQVXZCcWx1bUt3cklz?=
 =?utf-8?B?czRLMElyVzl0MmhKVkUxMVdUOWlVTGFnbW5nb3RlUUc3U0ZZenc2aTJvVFh6?=
 =?utf-8?B?U2FPd0I0bjBzc3Vwdi93a0ZXZm1pbGN0cjg0N3lHSHRQT0pKRTNVMWFwS0tv?=
 =?utf-8?B?Nll2eHRkZHc2N3VTM2d3YXF1QVQ2dUFOZEpRay9KZ2lOS21KRWI2QTd3UDZI?=
 =?utf-8?B?K1NTS0NzVDZDekhkdXVwYnhseTF1a2MrajJVYzYra3d4c3RQZWtDWkhvQkxD?=
 =?utf-8?B?aVRQcGY5WHJLQm50N2xhcVgzZ2l0UFhvcloxV1J5WUdhRVVkYjV6TENPbmhJ?=
 =?utf-8?B?dDJYOHYwY0pkSDhVNGR5RFA3bHBKaDRtQ2xsWWg1U1F0YmhNemRxVjNDckpQ?=
 =?utf-8?B?dGZDQVN6cXlLRFdEbXo3bUJkU0FJRWhiREY0eEFTc0RMZ00vTXh3bzBCaERn?=
 =?utf-8?B?ekEzMFBPektJbjNONXAwRnNQekZWeGhLSTRqNTMxdzVoZ2xzNUJyZTRycmh6?=
 =?utf-8?B?U2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b9b968c-c6de-4f5c-a674-08dbf05f6fcc
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:14:49.2406
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UZ/r5Dzl51p9sUGtfqBG0WZljdYQT/OPM4IbEGSJcaUnHAH03VooZDPe4tZuNJNqRyaYKRBAkUf2USW7zKruXFe7esTNxmY7d0jdSqD3LgU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8024
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:15:04 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> Perf counters are __u64 but the code converts them to unsigned long
> before printing them out.
> 
> Remove unnecessary type conversion and retain the value as __u64 whole
> the time.

"whole the time" -> "the whole time"

Even so, this does not seem quite accurate since not all callers of
show_cache_info() and print_results_cache() use __u64. This seems ok
but it would be nicer if this was highlighted and not use "whole time".

> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette