Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <4e804300-79e0-465e-aec7-b7a09efe004c@intel.com>
Date:   Tue, 28 Nov 2023 14:15:02 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 11/26] selftests/resctrl: Remove nested calls in perf
 event handling
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-12-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-12-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFJNejR3OWFFQm9QQjRjRVF0WkFCYmNOb2YwZVA2WHBvbjQzNDZvNzJ3c09a?=
 =?utf-8?B?d0svMEdpY2Y3aENnSDI3eWVMR3p0YkhINExSVTlSWWRwbFl4eTZGd1haY0NN?=
 =?utf-8?B?V2l1OHVnbWlZL2xFQnUxcjVqSlFiZERBbXk4WEk2VDNDRnRjSDFQbW1Jdm5S?=
 =?utf-8?B?TjZRalJsVGpqVmxsdmhnd05MN0xTTkowekFlSUp1STkrdFdKTkVlNUlBejJ3?=
 =?utf-8?B?ck8xWU9TczQxTmM2NWJLRHVlOGFOV3NuUEZqUXhCODJhcEx4am5sM0lJSlI4?=
 =?utf-8?B?U0tMdTByNDlQSU5EZlZwQXRYVlE5RWoxNUQ0K0Jnc2RDc1owTEUzWEJITEhY?=
 =?utf-8?B?bVExRExKbTRBc29Fb3NROTNyMnhLV0Z4OFdraTR3blE5enMyTi8rQ2ZWTmRj?=
 =?utf-8?B?K1paampqSW5WQ2Z6NGc2Tm5aOSt2MG1OLzJGd1JvOFh5djhoVUZFMFVZRUc3?=
 =?utf-8?B?SFU0bjFqdkZNR3YyNVM5OFBKQ3F0K294SG1zbEtORXVJTnJyTTkyRWgrMHhx?=
 =?utf-8?B?TUFSVkw3MU9WWFZ1eXZJZnlSaFp0dGxSWTZUWFlzL2tYeTNHblNDYTkrVjJo?=
 =?utf-8?B?ZUNycU9SOTU0OEdpRnNyQUtEdStkV3pVNTkrMHNHNzFkcFpYVWJEcjRRbGtx?=
 =?utf-8?B?b1E3REF0Z1dCR0NTNndSalZQaS83aE1FWGRHSnVJNkVDVnRUbUNlMDVnbDlO?=
 =?utf-8?B?SUtmNzVJenl5RmVoMjBSVUtNaWxYOG9wYi95QkovY2Q4VnJJL1NhcFlNRmRH?=
 =?utf-8?B?VmtSaGZQdUZFK2pJeUdJUjRiM3YxTDljcWN3T3RkTWNYZ29GajN2ZzhHQWQw?=
 =?utf-8?B?Q043aU1SUkMxNHBsWU5XNThjZVVFb3plWEpuT09RK0NNRG1SaVVMNmt4bEQ2?=
 =?utf-8?B?Q0E4VUNQSVNTNFo0WjFZSlJUK2Y4RlNzbHoyZ25saGlaZGM3eGJSdi9DKzVx?=
 =?utf-8?B?ODZxMHQ3U2duVUxWaWdOZzlTdXRHSDZjcGh0S0ZOYmMyZ3BhdmRFUWNrY1ZE?=
 =?utf-8?B?eFR2V1lTS2lYSnFNTnFPYkN4eitTUnkxYWhSTFZ3dXdtVFZNWXhHWGtRa2th?=
 =?utf-8?B?dkNtQjU4RW5STWRod1hmMXpneG1IbVR1Vytkc1pPOFlYSG5BbHhldXVKaTlK?=
 =?utf-8?B?UWlYeTM1U0FnTURVOWU2YU5xc2twbk9DamVzbjB4dFlxbHQ3eGRMRUQ0bUZC?=
 =?utf-8?B?WGhVWE9MUHRjQkN4STlmMEZ0QVdCcVZsQTNQVi9kRURlejg5TVBHdndjM01i?=
 =?utf-8?B?R1BPNXJBSjFndTgvbzlxdVhTZUc5Kzlzb2JteDdDbVFqUW9QQy9vTFNhV2Q2?=
 =?utf-8?B?N3FrdkdlN0N6M1FROWlCSXIrNUZzRGZ4ZzBYM2lZQ2Y5N01oaVpyU1BDVWM5?=
 =?utf-8?B?L3pWaW9QM3pSUTdKb1lyMWJBZGhOUlZ2bmw4a3dud2hqNDZjVmRVVkNDanNa?=
 =?utf-8?B?Qm84RmNKSS9iTFFZa3FENlF5c0ROZ0hpYVY5VUlGMmd0ODNvUkZIbmF3VFV0?=
 =?utf-8?B?REttdzExRXQwVHgwOXpWZSs0a3VYdVBPZ2VZU3hDQjZUbjNZSWc0OVByZmxC?=
 =?utf-8?B?ZFlMa3lNeEovOWY0a1MzNHJJU1ZwZGM5dEVWUzlPMzFld21pVERuZWlUNGYv?=
 =?utf-8?B?WEp2RFRrT3pvdk9IaDFuYzZQTjlKcVlNZXF1cEdBeFRoVzJpcFE4citvNThu?=
 =?utf-8?B?VENoa1B2dHduWDQ5SUtFNk9LMGdqTENnK1FUTjZuVG9LK1Y0SG9hd2RWOE13?=
 =?utf-8?B?Y1FucjJITktoVkdjWVVvUTI2bW93b1h3S0NSL0QxMGVsd3FaaDBxL2JZRU44?=
 =?utf-8?B?aXVNajBBRUkxVXRUY0NnZlZGZHc3N2NtTnNjTzg0SS9DSHpYT1VsRSszSEFG?=
 =?utf-8?B?K3ZLaXd1bms3Z1BmTkREYXc4bm05VVlvT3hnRm5jNGJTZ3dJcmdPby92MHhx?=
 =?utf-8?B?S1pRdFZPZHBWT0FpZkNZNWprajNpVG10U1ROUUdlZEI4MkJrdFBBQWVNMDZC?=
 =?utf-8?B?Zys5T216ZlRFeWFJcWtlQkZCTXZUU1RJcFFXNkhqbTcrU1JPN3FQd0Jtd3Bt?=
 =?utf-8?B?WXpGa29KTzNXZVpIY2pTWHRFeUh5RCtnTElQUnZmMFhDQ2IzQ21RZkpTMVV6?=
 =?utf-8?B?UEYxVTdhVnRxZDU1QndmMVQyMERzSllIdVBRamszalhNWGlRNjhuK0JHL3FX?=
 =?utf-8?B?eFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d1093cd1-8335-4ddc-f98f-08dbf05f77eb
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:15:02.8687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7ZqRpuEiGpzcm3nXK7aBeLaMOqbNsDMDErndg5jBUedcT7+41nIaJyhR8Rayl/VDYayw4Gg3IiumuZeYa1fnvE7/QmQe/4xzt6dI/NnoP3c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8024
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:15:18 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> Perf event handling has functions that are the sole caller of another
> perf event handling related function:
>   - reset_enable_llc_perf() calls perf_event_open_llc_miss()
>   - perf_event_measure() calls get_llc_perf()
> 
> Remove the extra layer of calls to make the code easier to follow by
> moving the code into the calling function.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette