Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <374da220-80d1-4d65-ab29-c92258d977af@intel.com>
Date:   Tue, 28 Nov 2023 14:15:18 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 12/26] selftests/resctrl: Consolidate naming of perf
 event related things
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-13-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-13-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3VRNnJSLzBBR1dzc1l6dm1QZ2k2bVVpT3RwYUpwRjBGV0V3R0RtWGpFeldj?=
 =?utf-8?B?YTlnMGszaEJsc0g5dFdlaVpIc1A2azlDbnFZRTlvTmpZNkxPTHlBbmVwT21N?=
 =?utf-8?B?R1NKY2NQREZ2YVJBUGlPZVhJdGF2NmtMZzlVZ2R2QnkzZGQ2bFZzZCtOZWx4?=
 =?utf-8?B?dDlXcFcrUWFJS251enpYb3AzUUl6bmx4MGFXUmFxV2NzWFpLUFU5YU50ZW9E?=
 =?utf-8?B?bkRiMDkrZFJLbDMvSkNuZ3NHVXhFNjdYVmwwWTZ4bzlvbk5FRmp4Z3JIUTZB?=
 =?utf-8?B?aStYVnlkZmpLY2svUGFEeFQxVEd3ZXBUZkJabHlsMUNIamJmekE0RGZiNDhW?=
 =?utf-8?B?ckZNcGpneVdtMnRpbVNnWFVWeDhYTHVpeU5MeFp5bXJJYjRBVjdwRHFmcCs5?=
 =?utf-8?B?VE1rOGQybkNvZU9qSldQTE92MDV6SG5iZ3Z1aHQ1WkNmc2pIdjlwZkhWYnJr?=
 =?utf-8?B?RzFZdFEveVo3M3BrdHBCK0I4MUVFUVpUYitsL2dmM2M4WHVyODVmZjBsWFR2?=
 =?utf-8?B?WlRSNCtqQWRxeDJxU0hZWTFGTHNIUXQrT1A2dmFPS1pwbHVYM3U5UStJR0FX?=
 =?utf-8?B?SG5VSWxWNHg1S09WZmYzYVNsVDd1VXZLclRPR2MvenJ3V0Z2UmVvLzcrRjha?=
 =?utf-8?B?bkZLMFl6Uk4vbitzQkMvb0tkSTlHVm1KYnk5eVRYME1EREdxblhQZG84VXVk?=
 =?utf-8?B?NVpBUDdZMkJ2blZDQndwTUJ2NEo5eEtxWVA3SjZoWTFWa3RBeFFOMlZ2L3JC?=
 =?utf-8?B?MG96TUJPMlZnM0xmVS9WM25nbzVWR29XN0ZBaFJQR3h6N2RtSmRrK3EyVEQw?=
 =?utf-8?B?K0NkNVdRZHZXWG82WFRlYmxHNGhBczBzd3RoOHRlRkoxbW5KK3UrWFdkUWF6?=
 =?utf-8?B?OTgySXZweFl3MC8xNjNRY1JrSlpHcktMcytYM0ZtK1R1cTJzRWRiNW9neHBD?=
 =?utf-8?B?eTRvQ0k2cEZZOWRJT3A5RG1mczE4V1I5NWhTWnpicE5jWGJOQ1ZXQVpObE9B?=
 =?utf-8?B?TjV5R0I4NlBiVmhSWjZxQndRUU54NmpsTUNDZFcwYzBTamhkd3hObDZPa0c3?=
 =?utf-8?B?YlRqTDNHa2ZsWTFTZnFKWElHRjFlN25hK0Y5Sm85UlFvUEJWNG45QXdaZEN2?=
 =?utf-8?B?a0YzdmZXZGxaTUc4RVpLSit1RCtvNFU0eTBZbXIwVUdKK251RjBYclQzR2R4?=
 =?utf-8?B?UXRuamhsQkpsb0s0NmFOQWdpRHh1YVpqK1ZBa0ZOWVBHczlnS0pyaGFCcHp6?=
 =?utf-8?B?cjZacHA2b2M4QUt1SDZMUzFCOHRaU216eWRVNFhvaExSb0V5VjRDcFNFY2hs?=
 =?utf-8?B?Ly9xZCtwVGhUTFplTkxBMDlsd0tENzZ0VVM3Umk0b2QvYnB4aU5CTlpodHhR?=
 =?utf-8?B?UFA3ckU2cmwvUkZWWlRMZTF4L1kxSktwNk41RHY5aktvWWFpdmgyQVlhSDFj?=
 =?utf-8?B?cEFkV3gyakdRRXBUTUJXUFlQQnRFaXlFWlE2a0I1WTJlUFU0TU90eHg1Q0F4?=
 =?utf-8?B?M3h4M3hUTmE1Wkx6NjhxMVp5KzZydVZPZGxiMVZuTVpkRk5nbDJEbnJGRGxj?=
 =?utf-8?B?YVRBeWw0b0hiUU9zOVVrYmlJWE5QQkVLZkErT1NtZkdvQzY1VmJ3bVVLaXVK?=
 =?utf-8?B?bmliNUdOcFE0dWdBd2pEaGNsei82YTdoblNld1RZcXNoZ2NyZVRFMDMvQU1O?=
 =?utf-8?B?SDZxSEtCa3J6TlhXSmRteHhFMXJuWmlvTWp0eitIVnE5UlpWTE9vRWwxQzdj?=
 =?utf-8?B?Um5xSTNua0p3YnpSL0JzWWxJNFdSRmdYTzV3dnVaVkhBNDFBanBwZXVKUjB6?=
 =?utf-8?B?VncxMXdQbnZMWFhOOWFSYXpCZy9sejlpTU01QmVrZXBWa2QzYTZEUHdoK1lj?=
 =?utf-8?B?Q1Q4bmlVcWhiWi95YmRxdkFzRksrSkF4czEyRUhhRlV5cnVqRHpITmo2T3h5?=
 =?utf-8?B?WFVON2FYclZsVVZhNGJaVUNwV1VHUk5vZDBJVDF2Ymswb3VUbUFpYS9kZHVs?=
 =?utf-8?B?S2VIdklaLzV5dXZLS3BxS0F1VE1DWTkxbklPeU0wdGRFVGY2a0Nmd0VyOHBJ?=
 =?utf-8?B?QlN6OWswVktWSWJFY1FQSmVFUldKYzljSnVkbzBCWW1SeFZVVnNTcjAvSmhr?=
 =?utf-8?B?ZVNVa3hNNG5KQ0dZWG9XeEZPY1J1ejFPbWpaQkJnTy9UeHNwN1poajFmdERk?=
 =?utf-8?B?ZHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d83c6bde-af65-4104-91de-08dbf05f819a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:15:19.1228
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8tMgeU8jqK2IeEFsJYDDjP3b9Dl4kU49CCxf7TsKqjYieixn1KezDxgzOG/Viyebzzw2WDVCwZWKYC91HpZwiizZUnZb/ka/Z/rrUDLgCWI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8024
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:15:35 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> Naming for perf event related functions, types, and variables is
> currently inconsistent.

(nitpick ... instead if "currently inconsistent" this can just
be "inconsistent")

> 
> Make struct read_format and all functions related to perf events start
> with "perf_". Adjust variable names towards the same direction but use
> shorter names for variables where appropriate (pe prefix).
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette