Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <1990a455-9698-4d9c-bbe1-c47fa83cb71b@intel.com>
Date:   Tue, 28 Nov 2023 14:15:32 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 13/26] selftests/resctrl: Improve perf init
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-14-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-14-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlR5NmlIa1hWNXM4SnQzbWtzbzhxT1F5dXlFV0w1cEQ4QmpjYWpNeXRaZlVQ?=
 =?utf-8?B?TUYzb0xRVy9hQTZ5MlN4cThvR1IzU2dNTVlIaFlYc1NJRmFoZGpNVmVFTG9w?=
 =?utf-8?B?V2JKN21XejhnSFhtOFl0dEdXZzRaVE5RUkFXbGJVS3RyTkZuOWR0OEpTcGNR?=
 =?utf-8?B?RVcrQTFhNlRSRVFpUWhKWjliT0JsZGhndjVnUTVxbGVKOW90RlpaTnVPMjJR?=
 =?utf-8?B?WkRsOTJJdi9PUHhpRzZ3bXJqK3ZCL3M0NXVlem9heEpVUUxtTFpzcVROVlRR?=
 =?utf-8?B?dWVBK25LV0NIQW5qSHBSZTJ6OUtBTlVPSjY4dnFHRnNSbVJrVkU0U3Nnelh6?=
 =?utf-8?B?ZzdRQ2hKM3JyNHVZdGMzdksveDBEekc1d1JoN0c5NlNHU3ZUeWNrZjdPbklQ?=
 =?utf-8?B?aFduclpZZFlFU0dKclhLOHhOTWovdDB0Y3pUR3RiKy92elptQVJ3ZUtnR2JF?=
 =?utf-8?B?Ym53WlhXcUJGRTZ1T09jaXl2OXIveHU2MjJ0dXhteWQwQ0VTbEk3ZHV1L09W?=
 =?utf-8?B?RFo5TS9xY1ZIaDB5RWxHQnJid25YWGoxaDRRT29IWnpvenVkTXorVUU2TTBn?=
 =?utf-8?B?Wmp1dU1xajV1Q2JUSGlVMzBhNVJZbWNMcS9VcjRXZG5hUWxaRkdFUnpLTXhE?=
 =?utf-8?B?ZC9sVm1ibXZqQTVNc3IrdUtMNHQrTHRxWG44T1VTaWNSeWNmamFtMitBaHZZ?=
 =?utf-8?B?SWVhcWU1MER5K1ZJZWgrcUtXMERIT3IrMEZLVU1xS1czRXhXSEtPUUFyRFov?=
 =?utf-8?B?Y05CYmtLSisvZUZrNnkvWkg1TTI2bE9SN3FkcklDZmFOQTNybTl6K2Y3ajNW?=
 =?utf-8?B?YmcvMzZyRGdqeEk1a1hzUnZNZU1NTkpPSjUxcTRaZVh5TGp0dE5QTDQweE9R?=
 =?utf-8?B?QW4wblhxQ1U3RmVISFo0Y3BYTHV3ZkdBaVdhYklCbVlQS0RoUStMVkdKNUdL?=
 =?utf-8?B?MVRiSElKR3czem43WlFjS0U2eUc5azdCY2Q2eFFMa0Y5b2JhUzQvWUovVlR0?=
 =?utf-8?B?bGZHSW44c2hRWk9Mem4wZktYQ3NsQmQwdmtqZTFzN1N3VHhObERGVlF6NEM0?=
 =?utf-8?B?cnp3Y1NTaWdvaTFSaXJmZWczMHBuZFIveHhxbVVzd2VwQ3YxaVkrSm0ySWtk?=
 =?utf-8?B?ZjJRS2dIVHFnWjU4ZjVCRFFDbVFOM3M4dFptSGJIV01iQXdVcXJQbVFDRks5?=
 =?utf-8?B?LzUvaVRSUHZEcVEvNDh3WXZXYTBXK0tsbmtZTjNDMHZNdk1lK2kwVUtVWFgy?=
 =?utf-8?B?NCtHdDVNTWN6RlRkVC9vRC92NnhOTEFhaS9DTzBLRmhHM3AvZUJFZXV0UlB1?=
 =?utf-8?B?T2FoTXhaNjNMbnNsNUk5Z09pYTAvQldaSG1lUWdpZXNHRCtHNEFFSmVoSlAr?=
 =?utf-8?B?am1MN0hyQm00UmtxLzF5ZHRUOE1KQXpMNFU2VzVBcU9DR0xkN0ZKYmQwZXNu?=
 =?utf-8?B?QzE1OUN6UGU1bDJWd1BLY244V0hCUmdpZi96VHFEbVI0U2FuemNHMy9aeGtt?=
 =?utf-8?B?TFhmTlJMZXc2Z3FMdEtWbDMyY0JTbk1VN3VZamNCeGV5dzFoT3VpeHQrd1Vy?=
 =?utf-8?B?SUVNZHYzL28vME9uMmZtNzdIU0Z6UC9PWjB2K3lUWVVzMWorbEJSUHpYMksy?=
 =?utf-8?B?RlVUNEZaY2ZRZjEyY3RjK1UvOTVWNHlFWUhTZG1Pa0NnVzZPYnlEZ0FCVXQ3?=
 =?utf-8?B?QTFKUnpsdDdhd1FKQ0tQbDNSdVdrd3AzKzBUeW5rTW5UcjRtbTNjUlRzNlNn?=
 =?utf-8?B?ZnVxSzdCTGplVm8yc21yNU5PNHlSRFlHeHdLdXlxalAyb3hMaytRMTNMQzV5?=
 =?utf-8?B?Q2g0MERBUk9Tak5NRjhhbFU0dUJPYWlYUWpmcU9KK2p6aGNMVjNCVDE1Y0NY?=
 =?utf-8?B?RU9Dc0R5QkdBTW5SbXpXWW1aRWgvVW56TllaNU5jM0prdk1IYjl2S0hIeHhy?=
 =?utf-8?B?eTZnc09CY1d4K01ubnYxelh4c28vNWpnTGRLVU5YekJIeW4rNHA5SDdLeTVq?=
 =?utf-8?B?ZjZvUlM3TEJ4blNhcm5rRUxVd3JYZnJrRkZUSWcwKzVKeTFaU1k5bmU0aUY2?=
 =?utf-8?B?ZDdvVUpnRGJ0WDlQdWtXRW56eW9PVjRuM3dLckJTdGQ0aFpSWDE2T1Zmc0F0?=
 =?utf-8?B?WVNtdHR5ajB4WiswZXRPcWpab3Q2b1d5RXErWHFiV2UyWHY4MGphTHpVTzVP?=
 =?utf-8?B?cGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 894c1b3e-757d-4987-386a-08dbf05f8a01
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:15:33.2018
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z3Ra1TXv+srF//V9EB+ceSyTMzC5FfqA7rgzwRHenUOueCalhKXFOCag9CgtraP7D9r20VCbryoVId57qIVYl2wVLXKIxGJHvjx5GGkQLUg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7419
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:15:45 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> struct perf_event_attr initialization is spread into
> perf_event_initialize() and perf_event_attr_initialize() and setting
> ->config is hardcoded by the deepest level.
> 
> perf_event_attr init belongs to perf_event_attr_initialize() so move it
> entirely there. Rename the other function
> perf_event_initialized_read_format().
> 
> Call each init function directly from the test as they will take
> different parameters (especially true after the perf related global
> variables are moved to local variables).
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette