Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <012b2f99-40bc-4859-b419-72530b29b7a4@intel.com>
Date:   Tue, 28 Nov 2023 14:15:42 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 14/26] selftests/resctrl: Convert perf related globals
 to locals
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-15-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-15-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHpxU2ZLVzlLdHVOV1l3Sjh0UEpRY3FiSHZSTFpzdmk1UTJ5bDZqY2R5TTNU?=
 =?utf-8?B?dWRaN2ZIcEN5MTFKM1VNbWhjRWRaUjNoeGhZNnEwNS9xcDM3c0NiTzZReUxR?=
 =?utf-8?B?bDRBSSsyOHRFRFpKU1puLzdFUmJBaU5jNnJkZ1lRbU9CVXdSYTd4V01ZendX?=
 =?utf-8?B?WWF0Y0xSUzBqbkpGenB0NnlWSER1UlJ0RkNhUTAwcU9vd05FeEU4ekh2UkJG?=
 =?utf-8?B?bVpwQ3lyUmRaajFHbkRkTUZIK0JZMzVXeGhpcGZzZEkyaVZXUktXSDNqT2FC?=
 =?utf-8?B?dVpOSWYwWlAyNzBZYUl2Y1ZXb0NxVlZBY1h0bXg5UWhEMjB4Tm9MNGRhZGh0?=
 =?utf-8?B?alJoZlllV1VnVjhiRHVDalM0L09KV2dueVZRMy9ZeU1CODNqVWVWN2JsQXY3?=
 =?utf-8?B?ZFUrNHpMa3pBcm1ZRlFURTdnTHNReDhpVWdRWlpmaWs5ZHJBblptOHNBb2RS?=
 =?utf-8?B?Qjg3N0RicFdtM0xMcWlHbE0xR2pZNzhydmFJaVdvYkhyVE03eU1JdFloSVRk?=
 =?utf-8?B?anhld1VOcGRRMlBRR2czOEFqZW12OStDU3pRUmF1ZS9sRzFXZDRwc21DK1ly?=
 =?utf-8?B?dG1qalVyKzAwWExvRTJ1S21rcE41RUR1K3pYTWdkM3FxSFFqT0wyV1gwNU8v?=
 =?utf-8?B?a21zbTRCd3dTei9Vc1ZqMVhuQlVpRlRPN0hZWkhTUXliRi9oNWsyZ1hpMUgy?=
 =?utf-8?B?RVpDKy9aOXVCYys0eWpmWFZhRUtWbSt5dHFxRENMRzI3cGF6bm1TcUwvY05k?=
 =?utf-8?B?VU9ZK1gxa0ZvQ0ZneEFIU1ZNUHZpejgxb3NzSldlaEd6UW1WWWw0UVZSSlNj?=
 =?utf-8?B?a2NZczdRc2VtOFBuWDQwYlFvZkNYMnVReTBKTkk1R2hSZXBMMFY1elRPZFFl?=
 =?utf-8?B?YUZZNWpvd0s4OGlod3JpaFlTTVpGeEhhb085SmY3aUhLQzhLa0p3bFhibmgr?=
 =?utf-8?B?N2V3UmpRbG04QnVyb1BnVnR1ZDVsVEZtNnp6RE9tdktybUNnNWlKdXh4UmVB?=
 =?utf-8?B?ck5Wb2dIRkFkVzV6SXFoM0E5ZXJjdHZRNkJydEYxUjh0ZGZFOXR2bU1IUnpk?=
 =?utf-8?B?cFFhM3MxQUV2U1ZBczVQRmo2RUxNWm9WbTlPZDkzVnFRNTBETjZQSlhsY3ho?=
 =?utf-8?B?N1prT1NqenEvWGVGVHN4Rlk4QTVLUXBRRUUyVWpFVTBqdnUvUUhoRlV0c2ll?=
 =?utf-8?B?Mjh0VEg0Z2swZjdZbWx6ZDVwelN3MHIvQnlVNW9MK3hPVjFnLzB6SzVpa3VK?=
 =?utf-8?B?R2Z3WUZhemRsQ3Mwc09LQWhZN293K3AyYmNWVlluRll3UUNiY1Bac2lWdndr?=
 =?utf-8?B?WC9nR01KSEIxUXdpeTVIT2RtMXlGM1FWQmcrdDRNaDNxNjNuSHA0YUN6OVVq?=
 =?utf-8?B?MEhPZmVzYjRIaXZCSWtQb05zYjU2KzYwK2JPNWFSSXU0VlB2MEhpZWhyckNT?=
 =?utf-8?B?a25BYVlVdzZGR0VrZkJQTVM2cTgzaDRKNXlHbS8xTHFyUEhta2Rsb2VHQVZZ?=
 =?utf-8?B?c1RSY2VhTTNCWU8xYmNrcWNYdnZYSDViMDEwbGpzNWlZbWZVSVdlLzdCZFZ1?=
 =?utf-8?B?VDVhMHRyeFFzZlBRQWhsTXdCZ2NGd09hSmptWktXNC8rMTNBczQwb29vSWJK?=
 =?utf-8?B?RlMrN0RPSkxpc2V3RE41T3FjZ1ZGTXpOT0VOSGRYdnJ4VEh3TjVlbUdkMEdP?=
 =?utf-8?B?L1Q2Ni82V3pEMThGTThrVWRZdnUzQ01GME45c3NWZFltL3o5YWJuOFBGYjcv?=
 =?utf-8?B?ZDl0VlJKNXp0eXdPTmlCeVRtbllua2RXNGtpd1VyMG5sK2pncGUyeWw1UTlE?=
 =?utf-8?B?OVM0bUVEaVMvQTFrdGlCTWVtSFNjS0lEQWRDWnlsc1lXZ0lWcGRxMEordjZ0?=
 =?utf-8?B?OGJiWjFneHRMRWs1STEzZmJUSnNXWktwU1djci9wTy96U084VVhSbGtWQVJr?=
 =?utf-8?B?TUdHcmhYVS9PMXM2dDBzQ0pkZitwSjEzQWthaEV2M3k5cWtGRmQ4eWtkTjFW?=
 =?utf-8?B?YU1DKytnLy9md2cwTmo4c1dRUXdZZzB5cVpBdWU1VUFReVdjM28vaGcyVHB0?=
 =?utf-8?B?OHljOHJQL3BZZGpjWEE2V2pQUlFVS3F4ejAzeC82a3h6NWtQdFBTblpKQmNs?=
 =?utf-8?B?Zm5BR0VjQVVpS3dBYmY1TmI5Ni90WlovdXh6azhJUTExanF0dU5FSy9YcjMw?=
 =?utf-8?B?UkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d84f226-1092-469f-1155-08dbf05f9023
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:15:43.4912
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NlI+kN4EcctGIpsRT9vkSNT77EyCGFHMM7dQRrE8CX085lzsf6gXBqXMiSrLTHFW/c3Drd0mc7s0ve1yp7yjpfVc5G3WUj/R0TWl2QJVxnM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7419
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:16:22 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> Perf related variables pea_llc_miss, pe_read, and pe_fd are globals in
> cache.c.
> 
> Convert them to locals for better scoping and make pea_llc_miss simpler
> by renaming it to pea. Make close(pe_fd) handling easier to understand
> by doing it inside cat_val().
> 
> Make also sizeof()s use safer way to determine the right struct.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette