Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <65cc680c-e990-4f2c-aa2d-3f3f96fa7f2a@intel.com>
Date:   Tue, 28 Nov 2023 14:15:58 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 15/26] selftests/resctrl: Move cat_val() to cat_test.c
 and rename to cat_test()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-16-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-16-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGxOcDVnZHhKY0pOS1BjdmhPclZmYUJjcjlKTWQxWXluTEl3TUp0bEhLRDli?=
 =?utf-8?B?RnQ2M0N1WWQyTnpaYkJlckFRSnRLZHdqL09QT0JMczd1SXpnSUZJYytwUFpG?=
 =?utf-8?B?NTFJUEVHaVVxdUpYZklrandlMUFDcHhISFEvdkEzQXhWYmZzZHJNUzRiOFRt?=
 =?utf-8?B?TExreDRwUGNKdWYrejdsR08zWXA1L2dibjBCSkdUMjZXY3dkTjhCZ25KS2gy?=
 =?utf-8?B?My82Mjg1VmQvNG9CbVBLaEtxRDVGRmp5aUw1cDFCWHZVWVlybU5BemVSRENy?=
 =?utf-8?B?U3VvbDNDR3BnelVpNDZQL3R2eEw5eDJnci8xTjhhWjJNUGo1c2k1YXdFbGVP?=
 =?utf-8?B?b052SEJ0MUhHQ2tiakx6TTdMN3BaLzVyWk1vTG9Rb0JNMzEyY0xhTDZIU01Y?=
 =?utf-8?B?UUwxcm9icEI1cU9XeEpONHVmeDdqa09BQ0U5dFdlMXFFUmNWcFRuMVZsaEJL?=
 =?utf-8?B?WmlKbVFTRnV2ZmptTVpLOS95dWNRZmpBRHN2T3ZqTWt3MUsydnJjOXVVWXdw?=
 =?utf-8?B?b3JkNHM2b2F2TnpHeXRvSlBqSEc0ZGFYYTBXNXJTSkt4VC8zUzNJZWdTQXBa?=
 =?utf-8?B?OXdNODZoL0tvc2lxTno0K3Z2bmxyN2RUMVRkN0FXTVVNVzJGZWVNQ1hiZlVR?=
 =?utf-8?B?aXhyNDZsdEFKeW1Tdk5QdU1DbkJIbm5qTEd3NWxYS2RlOVJoWkg2cG5LeE9u?=
 =?utf-8?B?QU5Pb2RWV0xXeitaWHFtclh3UUFXejI0ZVlQejBscXI3U0N5NXhXbFM2QlhG?=
 =?utf-8?B?Ulp1cXY2LzIvQUR1aFFKVUt1dmlWaUNvOHFua3B3THhsQXFYa3RFNk51R2JQ?=
 =?utf-8?B?K0dxWXlBZ1RIVzB4NXdxU08rOXJvQ0NVV2pLR3JxK1dCMW1mS21KbGVSYWtr?=
 =?utf-8?B?TGdPeFRQd2VyTC9CYVFyQ1M5S1dtSExrZ0lvbjQzaDgyVGtadnZsY0ZEQ0VJ?=
 =?utf-8?B?eWp1SkduWUtIVG9iV0NWZWJHMER1Tld2ZU5CMmVMVmdSMjVYSU5JeXYzUGJR?=
 =?utf-8?B?d1A0RmlPOW1BRFBuL1VBZ0NmOXFBYTNObTUzOHBIb2tPZm9ZcXVtMzRXcE5v?=
 =?utf-8?B?UFB3T3k2K21hRVlBUnJ1SENNeTFtRUZMbFI1YThSa0ZxVktWd2thUWZUYlUy?=
 =?utf-8?B?eXFNNDJXdnpHd0Zkd1RwSTlERlpXclMvLzZCVzZJcTkzTkh2b3g1akNTc1dL?=
 =?utf-8?B?M3J4dUdMcEkwZFN3RGJURjM5djRZTk0vZnMwWmlIWCtwbTZ5NEN4Tk1DQW1k?=
 =?utf-8?B?UkVTd3hIcTFHcFRtTnZieVlrUkVkcXRZTG55MXpVNVNwbkF0Q21JVmF2emx3?=
 =?utf-8?B?d1lWKzhkMUY3dzdoMXlpLy9weTZzbE5iTGRvWnk1bk5wUis0STFMQVRuZVds?=
 =?utf-8?B?N3dJdG5NSE8yNnRLVUNyNk5lc21rOGlPR2U0b1p2TnRXa0M3ZlpvUjNJSm5s?=
 =?utf-8?B?bmNEc0FiQlVZNXlYc3BXeDBZMTZwcGtYTlh0RFgxSHFSL3VxQ1NuMG5XREhO?=
 =?utf-8?B?TDlQcUNkYmRoNUR6Mmc0bjhkZW5OQWlMWGw3aExjY3g4RHB2WVlvc2lqK29Q?=
 =?utf-8?B?dzhNQURDTzBFTFhRRXFJRTNzOWoxV2ZsR3FaeGZKSlBFbVJVOENWTFVKUmlI?=
 =?utf-8?B?aVArNGJDSWFOVy9jdXRVQXV6RHVwT3VhTG9BM2N0ZjZwU3Nia3BJejBXT1hr?=
 =?utf-8?B?REJRYTZUMCsvVGZBZEJHMUpGcmRnM2FjeU9nTWpMeXBQWFRqRHViTWgva0RJ?=
 =?utf-8?B?Q0c1a205TmhtTmxXaDZJcHltbWtXRGZ4cTNWWTNWMVF3OUpUQjJYRUFVTTYv?=
 =?utf-8?B?aityQ1VaR3U4MDcrSDFiR3ZtRjFCYlFJS1hlSkdweEtrNzUweGhPY3ZPeEdF?=
 =?utf-8?B?U2xIWi9hTks1T2hURzh5MUZJWnppNHhXYWtBM2FCZjAxNXlDbUFyRmphRko0?=
 =?utf-8?B?VGxNZXA5S2swMW1JOTRVM09wSXNIVHFIczlMOTVxamVtaXd2c2oxeUlvMEpr?=
 =?utf-8?B?ZTFFZmxPWTlXR25CaFZ4c0JETEtPMzdQUzk0Y25BMkhNTlg4ZjR6UGg3Z1Zn?=
 =?utf-8?B?SEJicHBRUTNRa1pFeXZSMGlSMGdjOVpvSzhJdlNuRjFtMlA1ZnNBR3dtY1Qy?=
 =?utf-8?B?a01MUTVOZUpGNFo1NnkrRlFoOWVzUUVId0lmUmxudllNWERQYU54MnVvd2Vm?=
 =?utf-8?B?dUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c7d30c7b-a61d-497f-05ad-08dbf05f997e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:15:59.2635
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jb//iHGoFNsfgeEOHislQOu5oEO9aiqYeY9Mr5kkUmt10b8AtD1jTCTdzgLpVy37iwXN2nPLmSnqX4M4IcGCye+5vX/wNVmJ+w5l2CQ+Zf0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7419
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:16:28 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> The main CAT test function is called cat_val() and resides in cache.c
> which is illogical.
> 
> Rename the function to cat_test() and move it into cat_test.c.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette