Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <1d0ccfa2-05f9-4614-badb-91413a064e23@intel.com>
Date:   Tue, 28 Nov 2023 14:16:08 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 16/26] selftests/resctrl: Open perf fd before start &
 add error handling
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-17-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-17-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2l1WUY0cDl0MnJjVC9qdW5TRzlFYng0SXBTemZWVGpseldZZ0FNc1lTM1dN?=
 =?utf-8?B?K1BLVDlaWEFOUFlHOWp6dEcrNGltT1JZeXd4WG9zVURlUy9PTnZjRXdsRmlL?=
 =?utf-8?B?b3FvY21QMWtkdUxxQkpkMEZ4TzVEYVNvdHZzMWd5aTNpZ0p5RHphTWljdDdJ?=
 =?utf-8?B?dUpoUE51d1FtOURFVEZuSTdpeTVLTmlqNk15UVpNeVlNOHJJcndyQU5QaHJC?=
 =?utf-8?B?TEk3YVVUaDMwbDhobXdyRVY1OFNIN0djeUNDV1pPUFY5cklRVFZsaUNDbnQv?=
 =?utf-8?B?NCtyZTJmNnJFQVNkZWM4aElOSEQzM1VWemxhK2hmNFNGaGgweU54My9sZ0hw?=
 =?utf-8?B?VlQzQWRPK2JwV25Cb1VuRkwwaHlUVXNNTGJyN2NpbGFnRUc2bXl1RGE1bEsr?=
 =?utf-8?B?aCtlQm15bHpxTVdIbnZOU2JnUTVHKzN3UnVNU0RzQndIWWtsazNoN0xocVJB?=
 =?utf-8?B?M0gxeGFKbExaRm1xa3lnbS9pRWdCelJRNXlkR3piK0FuZU9HZy9lNmE2eEsr?=
 =?utf-8?B?VlgyYnUxSnFwYUpwajlWbkpnc00rRURTUEFEMm0zbjFSdXVhS3h1R1NhcG5T?=
 =?utf-8?B?VkZKVWpHdzlyMW11N1hUUFpHenZqQjYrUnVkejQzSGhDcnpLS29hcXd5dUF2?=
 =?utf-8?B?a3oveDIzS0FoQU80WHlFczJqTW5QQ3JGS2hFRnJWQ3ZKYnY3UW02UTI2Q2N2?=
 =?utf-8?B?K2lGSk95SXRXc1BQK0ZYQlZWeEJIa2pMMmpFRjFUT1hwVFdYamg5V2NlSloz?=
 =?utf-8?B?dUtRR0llWU8zN01VR1Jpb244b1V2eVB2NWZlSzNaVStFOGNTMW5hZVlHY3hv?=
 =?utf-8?B?a2tNdDFHYzlWaHVWVVpCbGRvb1NneURGNExhQVREYksxRXJNblg2MVJ5ejQz?=
 =?utf-8?B?SzYrd1JZOCsveGFtYXU3THpFOVlyYm80bXBGc0lZMnpJWGJIQzZ0WlZrcFJV?=
 =?utf-8?B?Y1hjc3VTeXdITkMxZ0hsYXcyc21HbVkyZHV0UUU3TVpaOWc5K1M5ZmFsNDMv?=
 =?utf-8?B?UUdyekwwc04zakY2NGlETmFzanFrS3hXZ2N3aURJL1BtWGxlMUtKd1Q1a3cr?=
 =?utf-8?B?VDNLYjAyS0Q3ekF4ZEZyVUFldUpPSjZ1bGRoZ3VTdkFYVnFBcU9ERUpHMTNz?=
 =?utf-8?B?UHNZKzN1c05SUDhDL1FzcnNVRW5rWVlpdHl1Q3FJSzZIQi9xYWwwNWVFNGNk?=
 =?utf-8?B?UkFhS1ZISVFUWm1VOEMxOC8vdWpEV29aQWJBb1ZIaWNTMEdvRWlHMnJaTnlB?=
 =?utf-8?B?MXpxbit2eVlkT2M5enR2cDR3ZklsK2hqY1gxcEZBNTNWNFZPMFdFRFlKemhY?=
 =?utf-8?B?M0JaWmVHSkNla3lMTTIxbk5yZ2pGOWh1ZFJvNCt3Qy9Zayt6OWRGZTNlbGVy?=
 =?utf-8?B?MGJXMU4wSy9ZR2pVVVNaOXZSOTJxM2dDakpEbWNLbEpHL0NxRXNUb1FIWUR4?=
 =?utf-8?B?M2M0a1A5blp5OWZkZmF2OVFRYXo2YVc2MU9IVThhM04wRUl4U0dKd3lBOFdB?=
 =?utf-8?B?UEtJMU0za01IUEI4dGVQcnc3RUtsSzNCTFlwWFRYZ1hBbmh5Z3U5V2V3YTRG?=
 =?utf-8?B?SjkxMk9MdVNHUXlzSGZTZmtGN29ZMFcyNUoxMVFMTldyYmR5eHVwU1dUVjI3?=
 =?utf-8?B?Z0dPTXZ2MGt0UDNiTXFZaDdpNkV4WFZydXJtMjdZOFZDWTRTL2xVcWovTWlh?=
 =?utf-8?B?SkM4V1ZvOS84bXVJclVNRFlaZXZ1UHJBQ3ZJZFNyUG4xQVFSTmNQMnhBY1Bp?=
 =?utf-8?B?U1BBNmtXTTY3NElFUVdWNFVXNG1jcS9la1ArY2tzTVBMR2pscUN0dmRWN0dp?=
 =?utf-8?B?RmVZTFRqM2YvY3dVZmZYU3pUcFB4TXYveWZ6S0pJTEVCUkJCMVlGcDhLa3Ni?=
 =?utf-8?B?czExS3hGRkRMTnRkcWtEQ0hpQVQxbTVtOTUzSEFtZS9pOTlSemQ0amdwZDZI?=
 =?utf-8?B?SmlYUW5FeUpwM25LdENiaWR5U1pEekkvOHlMSDU4L2FGVnRIZ0NSRUlmcmYw?=
 =?utf-8?B?YlV0d0IrenQ2RitYa2R1bnduMk15Szlpbm1oYXBaandHc09tdHNZV25qWGpR?=
 =?utf-8?B?Q2c2elVoYWVDWmZtc3VFdTVldzVsRUkwTkhvY0FidmxIaW9nYkhXMTd6aGxM?=
 =?utf-8?B?ZFNnbFg5dnZIbDRXYzk4WkNBTkYzQzJveUxTaWpWYjRvRyt4dlpkQ0VybUhh?=
 =?utf-8?B?WWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8953e366-16c7-44d6-3993-08dbf05f9f66
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:16:09.0831
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MvwAPStbiHUKR/XXIqHC9xcBaMkul1mShz38uDidqUspwboBmcCsv74aUSLA14528NuBv5LTToqKNTQWdoy3mFt68bFhknXZXkfmJPi9Cog=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7419
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:16:40 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> Perf fd (pe_fd) is opened, reset, and enabled during every test the CAT
> selftest runs. Also, ioctl(pe_fd, ...) calls are not error checked even
> if ioctl() could return an error.
> 
> Open perf fd only once before the tests and only reset and enable the
> counter within the test loop. Add error checking to pe_fd ioctl()
> calls.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette