Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <03e9c565-ddc3-4f2d-beda-5095d3f3aa37@intel.com>
Date:   Tue, 28 Nov 2023 14:17:18 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 18/26] selftests/resctrl: Read in less obvious order to
 defeat prefetch optimizations
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-19-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-19-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzgzcEx3RlhtRXRJbXdITmdUWUU1T3YrTllLcm9zSnhFNlVyZm10Wm56TzY4?=
 =?utf-8?B?M1FFcU5DSG1NVEZ2NHBZK2Y2M3NtbWY5UDR2ZDZwQTdSTTk3dmZNdFdUUDk3?=
 =?utf-8?B?STVQYzJYSkNaR01TQ3FKZW1FeDFDOWFMWmp1Vk5QQkpjelFyZDNlSS9rc3lL?=
 =?utf-8?B?NW1VNU9kbzVXQmxHUCtSWnp3TDFodHlQZmYxSUJOanQvdDB6eEg2cUR0dWdn?=
 =?utf-8?B?YnBEbzNIZlpEVThoc2FxaHc1OUlLL0xRSW1rOTVKZ2x6T3JmbkVwaHU2aVB2?=
 =?utf-8?B?MXl5VW1oTkxtUERDYVh6OGJwRmdWckx0RnJnaW0xdFlGUGl6NXRUaHVheHpi?=
 =?utf-8?B?L3UrVTROL0ROSHZSa0psK3JnQm5McjhBS3dLaVdWdFJVZmFpME5iL3NuV1JT?=
 =?utf-8?B?R1gvd3hrRHFmMm5YQkl3WTlBbE14bUM2WUUvVm1VaXZwckt2eG93WWJVa1U4?=
 =?utf-8?B?M28xT3ozN1RQc0RIZHBNeVA1SHRjem1OQkhoMlM2S2lIL3FZWlQ3cURpVjZO?=
 =?utf-8?B?NXY1cU1pSkkyOUI4OXVYRHRUS3dHd2RkVlBDRFBWai9pK1A1N2NuQWVTcHh2?=
 =?utf-8?B?N0tBSHVFQytwZEZ6MXpZdW42bUU4Y1YzRGpZQ1BSQkJFNHR2c0lTQyt4b1dY?=
 =?utf-8?B?a3hJZ1FFSm5MQnhtZWhPR0hGUlJhZHN0U0tiSkJldFFBNVR3ejM2d3hrT1NE?=
 =?utf-8?B?blc4YlBCNU1oZEZEZTJ4SDhOcCtoN2FPOE1aTVdFd1NxUE1TMGNVdEVObjJo?=
 =?utf-8?B?MldBcjFqODdrdVRIYm5HaG1YLzM0ZVVoM2hpbmVwMS9Hb0RZUHhlTHpyVVRy?=
 =?utf-8?B?ZzR4Tjg2RGlIRnBVZTgxdVFvdkFSL2Z5M1JMU05uVzFnNW9mWENnRXVINWRk?=
 =?utf-8?B?cjBJS3NIeFl3SDVPNjVnS1JocUY2Z1loQ3NjamZkayt1QWpwdWFwTWk2SXly?=
 =?utf-8?B?cnJtM1Q2OW9MTFBVWU5XeTN3ZStrK0xSOWNyUmpMaUtTbzhFUUdPS3dtRDZW?=
 =?utf-8?B?WHoyd01xMTRKZEVreUlDOG1UMVhEUytrN2hIY1BTMVRnVEozWWh6b1ErTmRZ?=
 =?utf-8?B?VXlZSGxyaDVlSFE2SjE0ODl1SGlJbnN5VnJPVzVkbnhYcHZVZm81d1JsYlJj?=
 =?utf-8?B?Zlp3eWpkZC92Q2s2UUF3WVJWZVhiMWlYcDZ0bVpSSGs5M0ZGdGlidTZFRWtw?=
 =?utf-8?B?WnlGdENuODlGQVNkYWQ2aURVbVplTDdPV2ZJTUpzd3VoSEVyR3R4RnJnU3FI?=
 =?utf-8?B?L3QzNTdBWWRSbmVodkNhV0FQRFhrR1RuTEdNMDA0dmg4aUlTNjZ1VzZrTDA0?=
 =?utf-8?B?TyttdTkrWVoyK3dOWlRWZnRKSjZ2bmk4aFcydXZwc3MzeTlwYnYwVHppbjh5?=
 =?utf-8?B?M1NlRmNhdUdwcEVsOVBrZmM4aGdvc3g4S2d6ZjBTRzNRVGF6eU1PSW9heWZz?=
 =?utf-8?B?amFRMzRwSEVwUEhMT0VjWGVUZXlRMmVnTHZaMlpwSGFKdGFZckRUaUR6THR1?=
 =?utf-8?B?czJJSzFpMmlCU002RitldzNyUGhMWTNITDFvZmp4VXZZeHRxV2d6NXFSWnEw?=
 =?utf-8?B?d21lZ0dTK2FQNlo0c2phTEJTQzNRTldGTFRidm9KV2FDVXhEcGtQbGQyZ3NM?=
 =?utf-8?B?V3BHZ1ZlMlMrNmdObThKcnFoWkFFaUlZQTBMYUc3VXNvaHJva2dkdEFjbmVK?=
 =?utf-8?B?WE84bFozajZQaGt3RWhEbkt6Z2thZUNKVDc4a2ZBQWR3bnhqR2QyMnh1V3BX?=
 =?utf-8?B?OTY3Qm5WeUNJU2x1czdaOWhRY1pWclluc2N4bDMxUE5mc0M1Yjl1VFpoQnFN?=
 =?utf-8?B?UmVSYWNKclQ0MWdFaXFKTVVCNlhhSlBISXhXeXN6ZEJCaTB1dWpKUHQ2OFpM?=
 =?utf-8?B?RXVVRjk0TER2enF0NjYxajZJbExBOXRtd0pVZGpMWFVWcVRRQnVzWWxiUVEx?=
 =?utf-8?B?STV1NmJMMzFSMlpPbHBXSjRrei9sZ1JoeW5uVmV1MUFOdVRibzI0cCtyZ0p0?=
 =?utf-8?B?U1pmUXFXV2g1ZWorMEIwcjJVK0JsaFd6NWgxRU1vR2p6enlnczNIUVNVNFY0?=
 =?utf-8?B?dUFkMTVLSWRxRXMwTHg2YTUzN2NMb3FYSFlvOEZ5bEFYVEhSSlVzcWE0ZVBY?=
 =?utf-8?B?dE9ISUpHUkJUcFA2T0tQUHk3eFFtSHhjaXFUZ1Y0NnBUUmExU2VuUlVHdnZr?=
 =?utf-8?B?bGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bbb7fae-214e-4df1-b739-08dbf05fc8ee
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:17:18.8965
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WbUOs4pFip4+5wV6n37E6bgAZARf01Z9Cpq+PDiiLakDw1b3pAeozKuCHUUwrsYsE/7l5z0EEr0rSbcoX5rEiSe76UHqDkW/TbXQkNCJc9c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7419
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:17:38 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> When reading memory in order, HW prefetching optimizations will
> interfere with measuring how caches and memory are being accessed. This
> adds noise into the results.
> 
> Change the fill_buf reading loop to not use an obvious in-order access
> using multiply by a prime and modulo.
> 
> Using a prime multiplier with modulo ensures the entire buffer is
> eventually read. 23 is small enough that the reads are spread out but
> wrapping does not occur very frequently (wrapping too often can trigger
> L2 hits more frequently which causes noise to the test because getting
> the data from LLC is not required).
> 
> It was discovered that not all primes work equally well and some can
> cause wildly unstable results (e.g., in an earlier version of this
> patch, the reads were done in reversed order and 59 was used as the
> prime resulting in unacceptably high and unstable results in MBA and
> MBM test on some architectures).
> 
> Link: https://lore.kernel.org/linux-kselftest/TYAPR01MB6330025B5E6537F94DA49ACB8B499@TYAPR01MB6330.jpnprd01.prod.outlook.com/
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

I am not very comfortable with all the uncertainty involved in this
patch. A consolation is that this is surely an improvement.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette