Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <82eb1ef0-3818-425f-8a0c-90f58bb49913@intel.com>
Date:   Tue, 28 Nov 2023 14:18:29 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 20/26] selftests/resctrl: Create struct for input
 parameters
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-21-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-21-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0tEOWtwTk14dCt3Mis5dWFuOVZ4Y1B4R1Q1anFENnlFamx4S2x0ekpVRVhN?=
 =?utf-8?B?d3dXK0s4ZDVoM0xoUklnTDREWDFFdGlHaU1yVEU0c2wxUnRYbVh0SEFPK3Zl?=
 =?utf-8?B?QmtDcVJTMFJ0b1luN0pCQUUwb1ZFRWdPODFNUDVoZ256VGhMYTc0WEZ1bVdt?=
 =?utf-8?B?TUUwQk5DaE50MFljSUxUWTU2TjNWcnhiWWM4NHpubCtjRkJBMTZ6c3RVcjZI?=
 =?utf-8?B?ZS90d1ZUSm5VYVowdWVXUHdNbmc5OGxKYXh4UktjWWhWVWNoNThPc2t1aExR?=
 =?utf-8?B?RlNUMm5KSVNHMWw0UGF2akNxTDBmK2RzOUIxK3JpbUZTWGtDWldob3JlMmlC?=
 =?utf-8?B?MUpSYmhRemdwNzQxaVpPc0V4bmJSa0NZdlhkeFprL3RDdnovY3VHVGdMVnFi?=
 =?utf-8?B?TXBYZk00UnJsUDhDdUpGN1daUnk1ZC9lSTdydlN1SlJVNjlraW1lKzZPYkpu?=
 =?utf-8?B?Z1FscTloYmIyYWJUTEoxQVM1UmJWRFBOQ0E0V2JNUHIreVhLN2NweE1OMVZa?=
 =?utf-8?B?c25XVnNFYmI0MXM5Q3NzelpVTktIMWNaSy94VmdFa3ZRdVVqTE1GdC9JbVlI?=
 =?utf-8?B?NUxMZjdBQzgvVjhWTi84OVZCNExkZjJCUXlNZXZRNEFLVnRSdFlYTTU3clRU?=
 =?utf-8?B?Tzg0VFgwRUFmYTdWM0ZVWlgxSW8xVDY3M2hsb3cyMkRaRUlkQzc5dGxqTDBT?=
 =?utf-8?B?WjV6YytQMXJ5d3hJQVBkUWdaNHRORm5QSzNVR0hXdU90K0JYa0dpeDN5dTJR?=
 =?utf-8?B?UEJEK1Q3dVZOdUtNRWFScXVTZzA5UndIL1pMMWYrcXg0SjFvMy85SVp2cWxl?=
 =?utf-8?B?UkRjNEkzQ1E2S2RYQ0dTWTloSVVNRTRSVHpVZWUwM1JQbkFpSm9wUExMRmcr?=
 =?utf-8?B?N1ZLYkJQNzUxRlpCNUhGaUZ2bkdaaVpqTVI1aTViT3JaYVVwNXJEZ1FzbXhv?=
 =?utf-8?B?ZzArRWV0YmlRSTlua1NyYkZKaXJMZHdVeHN6SkdSMVZ0SWd5TWxnVTVCdSs3?=
 =?utf-8?B?OVhlbVV5bGFTMnZ1bFpMNVIrS29ScjVVZ1V2cjhLQ2tud3cwd2tVMHhjTnhX?=
 =?utf-8?B?SjhpWUdkVW1ZNUxwcDRJSDh5a3FZR2pOYWdGVkExRG9hNWZQZTN6VXZjWEVZ?=
 =?utf-8?B?V1dybjlhR3FJeGtvMHV0aldqVHZCczNvbjhDbmo5cEJ5cEpiYnhuZFpmSW1E?=
 =?utf-8?B?dFRzNDJlWS83WCt5N0JiK3FOcE8wcTRhZzhLdVp0NVBlK2pybzA3T0VOYUl3?=
 =?utf-8?B?eWtQZDdLQk15SkhwT3ZiZDArOCsxdDJ1SHg3OTBDOXlkZEJyTlk4RWVZSkNF?=
 =?utf-8?B?RGdtc1U1T2pvQzZGb29wZnNKazRQYkxCRnhyLzBpZzh2THNKcVg5UldFTllG?=
 =?utf-8?B?UElJa2wzUlNsVEJTVFRENkx3Y2U2YzN6MjhWMExsZlJ0ZHFCZW9HU3R2SVBW?=
 =?utf-8?B?bzE2STBMWnRVbmtoU3BBNWwyYkNEMGNLTU9tU3puc2UxWWNnbGRtaWNqTmJh?=
 =?utf-8?B?T083TGRnZU5lTEs4cStiRFlRSkVwK09nK1hwSmxJVTdTK3k5R3p6M3FRU3V6?=
 =?utf-8?B?b2IvTWZtZndVK0hwakdRTEhZM3ROdWY4N2N4eDJCZ0xnYTdNVGZicVBnWHVi?=
 =?utf-8?B?d29NWjBqYkJKdU9RWXNKL3MyZlBZaFRpb0c1aS8xL2VnOGFYdGgyYndtYnFQ?=
 =?utf-8?B?MmlTSHo2eDdoTnNTdXJOV2lVVGxib1JDRStjbXFWTFVMbmlOOFkzcU1SQWFm?=
 =?utf-8?B?OS9oZlh1aXh3NXBNVGVpREcwWjJiVGpZekNmWFg3aFhDL1JxUzZXYzd1dHBt?=
 =?utf-8?B?dDcvdy83R3ZqdGN1bjVMeHUxUEh4YXp6dWI4WmhlSFMvWkN3dmllWExOaHVL?=
 =?utf-8?B?ZTdXRHRtQVNLeE9nMExDSSt6R1RJS1B3QlJmK2U4WkxMdzNmbHZqc2RwUFVh?=
 =?utf-8?B?K0x1OVNHQmlWTnpqU0Vlblpsd2RvMWV2eEYyNTlGVHhralA1UzlMcnlBY0lM?=
 =?utf-8?B?dkRBSG9zWGhWRTBtdDE5dW1BaTAyMnAxRENzc3pkcEtNT0RpNFUyMUJsaUdH?=
 =?utf-8?B?V3Q3TTBzdjFWdC9weVNnSjFHVmhhSGRjTkZXcUtmU243VXVZL3d0QndjNEtm?=
 =?utf-8?B?QTVXYmdoVFBJLzViL1NQOU1TUXNkM0xhMzZMQzlmeEpKdGFjb1J4L1NsbFdn?=
 =?utf-8?B?UGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fd67835e-532a-4e1d-d644-08dbf05ff32e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:18:29.6640
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PMmfhLBnXUIFgTxYxc1zgJsQ+/v/XHzipejWvqs7B97lx2lTQ+Xz6ejmUv1nNQjTp3cmzn8o9rWQ+6tV7I+W4OGH81y0Ozpw5Whn9tYHCaM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8024
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:20:13 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:

...

>  
> +static void init_user_params(struct user_params *uparams)
> +{
> +	uparams->cpu = 1;
> +	uparams->bits = 0;
> +}
> +
>  int main(int argc, char **argv)
>  {
>  	bool mbm_test = true, mba_test = true, cmt_test = true;
> -	const char *benchmark_cmd[BENCHMARK_ARGS] = {};
> -	int c, cpu_no = 1, i, no_of_bits = 0;
> +	struct user_params uparams = {};
>  	char *span_str = NULL;
>  	bool cat_test = true;
>  	int tests = 0;
> -	int ret;
> +	int ret, c, i;
> +
> +	init_user_params(&uparams);
>  

It is unexpected that this uses a combination of designated
initializer (via {}) as well as an explicit init function to
initialize the struct. I think it would be simpler to do
all initialization in the init function.

Reinette