Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <72a26cac-260a-4350-ba58-2651070f0246@intel.com>
Date:   Tue, 28 Nov 2023 14:19:17 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 21/26] selftests/resctrl: Introduce generalized test
 framework
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-22-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-22-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkppWEtpK29hNjkvYythV0M3YXl5RDVISUdPdkRtOEtxY0hOUVJoUEx0eE5S?=
 =?utf-8?B?ZzF0cW9xSlhiK202MjQ2NFBDRFE0REM3eTBHeFZvWE5rdFdGdzdsc1ljN01W?=
 =?utf-8?B?WDExVGhUK1pkL3lRN1JUbUpuZXB6V2FxQWh4RDU0RXdUTE8vazJVaVJ0Zk1a?=
 =?utf-8?B?Y3BraENvTVRLY0dOSkVCcEJiM3pEejlUc2hwbWZWRWNYcUxWSXpxczhJWlZJ?=
 =?utf-8?B?bzlJN1JpcUF1K2swVE8wemt4RzFrQWJRR1FHSThGM0VoTi9qQkZKZEc4MHFa?=
 =?utf-8?B?aUhLeU42MDI2RW05NU9MR2xVY2czQ0NuT3FKdCsxN2RjaGhlcndxdHNtNmQ4?=
 =?utf-8?B?UytJQmM1RDAvV00yWnJKNWNLSHVOKzJ4OWdrVnptb3J3NVFMRkg3RGxmOUp3?=
 =?utf-8?B?MFdtUG42WmN5dlcxdURVNkpoTjFmclREQ3FXUVdTQVFCazRNVDdJS0ZLelRV?=
 =?utf-8?B?Y0FrRkc3ZTJuRXhDd2tlZThURmt2azlYblowOEMwMy9maXBmaGQrWHVDM3ph?=
 =?utf-8?B?TUJod2QxVklZdzlUcEJLb2VVZUZuNFB6QVY3SGN2V2lXS3d1cmg2RG5Zdklr?=
 =?utf-8?B?OXRiNEg2K2hYSkZwc3YzVkFpV1lRZEFLdk9MUWlrL01JTmlYVTJiRXNKbTdO?=
 =?utf-8?B?cDArbnBFMzlpdGpMclZWSlViR09sdEV4d004VkNhSkQ5WFBOL2dOZzd0U2Ji?=
 =?utf-8?B?WGFsa2JZUnI2QUN0RFE2T1dQVEt0L295M3k0aVZEdFBIcWdubVptMkt5NmtX?=
 =?utf-8?B?MFpQbGM0YXlxVW5OOW1PVkFyeFNPaGpQNXdCc0FYTEREVk82UFN0UHB4Tjdm?=
 =?utf-8?B?clJCMXVnd1FESFhzem5MREM0NDEzbmg2dEh5REhUNVY5RFJRWVN6eUVjMXQ4?=
 =?utf-8?B?QjBOVGFmbHF3UkRxTllhL2pPQ0lOYmZKTnNQMDJaZFJpQ3VCclhVUmhtaWdV?=
 =?utf-8?B?TDJHcC9nZ1ZYaCs0aVRvRjhFaFJzK1JpV2U1VmxkcTgwZmtmT3k1SWdJZ1lr?=
 =?utf-8?B?Z1RaYTFJT3F1WU93eTNqZXIxYVJUblVuZnYxSFVFcmIrWlp5cWdxZkRhSXR0?=
 =?utf-8?B?VVVZcUkwZk92VGxYNWh1d2hsd2hRM2R3WXYrRnRxK0hpWlM0WFBQcDAzc3oy?=
 =?utf-8?B?NTZzOHJwcHFyYjE0RlBYUXdCZVFTNDR2RnRnUk9QQjUxQ2xpTWFCT0Q3OHZj?=
 =?utf-8?B?dGdoYVBKQkcyMEQyVUN3TFpubUF3TlFoclYrQTljeldvSUp6WnNpQ2dIeWVo?=
 =?utf-8?B?aHdUZWxmLzVUMXc2YnZ0OU56ZFFyM3orb3pEWVNiZk82QmV0VUovMW56R2kz?=
 =?utf-8?B?dXkwOFlGclNGdzVIcUxFcGZQN0VFeUgwYWZCR3QrVEZ3azhMTWs5ZVhYKzZI?=
 =?utf-8?B?S1N6TFJocldMREVCVjZuTUJtK1F4SVNCeXlDL0x1ZGNtQy93RWFMcWU0ajdT?=
 =?utf-8?B?VElIeXFkVTgxMXY3U0x5YXNsTUJUYVdNYkZDOVAyTTBWNHlGY3dpZWlQbWo4?=
 =?utf-8?B?THZIQ3V3T2JkTmw2SHhJbGd4NURYdFk5L1FCUUhLVUdoUWx1MTJNUUdWSFhR?=
 =?utf-8?B?M29nK0xpT2NCcTBzb3EvR1lUOUFZZlB4T3E5cytwQjA0dGhEWmtmSURxYzkz?=
 =?utf-8?B?K1pRMTFRRkxSMnFoY29UdHhnVkZ3VmEyOHVDM1h4aXVwM0VGR2xHQ2s2VExO?=
 =?utf-8?B?WlZ2ZURTUHdhWjM0bCtpNnJhMkFWRVprd0I0Uk5oMjhweDVCU3U4QjVoWjcv?=
 =?utf-8?B?U3BrcVJUS0lFTkpzbHdPTFQ0QlhpbTg3QUlJRFV3UWdhRVIxdjRqYzE1NU1K?=
 =?utf-8?B?dWIyWmt6QkQvTGZpSjQ4Ri9FK3U1ZTB6NUtoUThoVUdpUlIxYU1RQzBKMVNO?=
 =?utf-8?B?TXNra3BjcHYyU1ZKZnM3SEoxN1QwcjFVZytSanh0Q2tOWDIweG1uN1lvNkRY?=
 =?utf-8?B?THQ4WERJTjJPTmZOa1ZOaFZnMDRjcm8xOWJoS0FIYUpyYjh0OGhxWkpLNERM?=
 =?utf-8?B?ZkgzWm5VcnBWY3hRaXJzcDZLSDd5VlZ0MXpxd1lQMUxWdzhmbnNRYkNWeFRq?=
 =?utf-8?B?cW9scFZDT2lPUnliT0d1RHhKbmdqaE9WbkJrbE00UDY4WXdUMnZMUUpRSHAr?=
 =?utf-8?B?L1RKUnRKTGVlY3ZnRmFzdmlKZnpUZ1lyMTJZRDMyWjN6S1B6L0pJbmZIY2Za?=
 =?utf-8?B?Q2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b131409-cbfa-4388-1412-08dbf0601013
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:19:18.1383
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pDkUgPz6z9jyynnHMwTMQlWaDCyhtuw9Xgu+t26HYRFmchTZr4YQDtYH18VgVaNY8d0VINHrcajfBX21MPyerWlWZ5WLdAg6dxWjcbyLIxE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8024
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:20:33 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
...

> +
> +static bool cmt_feature_check(const struct resctrl_test *test)
> +{
> +	return validate_resctrl_feature_request("L3_MON", "llc_occupancy") &&
> +	       validate_resctrl_feature_request("L3", NULL);
> +}
> +
...

> +
> +static bool mba_feature_check(const struct resctrl_test *test)
> +{
> +	return test_resource_feature_check(test) &&
> +	       validate_resctrl_feature_request("L3_MON", "mbm_local_bytes");
> +}
> +

Could cmt_feature_check() not also use test_resource_feature_check(test)?
Why are cmt_feature_check() and mba_feature_check() different in this regard?

...

>  
> +/*
> + * resctrl_test:	resctrl test definition
> + * @name:		Test name
> + * @resource:		Resource to test (e.g., MB, L3, L2, etc.)
> + * @vendor_specific:	Bitmask for vendor-specific tests (can be 0 for universal tests)

I do not think these values were originally intended to be used in
a bitmask. The current values do make this possible but I would like to
suggest that their definition gets a comment to highlight how those
values are used.

The rest looks good to me. This is a good addition. Thank you.

Reinette