Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <c79d7d60-e922-4ca1-bf83-4c4ed739da62@intel.com>
Date:   Tue, 28 Nov 2023 14:19:40 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 22/26] selftests/resctrl: Pass write_schemata()
 resource instead of test name
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-23-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-23-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEFhNHpVNGR6SWdwUHJJUXlyQVR2UjkwRExMLzV5dThHcjJzd3oza3ZRcUJO?=
 =?utf-8?B?a2dEUE1rdmJnUklDMnFaTi9mQ1pIb1pqd2NXSmdVRDFLWExWYzhibyszSGd3?=
 =?utf-8?B?YkU5UmtXVVFOTVV1VzJqeVdHYTlpYWR4Q0IybnY2bldhQ2NtUkxtdWJiTDJr?=
 =?utf-8?B?VlR5MlM1VFRlczNsR05GMkdOdXBnZy9ub0V5eHVWT2NGMnlxS0ZkZEl4bnBt?=
 =?utf-8?B?bVFra2EyOWN2V3JVbW04N0JZaXBCR2pleXdMbHlBMVlHczBtNmQrd1RTUTBR?=
 =?utf-8?B?dU9VcFJ3UUZPWTVCQ01EVG11Qm04eC8wMDdrZHBFemtFaktnU0RSK2FpVGdL?=
 =?utf-8?B?NVpxdjRhaWxJaUVjb1ZEN3dsT0ZxQWY2VTRiMW5aVHFicjlWdHBMaGhaTzNB?=
 =?utf-8?B?TUZGNUZIK2gwc0ZVTms2MzhPa0NxLzFvN3hVYkZFSmpJWkh4V0w0VFJKTnN3?=
 =?utf-8?B?UmxyVFJxQ1BiY3RnRWtsdExyQTdVcm5LaitrUGZ6cUlFRzhwWUV2cVphdVl1?=
 =?utf-8?B?R3YybnNWd3AyRUFCRUpJRTgxU2xJSVBtdFRsZDhydCtDUk12SDQvbWRtV1NW?=
 =?utf-8?B?bU1hRFdMZ2RSNWhhYVMwWHM1TUorN1BqRVYyNUlaYWRMcGNtSVh6SVNzWUp3?=
 =?utf-8?B?SE44b0VGRndPZXYrUnlFcVhFTGlwcDdBcFBMNzdpek5ueUg0NUpSTmRwWnM2?=
 =?utf-8?B?c09Ha3l4Y1FGaVlNc0VmblVFajRIeUFlZUJaaHZUUWt3V0ZtSVdLUFFXcXRa?=
 =?utf-8?B?aEZTdjBXR1hFVis2RmM4S2xibjdIYTRnMGJZODV1VmpzSDFyTC9FaEZhVXJP?=
 =?utf-8?B?VXFaQVpCaU9oS24zWWowVGRzNWdmRTRucXE5YkpaSUsraGJacnpwUXEwY2Rh?=
 =?utf-8?B?VDA5b1Y0M0ZrU3A0bzVxMlBuZ3IrdCtiMWtGWDVlcGg1SWdxaHNjNEZvSnFx?=
 =?utf-8?B?TWhWajNXZi9PWWpWbGpVUTAzRnl0YVdJTGRYcHNyemJkYWhHSFJOY1MrWFRj?=
 =?utf-8?B?YVc4WjNuWEYvWHJIUlJwRSs1V1pkMlFRVG4yM0ZUN2tlM3dYTldRNWN1bmhv?=
 =?utf-8?B?aS9TTUZFaHlLejA5cjZ0NDRzNlZ3aUswNmtrSXhQZzRmaUREY0lUdGpaK3NF?=
 =?utf-8?B?c3V4Z21iZU1RNGsvYWFsbmU5a2x0NWcwTjFCN0UwcGJPeDBRRFBCRW5LWnFo?=
 =?utf-8?B?MzE5b3BVM3BnZ2EyZWo2SVByQ3FWRjhCVVZ0RjVVOFpYUEUrN1hMbk1ndmwy?=
 =?utf-8?B?WGVSVDhZaU1VNmdVaTZUQkpzREN5MlhONW1ULzJ6N0k4MCt0eDNHNVREYU1E?=
 =?utf-8?B?cjBsMUJhOU95V1NucVkrUXNZRzl2NnBDd2N0U2NUeTZVOFNRclJHU1p5Um5q?=
 =?utf-8?B?Y2E2L01Jb2JNQnl6S0lad0ZOTmxGSnFDWGtsbFFsU0NUUGFjWnZZZ0FvWG00?=
 =?utf-8?B?M1FyRm1YSVVMcGlUTUZYby84YytsYS9TanI0eHdaa0lJV1JqUmFPK0hIWVBh?=
 =?utf-8?B?emNvTWdRR3h4Q29BWmFjaTcvY3Y5c0NNQTZ2NkRHZDVMSTBkblhPeVg4b0Jp?=
 =?utf-8?B?dGlxYytVeUJWZDFmSTZPcDdLWkFwM3hDNjlzOEpVeGlEUCtjbmREczFuaExl?=
 =?utf-8?B?b24wdFBpM3p4SXp2SURZZkZaVE1BMHdHcDdYaEtIYU9EdnhiK2x2bVU4dnR3?=
 =?utf-8?B?TTY4dFVSbmlMK3p0VVlJVFF5YmYraHpNMUoxamFQSXNielhhMU0wWXRrMUVp?=
 =?utf-8?B?WStrSDZnVHl3UXFOQ1I3S1UvYW5Banpsd3dabE04K3NmQUZKTHFoSXhxSDlE?=
 =?utf-8?B?ai9zZ3l2S0V2WkhIVzNCWHBmUG1MalpGWE00YzNDNGFGYkNSSURqQWlJSGIv?=
 =?utf-8?B?NTFzc3gxN2crTHNyMS9wWGpJTEh0VGRyU0QxcUNWczU5ajNyc0lXMG1zNkF0?=
 =?utf-8?B?L0w1VnI0akt5b3V0VUdZWEhodDVFVkd2V1YrdnllOTRMdGVtQWpoVnN5ZXh4?=
 =?utf-8?B?VEwwRTBsYXZScDJwS3ZBOTRyc2VPb1lUeHhSZE9nUjhIeVpnRW85cjZyQTFW?=
 =?utf-8?B?SEdTT2k5Zk5LbnlLczhmWUlBT05LdjFya0V6SnJ0a2NxbVRwc0ZhTnNwRFdL?=
 =?utf-8?B?NUZjOVJrL2NCSDR3U091TjJGRFJ0Y0huN0o0REI1R0h3MEtKWmVxR1phaFNQ?=
 =?utf-8?B?Z0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fae8cbda-190f-490c-8d54-08dbf0601d9a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:19:40.8176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V0SMWUiLpLnVQOs1jDzypPA43Omb+fTVLRBVnFk8Is082HsXXafN1xOghlL+tn+VH3gCy5/ixFNZEhkKvgRbdevn1XpV1MxOUOZAeC0luG4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8024
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:21:11 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> write_schemata() takes the test name as an argument and determines the
> relevant resource based on the test name. Such mapping from name to
> resource does not really belong to resctrlfs.c that should provide
> only generic, test-independent functions.
> 
> Pass the resource stored in the test information structure to
> write_schemata() instead of the test name. The new API is also more
> flexible as it enables to use write_schemata() for more than one
> resource within a test.
> 
> While touching the sprintf(), move the unnecessary %c that is always
> '=' directly into the format string.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

...

>  			break;
> diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
> index b711326b2141..fda5ad812faa 100644
> --- a/tools/testing/selftests/resctrl/resctrlfs.c
> +++ b/tools/testing/selftests/resctrl/resctrlfs.c
> @@ -502,23 +502,17 @@ int write_bm_pid_to_resctrl(pid_t bm_pid, char *ctrlgrp, char *mongrp,
>   * @ctrlgrp:		Name of the con_mon grp
>   * @schemata:		Schemata that should be updated to
>   * @cpu_no:		CPU number that the benchmark PID is binded to
> - * @resctrl_val:	Resctrl feature (Eg: mbm, mba.. etc)
> + * @resource:		Resctrl resource (Eg: MB, L3, L2, etc.)
>   *
>   * Update schemata of a con_mon grp *only* if requested resctrl feature is
>   * allocation type
>   *

Note above there remains a usage of "feature" that has just been changed to "resource".

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette