Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <53812f86-beb3-4f7e-ba9a-6bf0f0340426@intel.com>
Date:   Tue, 28 Nov 2023 14:22:11 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 23/26] selftests/resctrl: Add helper to convert L2/3 to
 integer
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-24-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-24-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkN0SXI4WkNtQXVraWRNUXlBRjExMWswTmZ1K1BlSmhoUUNuUWVCTnNHZnFB?=
 =?utf-8?B?dW5JOEpqR0xhbzN0M1BBOXpObllOZ1MvaTlFS3BkTE5DM1g3aHZjdFpnNXpx?=
 =?utf-8?B?Njh3SE05aVcxVktQcTVJZG01RXlHcXlHWXliUkowdW1Eb0lvZ0pjMGVmOUxK?=
 =?utf-8?B?cVg5R05qVHN3VTVWeDFzMlRnWERwd0xpbDdYTEN4aTJqOE9QdC9nMG9wVi9Y?=
 =?utf-8?B?TUNpODBWSy9IbnZxaHVtNWdxdmt1M0FZTzVWYlBhM3hRVWlXT0Q3WjlrcmNj?=
 =?utf-8?B?YXJlMUpnWVBSekJZRFZSUkdPcHRpeEpvUzZvV1RTZTdIdk5aM0tqSmdZMjdR?=
 =?utf-8?B?bW1GeGtxMjNhNjVGUG9GblJVZmdxdU1GcWZmVXZlcWtUeHB2ZzlURGtHWjhn?=
 =?utf-8?B?ajN3ZlcxRjd6akh1TlhUTlRjakptQkNCazJXZVh0aTM5VkRlZ3FuQTkxRUpt?=
 =?utf-8?B?dEZpWkU0M0F4TTZ0VGgyUEJ1SnkvN3lxQmVTQk1qQmIrdHFCV245V2IvVUQ0?=
 =?utf-8?B?eEFOTlNPdDVFOWEyN3plOTNDazBHcEFvdW1JcDFxRUlRbGoxNzVCYTRYWVlN?=
 =?utf-8?B?N1RTdWt3cWJrdDU2VWFJbDVFakJBUzU2MzRXRS9yZjJxQi9PcFlMa2s0b0lo?=
 =?utf-8?B?aUlHSnVkTWJ1TWJCblhDWWV2aThjU1QxcVFoV1Z0Q082cFZXOWx0d2RpbWNl?=
 =?utf-8?B?eHNQanAvTnBSbmdEdHB5bXhRcG5IbnR3UHJPZTJTU0JkZjkxa0JPQ1FHVkpH?=
 =?utf-8?B?UkFoNG9Rb2FwRnRVWVAvUWd6UWZNbFNSUGQyNUdyMitHN0Zwb0M1UDh1NzNw?=
 =?utf-8?B?MC9nQURHZ0JUK2ZOS01GanVqdEVJT3kyN2prbmRsV0ljSG1DS3FWdDE0OFdy?=
 =?utf-8?B?TCs0KytkQ1h6dUZkREl2YzNMY09sVk03amhWa0I0OXRrS3MwNTMzY0RTU1dB?=
 =?utf-8?B?TDZpSGROc0Y1Y3NpWC8wNG9ldXN6d0s0RzNNalNuYUpISGtGbFhaQ2pkZGdO?=
 =?utf-8?B?Y1BMMmRVT29aRXljR0JORDZRSk1LNmJINE5DVTRPNGR4SDNOQlhJa0ZLb0NG?=
 =?utf-8?B?U0JLQ011VkFBdzQxVnRsSWR4T3F6QmdFYWdHZkhhOGlaQXlQTXN2N0xwVXNW?=
 =?utf-8?B?OU1TcGtXYUMrMTNaTFdQVXlsOEdjR3FIQTM0YkdHSlB6OU42a2NUUXdKUElD?=
 =?utf-8?B?VHlsNTcyZVR0Rzk1dG5nUmJRM3RrS1BsSDR3K3JCRitobUZMbUk4SmFvVkhY?=
 =?utf-8?B?YUZ1UlBpS0JmRHRsd29CM20vV2J5b1F6aUY4VTJPV3FDZG1JbFZsbnlvRXZT?=
 =?utf-8?B?TThqUzN5bFdOWk5QMXErTlp5cGtvTHk2MlAzR2xOVU5DUVk3TXoyOGFaM3lD?=
 =?utf-8?B?ejhjeURSclhjTUdGcmdkMm5IRUs3Q2pmd1E2V2o4dU9RN2RORHptekZsT21I?=
 =?utf-8?B?TkwveEFsZndObmkrbUFlalp0dVVuWVVSVVFxeC94ZFZYYWVDY2RGL3dHdnp5?=
 =?utf-8?B?TE0xZXBMemVGSzN4ZGUwclJJeWM4ZWJvSGRUZi9yTXVpRTZ2anJoTEwybnVN?=
 =?utf-8?B?cnFLQ3hFZWdyajFoSHFrVW8zSEttSmFmWStHaTUvKzJXYy9Tb1k2ZWhGTEh1?=
 =?utf-8?B?ZmQ5RVV5c2lma2hIMHZZMEpDcWVRd2ROSlBIQjJQeDJSZGxDdEdna3dCYUha?=
 =?utf-8?B?Qzg5K1FJUU81NU1YRGpCSmI0dTlKZmk3cWZsZXg3ZTRQN0xPTE9WVVE0RzBi?=
 =?utf-8?B?QXA2TVh1MWhnRWQwSDhTTHl3ZlByT0xXYjBscHdIb2xPTUdFUFRYaTNPRExR?=
 =?utf-8?B?dVFlQW9IQkgyNWh3VlNWdXNGSzR3U1FIVUV1TEU5YngwaC9KeE5BY0l4SmtW?=
 =?utf-8?B?Q0VFSURBb0tyU0F3OUkwLy9OVXBnb2RBL3ptbGUvSHlvNDZvTHlBNklVRmpM?=
 =?utf-8?B?T1JLemZ5eHdxN1ZqdnAvU2MrOVlPTTk5UFNjRDNKbWEyKzUyR200MzRKMEFL?=
 =?utf-8?B?eXRiZ0JzU1plckJoQ2c5NDVnYmdPa21YUWJPdGhsMXlUakw3MnhnWWs2V2hI?=
 =?utf-8?B?NUdhbE9kemJzc3ltTDBVZHVjUDhXaU1WQWMwRC9IL3pGbEtNV0ZjOE54NE10?=
 =?utf-8?B?UVZmVTJNUjZCWThjTWxVQUVVelZMK3krVTRUOGhGaDJlVE8rRnJsd3dER3Vl?=
 =?utf-8?B?SFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 807cff40-2022-48f7-e167-08dbf0607866
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:22:13.1873
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +KAgLYfjXfAUMdlUTH4tA88++sIIyAQFiyGP2b4v4ZW+nLA2PD7PHhsmbCfNnKmOAP9qKAaHcQtvyCxr7taW0MceUE6oXld3dhZOpvwh3qY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8744
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:22:48 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> "L2"/"L3" conversion to integer is embedded into get_cache_size()
> which prevents reuse.
> 
> Create a helper for the cache string to integer conversion to make
> it reusable.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  tools/testing/selftests/resctrl/resctrlfs.c | 28 +++++++++++++++------
>  1 file changed, 20 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
> index fda5ad812faa..38ca3ae562e9 100644
> --- a/tools/testing/selftests/resctrl/resctrlfs.c
> +++ b/tools/testing/selftests/resctrl/resctrlfs.c
> @@ -94,6 +94,23 @@ int umount_resctrlfs(void)
>  	return 0;
>  }
>  
> +/*
> + * get_cache_level - Convert cache level from string to integer
> + * @cache_type:		Cache level as string
> + *
> + * Return: cache level as integer or -1 if @cache_type is invalid.
> + */
> +static int get_cache_level(const char *cache_type)
> +{
> +	if (!strcmp(cache_type, "L3"))
> +		return 3;
> +	if (!strcmp(cache_type, "L2"))
> +		return 2;
> +
> +	perror("Invalid cache level");

I know that you are just copying code here but this usage of
perror() does not look right. strcmp() does not set errno, it
does not "fail".

Reinette