Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <417b5668-e020-46a8-b5d0-80a87fffc634@intel.com>
Date:   Tue, 28 Nov 2023 14:22:40 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 25/26] selftests/resctrl: Get domain id from cache id
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-26-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231120111340.7805-26-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnJxR0pMUkc5YzAxMVdHUS9Rejk3bzIzT2Q1dEs1ZkJ0aXc5QTVldkpab0s2?=
 =?utf-8?B?TnYzdFBMelNWZ2xORUJRcnQ5T3VBQklkRUloczVTT2YreVBSbkh3RVd6SlQ0?=
 =?utf-8?B?OE5CZVZaNGNKQXQ1Y3U2NHVLVERSZmFBT01LQUVJcnVhN2Yvc2dnRVI5aWdk?=
 =?utf-8?B?cWt3Y1RTdmsya2ZSYkdIZUVERFhZUE9hbW5NUFVrdExyQUFjMXRZMklpTGgy?=
 =?utf-8?B?S2o3MUNleXhlVXRFNHQvemVSQnUrWU5ielBNT3RHbm91QVJCUXFqYm9XcFpt?=
 =?utf-8?B?OHBtRkprc1VzUGR1eHdMZmVCVDhBc1h0WUc2V0NCVXNGZmg3VE1tdlF4ZFN4?=
 =?utf-8?B?anpkUUhWbURoUkJmZDh2ZE5MdGVUQ3FacGVQYVdHRjdHa2JEd2FMZDJjeXpC?=
 =?utf-8?B?MkZKc0JFWUtKV1ZWSWVtREk5djFyK0lXZThtNWRWNThLRW5hV3NLWktCaFNX?=
 =?utf-8?B?MUplaHRnTmRsYzNsMXBWUWhaV3N4NEN5bERyaThrV2tpQlp3TGIrOVpkK3pJ?=
 =?utf-8?B?S0NUT2JlL25Xd0o1T1EvbVNMblR2cytDVyt3SWxlSkxRVUR2ZTBiYmJ0eTRB?=
 =?utf-8?B?eWt0MVBmVlNha1pPa3A0R3paSWZRM1Z0VHExYUNKa29QalJhSTJaTlVrQ29q?=
 =?utf-8?B?UmNxa280bFpGbzIrT1lGSWdlZ3M4N2puaHhWdHdrYlhVdGVvcEcwZktybndv?=
 =?utf-8?B?NVZZNm1saUR6NXdiVWtjZDF6YW1WSDVYOUtDRTd6c004TmZKaDFkV0pFc1Z0?=
 =?utf-8?B?d0k2Q1dnUjhSV2RnZVRzcG5BZlVGNGhpSC9pMjkyOEE5dERQaURhR3AxdVVG?=
 =?utf-8?B?bXdqOXA4U09SK1RLaGNlZ1NRRG1VeHRGYjJuZ3cvVjZsc08wV1Nycjd5dHVX?=
 =?utf-8?B?T0FWSi9TTVRZNnZsWDlBamxKNnh6TUlhVXRleFRKanhiOUxsNzBVSEl5NlBs?=
 =?utf-8?B?UHFTV0cvU3BlL1plNmI3a0RRbkZCSU05QzBNTW43OFZBaVFkcFJTcVFRV3hu?=
 =?utf-8?B?ZmZwUHd5QW0xVW56cWdONVhjWmdKRWxVaDF5QjNFVDdTQS9xVlFDeG1ta0x3?=
 =?utf-8?B?eWZ1cGNCbzhYSHVEWUZiTDgwbXlzK1l4Mm9VeFFWTFBDczBmRVZ2MVJYSERy?=
 =?utf-8?B?RWIzbitRR2RXVHBKZTc3MVpsV0oxb0xNSVJ2VkVNaDhLZThMQzVwTDllSjBX?=
 =?utf-8?B?UEdhanNtL1FodG9jbUJibElZREpkUkRVOS9nVlF5N0tCMStxTUtWUnhHb2Jw?=
 =?utf-8?B?VlFZdHQ4QUxScWdVRXl5SVF0bmRvNTFkYWVVcHNXZ2tsZTFaMUwvL2o5L09t?=
 =?utf-8?B?elZxYUwzckNUUm9RcmtlTjk2dWgwTExpc05BdGVaV2lwUzg5K0Z5ZmRFK2h0?=
 =?utf-8?B?b1BxUEJEVW13MENuMm82OGN4UmFsQi9LRll4TVFNaFNtdUpOSG5CeXZ6bXRB?=
 =?utf-8?B?WVlPRlJYMTduTHJTaW5VZnRnMldmc1FJTEJIa2lLNzNVQ2xWSkNxTmE5VTRl?=
 =?utf-8?B?MGt1OGh5d3VJZWU5dExXcmhPcGRDam4xcEVLWUZFT3FnZE5NaklmdlVVYi9Z?=
 =?utf-8?B?NUYrQkwxOGowcHRkcnRQb2NPM3I0czAwRHQvTUdHOC9mNDV6V0gyQzcwSWN6?=
 =?utf-8?B?ZVdJWUZLUkFOUGNRaVhXbTlUdXBBK0I5VEI0ckRpZnd1b1B0aFJTdlZndCtq?=
 =?utf-8?B?b3loaFVrYmptSDZrZmdTMkNpQ3hVZDJnNTJGbzAzMVQxM1J4Ly9ZK1p4Z0hL?=
 =?utf-8?B?M2xjL0wrS1ZJblUyS2RPT2VUL0tYblBMVnZxZXBldTloSzBXWVNqMG9TNExM?=
 =?utf-8?B?b29EZXNmV3p0RVg2M1A2ME5PQ1hKQkoyUnJVMHFNQk4wOTRvTjM2ZHhVTnBo?=
 =?utf-8?B?WE1jRnpXRG5qNzFXWlpVQy9jVkhNY1IxVGR2NmJybzh1dHJKcVk4QnJkY1BU?=
 =?utf-8?B?S1lRdVBkMzJMdnZVWFpxWXFta2pQZ3ZaeXVEKzkzdiswKys4R1p2ZTNrVlov?=
 =?utf-8?B?S09DV29WbUhSbE5TbXI3WitEU2UxUkYweWM4cDZQeXBVeG43bFZwK2pEOFhU?=
 =?utf-8?B?RTl1MEVQRFZIYlVMdW01d2V2VzdSeWJVWEU0SDJITkQ3OWdBbi9vMlVOYnZq?=
 =?utf-8?B?eEY2Z0NFb2hieGo2ODcwcmVlVEpvRTBRR1VRSGRiY0ZFNlZQRDYzMVFqbTQv?=
 =?utf-8?B?aXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fbc05af6-c6a0-4212-d442-08dbf060894d
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 22:22:41.5202
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9lT5yMQOFp51VF3SPiAKZXxBfJads/tNKooNi5kikr5OYRM91uz3uE9wgm67zBf1ew86e4Bi8OcZBYgaMC0bm+th/b8n7x5Zroxza/Sqr20=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8744
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:23:01 -0800 (PST)

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> Domain id is acquired differently depending on CPU. AMD tests use id
> from L3 cache, whereas CPUs from other vendors base the id on topology
> package id. In order to support L2 CAT test, this has to be
> generalized.
> 
> The driver side code seems to get the domain ids from cache ids so the
> approach used by the AMD branch seems to match the kernel-side code. It
> will also work with L2 domain IDs as long as the cache level is
> generalized.
> 
> Using the topology id was always fragile due to mismatch with the
> kernel-side way to acquire the domain id. It got incorrect domain id,
> e.g., when Cluster-on-Die (CoD) is enabled for CPU (but CoD is not well
> suited for resctrl in the first place so it has not been a big issue if
> tests don't work correctly with it).
> 
> Taking all the above into account, generalize acquiring the domain id
> by taking it from the cache id and do not hard-code the cache level.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette