Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <70bfe20f-952a-4c5b-ae79-4317badfeda2@infradead.org>
Date:   Tue, 28 Nov 2023 14:25:30 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/1] units: Add missing header
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Damian Muszynski <damian.muszynski@intel.com>,
        linux-kernel@vger.kernel.org
Cc:     Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Andrew Morton <akpm@linux-foundation.org>
References: <20231128174404.393393-1-andriy.shevchenko@linux.intel.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20231128174404.393393-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 11/28/23 09:44, Andy Shevchenko wrote:
> BITS_PER_BYTE is defined in bits.h.
> 
> Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  include/linux/units.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/units.h b/include/linux/units.h
> index ff1bd6b5f5b3..45110daaf8d3 100644
> --- a/include/linux/units.h
> +++ b/include/linux/units.h
> @@ -2,6 +2,7 @@
>  #ifndef _LINUX_UNITS_H
>  #define _LINUX_UNITS_H
>  
> +#include <linux/bits.h>
>  #include <linux/math.h>
>  
>  /* Metric prefixes in accordance with Système international (d'unités) */

-- 
~Randy