Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4191593rdh; Tue, 28 Nov 2023 14:43:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IGw/z/qNQNDNl1wNNq9swZXhIt2aoqRol5qy3QzahNM7XJntbBuQXMAph182ycGHKGutij0 X-Received: by 2002:a05:6820:513:b0:58d:6c99:fddb with SMTP id m19-20020a056820051300b0058d6c99fddbmr13578123ooj.8.1701211430580; Tue, 28 Nov 2023 14:43:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701211430; cv=none; d=google.com; s=arc-20160816; b=ZAgJHq8G6EjrpPB3Woi02HjgARvLnDlsiF1ybUOhFTJQTlVMlDQfWMe1ITLQDe8ZVO PPVsWBlqahSHKfhSu5+v2NT1GQai7RzE0QNmY3J54mhxCtqenCNtjiO3OxXxfHYECZUH 3UoSyEwC+AWsmxR9Z9e9CZ3y3PyY0k2ABFP8r59w3YzFoSL27r6GZrDk4y6ND57K5pDi DkEhI1kQTLm+V0o6VBL+e9Zjyasl3JNdyEza3UXsQwMYQ42t0+kjEpa44cIr52hKVD/w puZmGu389BtianSS3t3u/ZUg/kAehP4l8Lz68M3wTIpTx/MDrkyk2ZsUz/v3dEldI+Cx O/cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=d6v70Jfc8nqkrgav4bbcQA6HZL6P4J2VUNvwOzUy5eU=; fh=qZrehyY6pGoaVCnv+maK9kSU1l8t0TXDpKkLqbKti0g=; b=sW/sAy1MqMcXBqojvZm5845l9ieRHG80dfRMx/kb+zgnkDHRLewaqdSW9Ne5oyNsBy j/dclgOBSZOvIHI9HdjVC95FhnMe+xUZFU7EKpdY/14pqk0m7Orgp23J0Rr8q9zxDzvg MMu2P0Mcb1A0YJQFjRCZDGX7Mj5wnBSyiKux4RDVGbdCTWoYf+Cy6Ia+J0d+8QhmyIJF GOCKTAjw9/raIIJ9FQT6CuO13e5TsNur3xCBPF83azq3Cu7fnW6ya5E05iR3gLH7u7+V UrB9GAoJ7U/F/U+o153yed/qBwkKUzDgzfwqVnyZ6GWtfrOXQN9OsQdqfTKYvS9XQFYQ uPwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AeCv6Qvs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id f25-20020a635119000000b005c2124e421esi13114025pgb.156.2023.11.28.14.43.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 14:43:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AeCv6Qvs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 3222B804C1B6; Tue, 28 Nov 2023 14:43:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346770AbjK1WnO (ORCPT + 99 others); Tue, 28 Nov 2023 17:43:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346752AbjK1WnL (ORCPT ); Tue, 28 Nov 2023 17:43:11 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BE241BC0 for ; Tue, 28 Nov 2023 14:43:17 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50bc21821a1so892312e87.0 for ; Tue, 28 Nov 2023 14:43:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701211394; x=1701816194; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=d6v70Jfc8nqkrgav4bbcQA6HZL6P4J2VUNvwOzUy5eU=; b=AeCv6QvseDe8MeYt9NAQR2tw1vFckTWXLY4H5WkS8PtoX1Z4vffKEpMjzjEWzSrQqs qIxovs7AHcRKc8ZOKPrfULJlIu5BDssivccYWjL+cR9v0vLinI9m9qA8FLXAZZpcoQf7 h7k2bjAEZs+rLN+ewOTgZ9v7m8Y4ZjgRQP1L0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701211394; x=1701816194; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d6v70Jfc8nqkrgav4bbcQA6HZL6P4J2VUNvwOzUy5eU=; b=ezPpq4GYXcUbnFmLYi0+lvBlMlbeDI39YvIIrkZKc9nXrS1i9/I3kyGdcirNz84Xsk fcB7aw2ofVZ2I1a2hoC3rjw9jHQoXXY7w/6Zdhhb418NA9Xn5vjXpYe2Iyu0WsW6SRV/ T4Jy9sr0M5eAlKvBfJGiZxu9hJVSp9MxpVjmAr+FXlTlf4pxRtyTIL+C3nurSI/s46N0 SU2633VhNoQueq4LWPxiu9wYZI400mv7llisVUeAOcfV1BZAekUIdCt92L8XNkB68SRN Y0YNuj3Q40HC8OoKj2iB77luk+o8mmJAehGcXt0KF2AOq5IyICSePGVm7aR1NYKCVxl+ eezg== X-Gm-Message-State: AOJu0YzP4lak9usL53rCLbRj9HRpOO+NdkOzqUNgJWfFZfUTMci4XvEh KLuAIQTSBopSuzwPCDZFRiFRvxjvi+xoD6CKjH8l8FHh X-Received: by 2002:a19:7413:0:b0:50b:bc4d:9f36 with SMTP id v19-20020a197413000000b0050bbc4d9f36mr1710275lfe.29.1701211394420; Tue, 28 Nov 2023 14:43:14 -0800 (PST) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com. [209.85.128.47]) by smtp.gmail.com with ESMTPSA id u26-20020a50951a000000b0054bc9759e45sm316567eda.28.2023.11.28.14.43.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Nov 2023 14:43:13 -0800 (PST) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-40b35199f94so27395e9.0 for ; Tue, 28 Nov 2023 14:43:12 -0800 (PST) X-Received: by 2002:a05:600c:206:b0:40b:443d:9b78 with SMTP id 6-20020a05600c020600b0040b443d9b78mr400913wmi.0.1701211392581; Tue, 28 Nov 2023 14:43:12 -0800 (PST) MIME-Version: 1.0 References: <20231117215056.1883314-1-hsinyi@chromium.org> <20231117215056.1883314-4-hsinyi@chromium.org> In-Reply-To: <20231117215056.1883314-4-hsinyi@chromium.org> From: Doug Anderson Date: Tue, 28 Nov 2023 14:43:00 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 3/3] drm/panel-edp: Avoid adding multiple preferred modes To: Hsin-Yi Wang Cc: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 28 Nov 2023 14:43:30 -0800 (PST) Hi, On Fri, Nov 17, 2023 at 1:51=E2=80=AFPM Hsin-Yi Wang = wrote: > > If a non generic edp-panel is under aux-bus, the mode read from edid woul= d > still be selected as preferred and results in multiple preferred modes, > which is ambiguous. > > If both hard-coded mode and edid exists, only add mode from hard-coded. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Douglas Anderson > --- > v6->v7: no change > --- > drivers/gpu/drm/panel/panel-edp.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Pushed to drm-misc-next: fb3f43d50d9b drm/panel-edp: Avoid adding multiple preferred modes