Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4235399rdh; Tue, 28 Nov 2023 16:14:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IENE/atzaiEjMDt1Op1brJW7tHhl2YJii8xt888CxCmdsXd3hOP8213QhRTEvcCFgrdi83L X-Received: by 2002:a05:6a21:62f:b0:18b:b97:cdf4 with SMTP id ll47-20020a056a21062f00b0018b0b97cdf4mr14346745pzb.3.1701216879139; Tue, 28 Nov 2023 16:14:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701216879; cv=none; d=google.com; s=arc-20160816; b=TIsSN/PHAXbaqfYtDh85Z80bQ0SRGZM1aLh8q5iLxOzcwGNxj1VnGmsd0Dp35M79Vs 78nUuszFekef3oeBP8Lx9vDVJO2TyCjArYBkhuCiu7KjkRHW8OP9tq/NU0cE2MXUqaRo msSY+1jjctoWn/cRFI3DE3lDnUSc6wtS42IySo8ko+cLOqtcJANTzSu4hLbMa/GJvHG8 uLOFLnfBbFvYT9TuHOnG5LO4zCN0zvArk3b7ICoDLKsmwvJCTd5KP4dSMgi/w0cvromK CXmQe5+zU1T0raY96K/Az3hXnBvkKnZcx1aA6m+vj3etX8l2M9l22FHTA3JQaFXEvSdw Vh8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bcr7YI1zKPWjLEfoDfiTAQ33I/N4mEzfuEXEbPDzSTM=; fh=tlzlIrDnIzwwwEcPaCEJBfEkpCdrQJZFQ3x6kuHiUq8=; b=CeT2W3RtO/qGewTa2z5O+dm6qJdxo/0LJqNrtDMg9z5W2KK7M3fKYH6IocweUJ+m4Q SitG/hSYpZDCSOjGJdMv3PsoSS25PViIFQZ2lwU+sx4WEQKeZr3iUuqfUz9H7zy8PhmW Rc2XDMWM+/z/XFInB8nG8GpT5T9MqpDkwzLSEAiTCeNnYHvjDAuttL9etOsax9Q7BNnv 3WCE5+yXwCvMyUt9PV51Fo3crmkZD4LXgPfvUZxxkrwO9ILqNePkfLGTiJuHmjpf6x6v WleM/j0Ip7eFcvoJOKhaBi4DCTzwQ8jHOiUZ61vD+6d5jVrbhnfJzTTuje2t0tq/YcwC AzcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=R1AHvE14; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id a20-20020a63e854000000b005b18b5da51asi13169109pgk.346.2023.11.28.16.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 16:14:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=R1AHvE14; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 25086803A5AB; Tue, 28 Nov 2023 16:14:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345005AbjK2AJu (ORCPT + 99 others); Tue, 28 Nov 2023 19:09:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229838AbjK2AJt (ORCPT ); Tue, 28 Nov 2023 19:09:49 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2218B198D for ; Tue, 28 Nov 2023 16:09:56 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D48EFC433C7; Wed, 29 Nov 2023 00:09:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701216595; bh=m73Trz87dPQgImAcfxCzaxmbSK2YY2Ek+G0J2e+T4XA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R1AHvE14L3YQOefTK8+GgjBEgn0lUAjnW9vDqnzKHN2p72Be4Axcvp44XbEt5fLHv sTmBVE9Ov+n+zAuTF0kLf2KL85lJr8O8erbCDusuuhB/8EoFs0x3bwzIs6sFJlK5XK wAWQw+OMrjqAHWxK6B83Opmy5Bx+l14ZfpUyvvNqN/79BbOIM9MtlzWdz6NygmUhsr R2xbrLTyEa78hOFoe/UM4oMI4ZX+7uzL3qQNGChBYTQbbNnBS0xiFnVVeyhfCe58mm jzfgwwGTCb6I/7MMt+gpBCGjeEj9bBxCUWwFAqxo57SAqmTsIWpdBgvI8ECJ/OxbmV VnzWrtzlZHfVg== Date: Tue, 28 Nov 2023 17:09:52 -0700 From: Keith Busch To: "hardaway.tseng@sk.com" Cc: Jim Lin =?utf-8?B?5p6X5b+X6J6N?= , "Jim.Lin" , "axboe@kernel.dk" , "hch@lst.de" , "sagi@grimberg.me" , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" , CJ Chen =?utf-8?B?6Zmz576k5YKR?= , David Yeh =?utf-8?B?6JGJ5a+w6J6N?= , "sangan.han@sk.com" , "ives.lu@sk.com" Subject: Re: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901 Message-ID: References: <20231128025737.53026-1-jim.lin@siliconmotion.com> <71aae1b4cb0441d0940a5e536f4ffce0@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71aae1b4cb0441d0940a5e536f4ffce0@sk.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 28 Nov 2023 16:14:35 -0800 (PST) On Tue, Nov 28, 2023 at 11:51:42PM +0000, hardaway.tseng@sk.com wrote: > Hi Keith, Jim and team, > > Thanks for efforts! > > This is Hardaway from SK hynix, this software change has been tested and verified by ODM Compal, the testing result is pass, therefore, we would like to apply this update. Great, thanks for confirming. I've got this queued up internally, but want to check if Christoph's question could lead to a better outcome for everyone. For reference, asked here: https://lists.infradead.org/pipermail/linux-nvme/2023-November/043298.html If you were already testing close to upstream, 6.2 or newer, then this patch is already the best option.