Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Tue, 28 Nov 2023 18:09:57 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Damian Muszynski <damian.muszynski@intel.com>,
        linux-kernel@vger.kernel.org,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH v1 1/1] units: Add missing header
Message-Id: <20231128180957.ac5caa884abb2b5f00ca47c4@linux-foundation.org>
In-Reply-To: <20231128174404.393393-1-andriy.shevchenko@linux.intel.com>
References: <20231128174404.393393-1-andriy.shevchenko@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 28 Nov 2023 19:44:03 +0200 Andy Shevchenko <andriy.shevchenko@linux=
.intel.com> wrote:

> BITS_PER_BYTE is defined in bits.h.
>=20
> Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")

This is post-6.6, so the fix should go into this -rc whatever happens, but.=
..

It would be rather nice to know the effects of this change please.  Did
some build break?

> --- a/include/linux/units.h
> +++ b/include/linux/units.h
> @@ -2,6 +2,7 @@
>  #ifndef _LINUX_UNITS_H
>  #define _LINUX_UNITS_H
> =20
> +#include <linux/bits.h>
>  #include <linux/math.h>
> =20
>  /* Metric prefixes in accordance with Syst=E8me international (d'unit=E9=
s) */
> --=20
> 2.43.0.rc1.1.gbec44491f096