Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <cc617644-029e-4671-8231-a2b01627a08f@starfivetech.com>
Date:   Wed, 29 Nov 2023 10:10:50 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] media: staging: starfive: camss: fix off by one in
 isp_enum_mbus_code()
To:     Dan Carpenter <dan.carpenter@linaro.org>,
        Jack Zhu <jack.zhu@starfivetech.com>
CC:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        <linux-media@vger.kernel.org>, <linux-staging@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
References: <7d222638-2d19-466d-8dd4-9e1ceb1d46f3@moroto.mountain>
Content-Language: en-US
From:   Changhuang Liang <changhuang.liang@starfivetech.com>
In-Reply-To: <7d222638-2d19-466d-8dd4-9e1ceb1d46f3@moroto.mountain>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/11/28 22:40, Dan Carpenter wrote:
> These > comparisons should be >=.  The formats->fmts[] array is either
> a pointer to isp_formats_sink[] or isp_formats_source[] respectively.
> 
> Fixes: e57854628f58 ("media: staging: media: starfive: camss: Add ISP driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>

> ---
>  drivers/staging/media/starfive/camss/stf-isp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/starfive/camss/stf-isp.c b/drivers/staging/media/starfive/camss/stf-isp.c
> index 893dbd8cddc8..98d61d71c31b 100644
> --- a/drivers/staging/media/starfive/camss/stf-isp.c
> +++ b/drivers/staging/media/starfive/camss/stf-isp.c
> @@ -120,7 +120,7 @@ static int isp_enum_mbus_code(struct v4l2_subdev *sd,
>  	const struct stf_isp_format_table *formats;
>  
>  	if (code->pad == STF_ISP_PAD_SINK) {
> -		if (code->index > ARRAY_SIZE(isp_formats_sink))
> +		if (code->index >= ARRAY_SIZE(isp_formats_sink))
>  			return -EINVAL;
>  
>  		formats = &isp_dev->formats[SINK_FORMATS_INDEX];
> @@ -128,7 +128,7 @@ static int isp_enum_mbus_code(struct v4l2_subdev *sd,
>  	} else {
>  		struct v4l2_mbus_framefmt *sink_fmt;
>  
> -		if (code->index > ARRAY_SIZE(isp_formats_source))
> +		if (code->index >= ARRAY_SIZE(isp_formats_source))
>  			return -EINVAL;
>  
>  		sink_fmt = v4l2_subdev_state_get_format(state,