Date: Thu, 29 Nov 2007 17:36:05 -0800
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: "K. Prasad" <prasad@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, dipankar@in.ibm.com, ego@in.ibm.com,
       mathieu.desnoyers@polymtl.ca, mingo@elte.hu
Subject: Re: [PATCH 0/2] Markers Implementation for RCU Tracing
Message-ID: <20071130013605.GK9059@linux.vnet.ibm.com>
Reply-To: paulmck@linux.vnet.ibm.com
References: <20071129184128.GA26466@in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071129184128.GA26466@in.ibm.com>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1194
Lines: 29

On Fri, Nov 30, 2007 at 12:11:28AM +0530, K. Prasad wrote:
> Hi,
> 	Please review the ensuing set of patches which convert the
> existing RCU tracing mechanism for Preempt RCU and RCU Boost into
> markers.
> 
> These patches are based upon the 2.6.24-rc2-rt1 kernel tree.
> 
> Along with marker transition, the RCU Tracing infrastructure has also
> been modularised to be built as a kernel module, thereby enabling
> runtime changes to the RCU Tracing infrastructure.
> 
> Patch [1/2] - Patch that converts the Preempt RCU tracing in
> rcupreempt.c into markers.
> 
> Patch [1/2] - Patch that converts the Preempt RCU Boost tracing in
> rcupreempt-boost.c into markers.

Looks good to me, though I do not pretend to understand the markers
implementation.  I presume that the markers implementation forces the
varargs usage -- though the markers do seem quite a bit nicer in allowing
the formatting to be specified more naturally.

							Thanx, Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/