Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
To:     John Garry <john.g.garry@oracle.com>
Cc:     Christoph Hellwig <hch@lst.de>, axboe@kernel.dk, kbusch@kernel.org,
        sagi@grimberg.me, jejb@linux.ibm.com, martin.petersen@oracle.com,
        djwong@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org,
        chandan.babu@oracle.com, dchinner@redhat.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-api@vger.kernel.org
Subject: Re: [PATCH 17/21] fs: xfs: iomap atomic write support
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1wmu1s5iw.fsf@ca-mkp.ca.oracle.com>
References: <20230929102726.2985188-1-john.g.garry@oracle.com>
        <20230929102726.2985188-18-john.g.garry@oracle.com>
        <20231109152615.GB1521@lst.de>
        <a50a16ca-d4b9-a4d8-4230-833d82752bd2@oracle.com>
        <c78bcca7-8f09-41c7-adf0-03b42cde70d6@oracle.com>
        <20231128135619.GA12202@lst.de>
        <e4fb6875-e552-45aa-b193-58f15d9a786c@oracle.com>
Date:   Tue, 28 Nov 2023 21:45:59 -0500
In-Reply-To: <e4fb6875-e552-45aa-b193-58f15d9a786c@oracle.com> (John Garry's
        message of "Tue, 28 Nov 2023 17:42:10 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?V1MtxbWBqF2dHWfJG6krDDhmTshqHRwUt1GK7h1D98E4RtVc0ocCgdmLPdFQ?=
 =?us-ascii?Q?cb5gJ4BLeei9nb8uPjjsm4w27cAaO5z8FvzeFDMazxZqFds/lNKcbewERbXO?=
 =?us-ascii?Q?l5l0I8xXNj3LtC44ciNDXUIGKz2WuR+7lG9u1H7XB5KwDFG14DbT789JGuDJ?=
 =?us-ascii?Q?2BG42sycxwIUdVmPk/jPrz1z1HoYon2kHz0HQAcGj966DDaBiGo9C84RIImN?=
 =?us-ascii?Q?eMy4yYoXNNfc6T9HNnuJ9HMreynUzRGYmBcPe8FNUxB773yPtI0O1erzpW3H?=
 =?us-ascii?Q?eq6Q1hcuZKThMrTWVwNHTm1z87vxYu2ud86M6mUie5BrRcrSWPEU63EcLvJs?=
 =?us-ascii?Q?Ia6uvzKufjVSOyxxMJQJNPitCQtkueFZWUgSRQ+C2EuVsz5z5Pb8UPVVGbw/?=
 =?us-ascii?Q?rbxsY5mqivG6Y9b5HCf3VTnzduFksG/zDPp8WeGi4W2X7acZCj7VTXMVScko?=
 =?us-ascii?Q?7/N5+pIitD4QdPzkHD1W+pQ2lkeWtyxKkstl2QnbpaaHOYEbbp8CCkFDj6DC?=
 =?us-ascii?Q?K3siH6mv/rfLZ9U/tKdd1ITGGq7yrc6iQW+uohiEAskI4VLtGvXIcGrKZ8bt?=
 =?us-ascii?Q?qUU1ctouAqrM/ZqMXeuUsGYUUPyKfovkaL2wPz1hmK8o820YiZp3JMVb2Nd2?=
 =?us-ascii?Q?b8GEu2tqT3hcmDP5k5W7u3IAwbBDshi+Gz4arlWfuRTXTzMg2EAaUhhhst+T?=
 =?us-ascii?Q?M1ICzTHzxPY9hNjNgJ/TFBeXEA6vKe6lHx+KbIoDML2IkMY+dsKa+q52/x4/?=
 =?us-ascii?Q?pO8iWSUf+d1j5A1ebiBGOb7tI8CD6+5q8sm0izwuM2wE94Mf1ynUFfRMpYYo?=
 =?us-ascii?Q?dg64sOWjOuQISgxtV+ctgi7Q46MHYqFLM8Q8oB4N710pAjq3PYZsbP1g9u2B?=
 =?us-ascii?Q?npwyY+MwSvktgerL/JJZpF5OjpnPqduOD8idgvoQgDaeLu93nVByCgyYlLw/?=
 =?us-ascii?Q?Y8zQSf0SWW68Y2ehiJ3wAGtwfDRmlJmOLeb/o8Izith1TQ+/cccMuoDpuZB9?=
 =?us-ascii?Q?VirYsviQJlkbMWPDj4lElMgYPvTB6LGFmMoqxlWBfGR3E7tMA+zW7u5xcnTv?=
 =?us-ascii?Q?Yfb3RCP50HGJ1eVAdBCH+HsIKjpG97zVb5gv/UXZgkal2wVWyE9JzpKOsQyi?=
 =?us-ascii?Q?zHIdjGfMKETUfv6FEjQbbFsYcvWME2EuovLucp2VlsJXQJeFZIoTBf3kTVf0?=
 =?us-ascii?Q?1tIARPQFVQYNfUywp+tc1lXide1lrZxC9STX9gGV5sszQefsFv5KtNAl57vw?=
 =?us-ascii?Q?7jHmyzEy2lSlOqDZ7pI4uHOveH+go17PGdc7PrPd00uNZAI/Pg3KYygEg6Xz?=
 =?us-ascii?Q?+q9qSyWuz7oliEUtnWKOQx/2fnGMexiAOq5aARj5B1K/EmZVLZqUjmgAFcpc?=
 =?us-ascii?Q?5kWybFZ95LT/sy4OEFyi/DJpcLaQTEO+bVAJ4hRp3/3Y84EAkq5JqhetxkiA?=
 =?us-ascii?Q?WBTGee4MIk8XrAnsPsBS2ibILJZM/wt7yBmqjXYvEDThlOBxEyfGFWhCP3Bm?=
 =?us-ascii?Q?gVaUoYZyfngsh8G1Pac1OjfJ0AXk2EeUwconVdpSGdbFF5fpPNMhfsc+EO/U?=
 =?us-ascii?Q?i3VHuhexwH6kcL/jlR/gpgTwbUf31QeLZvtgzq9XdZA5Nge/DrJXFiyD/X4O?=
 =?us-ascii?Q?YA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?xye/n5Cf5frT5vu/ieXt3LCDqixxNsoMraeepNtHCP4bPMyfv8KTCeRdFWaL?=
 =?us-ascii?Q?i5eL1RZRnqY3yBQahnXMWPrk1AOWqrGGVhv24vhqcaan2e9UP8pJqXnXBhWI?=
 =?us-ascii?Q?QDxQ6UcRq5K6FKasRxwJUZPeFZB07vdf31jUKL4+/+xESGQM72Ei03yumU6u?=
 =?us-ascii?Q?WuU2bokE6Ug16FZK+izMrHNFbOb104vrmQ8eUYoZi60QKwfilcZuPQ8pb3HZ?=
 =?us-ascii?Q?g5Tnm1nsilX5Zkrd83LoAAAOFfrpL31aejD4Ga4zTxYYJe0sGpKN5IYXFDgE?=
 =?us-ascii?Q?WimAf6e5Hm3bKBQCx5LD/B45apULAuz3N/KKsPKjBEqObyKgFolno9pyrID2?=
 =?us-ascii?Q?6HkQpq8QoNzMXYFvrCNanGCh/kpFmvTsy4vP4Vm0WEHUQNJFrMB8sgGQV7q0?=
 =?us-ascii?Q?rHFozj/Czr3ATp6vR5AsWkP/U3Ut2qMsaOTphzb+upkOguA1Q7on6AdMkedH?=
 =?us-ascii?Q?6oO9lotLP+1SamwwqSbgx9pSvZB8uQiwtjbLfh3BNoXPgRQyCygVaSo2zNos?=
 =?us-ascii?Q?h4oup41SuwF+jRlD2w7hQI4Lr5Iti3jS/REfQYGPc0ytb3IQTCdgmKYcj8vb?=
 =?us-ascii?Q?MunhkkGx571/PTmFmyGwPbj9eVc9KjQL3RXu+bTYdImSN4ewt8FiQ68z2PM4?=
 =?us-ascii?Q?DC8MINIZ86kWIWJMzfFlf/HzaBoVnDXnwKGVipxCBa+qwmnKC6LHZteZXmLx?=
 =?us-ascii?Q?hq8ataNRSJKYjY/pHF5VoiM1Sc3gZ1h7geWR+EXAe6LrXIMr/qbR1itKEcr2?=
 =?us-ascii?Q?RbWTYhLjH0+cpjGQscXONyvFmSpxz6voG43gIkcmaHWabnZIAin5hWFfEfnu?=
 =?us-ascii?Q?yoKafqrow2UXWMruvtnsxJI4lgGVyTNsJJPRRQDmL1rim/ejO/iR6PkZztSo?=
 =?us-ascii?Q?0BcgaAy3N3CSz224UooI66ws7e6zqX4ZE092C4BbRc2OuwzpmjXzKI1EVTUH?=
 =?us-ascii?Q?3h8NIVd3AuDBt88B0DI+WkCzo67EzRB3AzXbFHF2j0mGR53hpijw9e1ch6wz?=
 =?us-ascii?Q?ra8vELTdsaeQCdrWHRd54nREXDfbiW5EM3ZiODefO19QQOWwNtMgNYZLz6m/?=
 =?us-ascii?Q?yv97oaJgT5bb0mmBtDLH6qRlPnV35g=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b707e293-a7af-4534-20b5-08dbf0855415
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 02:46:03.6038
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5BQd5dI5UqeRkgEAFGP3arHiRCLmpnmuSJogZX+ZI9cjv7Lxn/7mYeTQL+IwIy2uLbIuXBy2P5iVBcMkso/6yXoQ6w79ODLiUEZknyJo1Zg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4456
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-28_27,2023-11-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 phishscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2311290019
X-Proofpoint-ORIG-GUID: Mazf-Bsb0Ddar-grvBr76tftpfPdW5RC
X-Proofpoint-GUID: Mazf-Bsb0Ddar-grvBr76tftpfPdW5RC
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 28 Nov 2023 18:46:48 -0800 (PST)


> b. other FSes which do not have CoW support. ext4 is already being
> used for "atomic writes" in the field

We also need raw block device access to work within the constraints
required by the hardware.

>> probably want to do it for optimal performance, but requiring it
>> feeels rather limited.

The application developers we are working with generally prefer an error
when things are not aligned properly. Predictable performance is key.
Removing the performance variability of doing double writes is the
reason for supporting atomics in the first place.

I think there is value in providing a more generic (file-centric) atomic
user API. And I think the I/O stack plumbing we provide would be useful
in supporting such an endeavor. But I am not convinced that atomic
operations in general should be limited to the couple of filesystems
that can do CoW.

-- 
Martin K. Petersen	Oracle Linux Engineering