Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <328ad7a1-7c54-4028-ae79-eb25c8c7399b@kylinos.cn>
Date:   Wed, 29 Nov 2023 11:31:47 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ksmbd: initialize ar to NULL
Content-Language: en-US
To:     linkinjeon@kernel.org, sfrench@samba.org
Cc:     senozhatsky@chromium.org, tom@talpey.com,
        linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231120023950.667246-1-zhouzongmin@kylinos.cn>
From:   Zongmin Zhou <zhouzongmin@kylinos.cn>
In-Reply-To: <20231120023950.667246-1-zhouzongmin@kylinos.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Friendly ping. I think this patch was forgotten.

Best regards!

On 2023/11/20 10:39, Zongmin Zhou wrote:
> Initialize ar to NULL to avoid the case of aux_size will be false,
> and kfree(ar) without ar been initialized will be unsafe.
> But kfree(NULL) is safe.
>
> Signed-off-by: Zongmin Zhou<zhouzongmin@kylinos.cn>
> Acked-by: Namjae Jeon <linkinjeon@kernel.org>
> ---
>   fs/smb/server/ksmbd_work.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/smb/server/ksmbd_work.c b/fs/smb/server/ksmbd_work.c
> index 44bce4c56daf..2510b9f3c8c1 100644
> --- a/fs/smb/server/ksmbd_work.c
> +++ b/fs/smb/server/ksmbd_work.c
> @@ -106,7 +106,7 @@ static inline void __ksmbd_iov_pin(struct ksmbd_work *work, void *ib,
>   static int __ksmbd_iov_pin_rsp(struct ksmbd_work *work, void *ib, int len,
>   			       void *aux_buf, unsigned int aux_size)
>   {
> -	struct aux_read *ar;
> +	struct aux_read *ar = NULL;
>   	int need_iov_cnt = 1;
>   
>   	if (aux_size) {