Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4335773rdh; Tue, 28 Nov 2023 20:19:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IH1sU4G5LGeXMtO0Kmhz1fsNE/02sH/zWduqTTp4PN51B6Es9Bh+Z/QzawYqUcJUUv/+UVz X-Received: by 2002:a05:6a21:2711:b0:187:8eca:8dc6 with SMTP id rm17-20020a056a21271100b001878eca8dc6mr16609939pzb.34.1701231584932; Tue, 28 Nov 2023 20:19:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701231584; cv=none; d=google.com; s=arc-20160816; b=pDcFuSbKED3ypuHhGBzDWJkbcb3zWOmyrOES/vawPqsPmO7szj9Bc9xj8MtXtZhulM fOLj131xNeACk0Yvf7YARELrN4YOFrpgZzPnarlOykJWMApeEqoWy65LCtfsb3LJZEm3 989BJVDTS6u+Z/c3SwpjoK+jDrbDktL8U60hciUu1OwtG9QVHdt6xKjclKlrC/lXgAxQ BeAoncc+J7Pmc0o1StOcTssByIS/kcY9+UhCqD/SSqNXnwcPduqPFNtWGGqWtBGeADsr 8mn68ILogv8po4rDOWTMJSKyAimbinC2nWWmxAKlVNMtng0yu5Qk627EGWaQehy8lA01 6LVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8sF8sEE2ZTc9ObiMO1OzkZ6Z6YbCekFkAXIm79+6W8w=; fh=80t0Z7QmPChVyk+vYj1cZ6oTOvuT5XiAKQAzg/NXXQk=; b=BJxd7V8BhuH6/1by3XKtJiffdUCPA+1iycAJF8a5eDLzpeaQ+2yX9yHKfyLJ/xGrpj 3XyIJi8gH/ozZBCJk1a/s4qfpNB/ySrFJxpN4061OiO3RCvTx1nCxWOdLr1zoLv1fx8Z lWYMLnt+0ddy1YL8ZTIIHNs+VGgIFDDqEnFmfZvm+d1EIWNdBPElzIwKd45dWKCeDlP3 ab/Dc76WGlBQnJ856lZhB43JVYTd3XqKBad1M/vsbNrFn1xylB+KOGnadzcWzi4q5s29 L8fQaofBS1N7x2mmrTmDzJ9vqP6/bL3pqI/KsX0ORWNtDZTu2DKrzmGWT00R2waY9e8T pK2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=B9HAq6lN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id d2-20020a17090ad98200b002839db82641si496199pjv.85.2023.11.28.20.19.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 20:19:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=B9HAq6lN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 4B41480B122C; Tue, 28 Nov 2023 20:19:42 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376822AbjK2ET3 (ORCPT + 99 others); Tue, 28 Nov 2023 23:19:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231288AbjK2ET1 (ORCPT ); Tue, 28 Nov 2023 23:19:27 -0500 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B856E1AE for ; Tue, 28 Nov 2023 20:19:31 -0800 (PST) Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-5c19a328797so4512275a12.3 for ; Tue, 28 Nov 2023 20:19:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701231571; x=1701836371; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8sF8sEE2ZTc9ObiMO1OzkZ6Z6YbCekFkAXIm79+6W8w=; b=B9HAq6lN0gqBdKxxHzl+TumZYBizeRB4Y+R95Z4D9KVI0E93DusuRsTkn6MqqXJtMS vQHlMKtoJ6vMvgoAvxPlrJOwDbETcHzxkqmLpPLG7YMc4JUBjxylAjr4/440smXLwcK1 90fdEhqowCCAqWxaikGJMxYrhyxEOk9gF6tL4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701231571; x=1701836371; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8sF8sEE2ZTc9ObiMO1OzkZ6Z6YbCekFkAXIm79+6W8w=; b=NCC93SZUiFdeZEY6B+cXd14vQJ+VjHrA98E+lXUOB1JKPXf66DonUDg0/Q7p9NUM6m IyHpom4PxGkRZn4WzLzbPE5dk2T3gNItNKIptnzseHW3fIchaqvUEjMyM2OC0NJf7wlN eszdvhYRIPyJr1x2mqWzg76lYaZ6puZUtoPBE3c5h9wTzt8+EWtQ8ePcoe2fxbEC6OG1 VKJby9Qn8GyMER40+BTSLYzDn0F1Wd3YPG9LnneH94YV0ngkapN8YAbpM09ax9744rAa k2N66eAgh5eO3/CCA0zSckxYvICsg9JV21pyS4nkH7nP2zsTEhcy4HywKDlZ3l+vtZEe BGtQ== X-Gm-Message-State: AOJu0YyaUsqZOOonaykgVOkXYKhMcQE6jGzLOWXYrrtzcWeVwrdazqP6 BitUnaWw1xhlmZL/ZW4SvjkMLw== X-Received: by 2002:a05:6a21:7886:b0:17f:d42e:202c with SMTP id bf6-20020a056a21788600b0017fd42e202cmr19782814pzc.49.1701231571187; Tue, 28 Nov 2023 20:19:31 -0800 (PST) Received: from google.com (KD124209171220.ppp-bb.dion.ne.jp. [124.209.171.220]) by smtp.gmail.com with ESMTPSA id q2-20020a170902edc200b001cfb573674fsm7337050plk.30.2023.11.28.20.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 20:19:30 -0800 (PST) Date: Wed, 29 Nov 2023 13:19:26 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH] zram: Use kmap_local_page() Message-ID: <20231129041926.GC6525@google.com> References: <20231128083845.848008-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 28 Nov 2023 20:19:42 -0800 (PST) On (23/11/28 16:01), Minchan Kim wrote: > On Tue, Nov 28, 2023 at 05:22:07PM +0900, Sergey Senozhatsky wrote: > > Use kmap_local_page() instead of kmap_atomic() which has been > > deprecated. > > > > Signed-off-by: Sergey Senozhatsky > Acked-by: Minchan Kim Thanks. > I didn't know that the kmap_atomic was deprecated. Me neither, figured it out recently (via checkpatch warning). https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com/ We need to take a look at zsmalloc, the conversion can be a little more difficult than zram's.