Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
From:   Shinas Rasheed <srasheed@marvell.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Haseeb Gani <hgani@marvell.com>,
        Vimlesh Kumar <vimleshk@marvell.com>,
        "egallen@redhat.com" <egallen@redhat.com>,
        "mschmidt@redhat.com" <mschmidt@redhat.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "horms@kernel.org" <horms@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "wizhao@redhat.com" <wizhao@redhat.com>,
        "konguyen@redhat.com" <konguyen@redhat.com>,
        Veerasenareddy Burru <vburru@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        Eric Dumazet <edumazet@google.com>
Subject: RE: [EXT] Re: [PATCH net-next v1 1/2] octeon_ep: implement device
 unload control net API
Thread-Topic: [EXT] Re: [PATCH net-next v1 1/2] octeon_ep: implement device
 unload control net API
Thread-Index: AQHaIU3Pn4kUrPqSikaGSVeLinDUmrCPBp8AgAAaVCCAAMvsAIAALJUwgAAu9QCAAHEYAA==
Date:   Wed, 29 Nov 2023 04:42:15 +0000
Message-ID: <PH0PR18MB4734BE1829B78CB772EDD299C783A@PH0PR18MB4734.namprd18.prod.outlook.com>
References: <20231127162135.2529363-1-srasheed@marvell.com>
        <20231127162135.2529363-2-srasheed@marvell.com>
        <20231127184306.68c2d517@kernel.org>
        <PH0PR18MB4734281BD887FD9AFD64B2DEC7BCA@PH0PR18MB4734.namprd18.prod.outlook.com>
        <20231128082712.223c4590@kernel.org>
        <PH0PR18MB4734B57CC289557366F68A47C7BCA@PH0PR18MB4734.namprd18.prod.outlook.com>
 <20231128135450.4542dfe0@kernel.org>
In-Reply-To: <20231128135450.4542dfe0@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BsFc1B7ByijHhSTfrwf0z4UfP2jHzeEALD/VJ0PfhiMcMDp3n2UgjEeSkx8J?=
 =?us-ascii?Q?8Ph0oGI2XLH/yAvZw8l/THtnuMJtTUKKJ3AVntOcr9Dhv9xzmB4v7dLMKSWl?=
 =?us-ascii?Q?TWRsatAVyLFixAojhokrlmENbxAbbMCGWGF6ioGHTzlqpmwAR2mUufVOu85m?=
 =?us-ascii?Q?qITjiLim2yuyAvsnFX3f53VmnysLM8Z7DnB4k/ApUofXA7RDP+KIL2jm0jd8?=
 =?us-ascii?Q?hD10vAqH4wn7XJXb8RdUWzVR2rLou6tMZ0+tQSfBwR4rGnQDcE3waTCCqg+g?=
 =?us-ascii?Q?dYwSNNdg0S4QKBJ/Pe4ed7gKzlW/pV2zpJnoDVIXzCQuTB0zg3Q6PM3KX2G3?=
 =?us-ascii?Q?bzx2BINk6hHuQLfyLCRxq2GTMFH8xjYHJt6bumU+7gKByiAcIsZfqZPJWTew?=
 =?us-ascii?Q?iPHWsh3s4JaL5yUK5m7mjU60MiPbEtkpMAXSDoturiByImkBgolXA4ZoWoeV?=
 =?us-ascii?Q?iFuBqxXZ1LZEz/r3CujbbTRlBWIfWm0fOIStBY2mrdQlWF+AT1VQGTQO2Wzo?=
 =?us-ascii?Q?cstSKcTRK3qAtaChT4UfZjYga9uYZHJvmIkZJ3IOB3bqGqlRp3SPveC8CXAq?=
 =?us-ascii?Q?tmG6c9Yi3AowtDV7ngEd4smVEchrKSBpANnzgPoshAiiRIFVbchneUkrbFlX?=
 =?us-ascii?Q?IcmczYvv/jz+iYLsXLXPRNzizMwyS497dQmmfIEyvkTyuOMP91xRLw6pnXxA?=
 =?us-ascii?Q?kHdIqF+XdpS5PMLMFr2Y+VVTn8lS2h5s49zSOGtZinycLxT1oGjldM3hPpv8?=
 =?us-ascii?Q?akVcu8RREbNzCXLGZ17aoXKuvh77SQOu6/XcZcBmOdEJokeRVv8d96TIpSoz?=
 =?us-ascii?Q?Gtxs2GeXv98vwJLkpl53H03n1RBOq7drjm8QPemO3qU/107P5QVTFzzheAM1?=
 =?us-ascii?Q?ZRI9ad8jNZjfw53qzYsiBISFOKxDvGaJFZMm6v89XLQBeql9Wb90PCwGbp7E?=
 =?us-ascii?Q?ZnWEx/fLvVEDHUn4N4uhJU6xPQy3gOTkFlpLEaBjgyanwTwEVv3mzy7SRpQR?=
 =?us-ascii?Q?4KGkYARs8BkCpOtP4uval34tVWStbxzUPB9ZuSZjnUAasUEWkHptU5AxjLBy?=
 =?us-ascii?Q?6bedm+juhg+WBCYbKi5A8na5hJUxy6jcDqW+roEtaD3+1fvX2gRYdrAemulz?=
 =?us-ascii?Q?sNnp9JRy7dqMjXgXN7ds94Y4BlAGWCrm3qd5F9R8Hy7CZnS4/vmdHatmzJED?=
 =?us-ascii?Q?3Nr1Zvm87RrCygojeTZm3/kJrDlTKMEutQ6TQFtqQLLSPPG3Ymux0nPpDH+k?=
 =?us-ascii?Q?oeyybEReii2pbx+u54GatA3Jyht/xnuonzehByT2VrTzcrfd9AAxT04CIDYf?=
 =?us-ascii?Q?19esaUQnT79faSHi3BrE4xOqHIYPxHCGFGNeTak+3+7tSqsmq6kSxgcnvjhH?=
 =?us-ascii?Q?EpMyQaAJ2MfUdT4Xlu5uRcMMnOzLtLEhcBKzx+uXl6hjnbDFToX34HuEfDj6?=
 =?us-ascii?Q?+W1+nS6eeTzJ3gRFO1Yf+lVELQcKVVzu6zQAxXHJ7CDphZUG0sTes3P7qgi2?=
 =?us-ascii?Q?ZpudP6Dny8h3BME8qMZWTwtCq6r115Z2uobVAo9yW6UzpaiAVsJ/5wlEU+mJ?=
 =?us-ascii?Q?FilU9PZADTI3IrHBQopJpKg1tzG2tE2rD+XovgZu?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4734.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdf207eb-61d7-47ff-83ec-08dbf0958fa0
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2023 04:42:15.3214
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +Qx+VReU+uUvmPCVzR50ZdTa2k1Vpaq3/1/1FcJfnWIFEpa5yo5+i8Z0KXZdIWzvArzDCcf92kt9uXEdK7Dd5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB5016
X-Proofpoint-GUID: PnTykPuK7ukbALcW535W6Oc4gadI6iiD
X-Proofpoint-ORIG-GUID: PnTykPuK7ukbALcW535W6Oc4gadI6iiD
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-29_01,2023-11-27_01,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 28 Nov 2023 20:42:48 -0800 (PST)


> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Wednesday, November 29, 2023 3:25 AM
> To: Shinas Rasheed <srasheed@marvell.com>
> >+	dev_info(&oct->pdev->dev, "Sending dev_unload msg to fw\n");
>=20
> Is it really necessary to print this at info level for each remove?
> Remove is a normal part of operation and we shouldn't spam logs
> unless we have a good reason..

I suppose it's not a need other than maybe for debug purposes. I'll use dev=
_dbg and submit a second version