Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 29 Nov 2023 13:39:23 +0800
From:   Yue Hu <zbestahu@gmail.com>
To:     Gao Xiang <hsiangkao@linux.alibaba.com>
Cc:     linux-erofs@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org>,
        huyue2@coolpad.com
Subject: Re: [PATCH v2] erofs: fix memory leak on short-lived bounced pages
Message-ID: <20231129133923.00005957.zbestahu@gmail.com>
In-Reply-To: <20231128180431.4116991-1-hsiangkao@linux.alibaba.com>
References: <20231128175810.4105671-1-hsiangkao@linux.alibaba.com>
        <20231128180431.4116991-1-hsiangkao@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 29 Nov 2023 02:04:31 +0800
Gao Xiang <hsiangkao@linux.alibaba.com> wrote:

> Both MicroLZMA and DEFLATE algorithms can use short-lived pages on
> demand for overlap inplace I/O decompression.
> 
> However, those short-lived pages are actually added to
> `be->compressed_pages`.  Thus, it should be checked instead of
> `pcl->compressed_bvecs`.
> 
> The LZ4 algorithm doesn't work like this, so it won't be impacted.
> 
> Fixes: 67139e36d970 ("erofs: introduce `z_erofs_parse_in_bvecs'")
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Reviewed-by: Yue Hu <huyue2@coolpad.com>