Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <5e000502-d400-420c-a9f8-40e202a95271@infradead.org>
Date:   Tue, 28 Nov 2023 21:40:13 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] lib: kstrtox: fix typo in comment
Content-Language: en-US
To:     Wilken Gottwalt <wilken.gottwalt@posteo.net>
Cc:     linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
References: <ZWWkeVTvDBQDA_SF@monster.localdomain>
 <d9ac4b6c-e473-4c00-b016-a9cebdb59325@infradead.org>
 <20231129054834.2ffbe481@posteo.net>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20231129054834.2ffbe481@posteo.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/28/23 20:48, Wilken Gottwalt wrote:
> On Tue, 28 Nov 2023 08:26:03 -0800
> Randy Dunlap <rdunlap@infradead.org> wrote:
> 
>> On 11/28/23 00:27, Wilken Gottwalt wrote:
>>> Delete one of the double f's in "iff".
>>>
>>> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@posteo.net>
>>
>> Nope, see:
>>   https://en.wikipedia.org/wiki/If_and_only_if
> 
> Oh, interesting. Never thought of this. Though, now I wonder: How often do such
> "fixes" happen?

I think that I have seen 2 other patches for "iff", but I probably have missed some.


>>> ---
>>>  lib/kstrtox.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/kstrtox.c b/lib/kstrtox.c
>>> index d586e6af5e5a..b0a9fdce15b3 100644
>>> --- a/lib/kstrtox.c
>>> +++ b/lib/kstrtox.c
>>> @@ -340,7 +340,7 @@ EXPORT_SYMBOL(kstrtos8);
>>>   * @s: input string
>>>   * @res: result
>>>   *
>>> - * This routine returns 0 iff the first character is one of 'YyTt1NnFf0', or
>>> + * This routine returns 0 if the first character is one of 'YyTt1NnFf0', or
>>>   * [oO][NnFf] for "on" and "off". Otherwise it will return -EINVAL.  Value
>>>   * pointed to by res is updated upon finding a match.
>>>   */
>>
> 

-- 
~Randy