Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4360558rdh; Tue, 28 Nov 2023 21:42:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHO6N972FDmWWBSln2EgdT5WMx0O/7Hgdrud9tpfv4ajbuM9+olhcG1Byl1EF/WhYFV7Nm X-Received: by 2002:a17:902:ee82:b0:1cf:96a0:e4eb with SMTP id a2-20020a170902ee8200b001cf96a0e4ebmr17205475pld.37.1701236537859; Tue, 28 Nov 2023 21:42:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701236537; cv=none; d=google.com; s=arc-20160816; b=GvJ1cGWQCDWBMhyOdg9/M4e9yT84xjE8kEHLa1KZawgB9uBRZgjsUJ26NazRDjfqAJ to82ii31hSr9wel0dS3iKhVYGKvcZ3ouTd9BG/APS9CoHY4FPtl8nAMgZBt+tjbLP1NQ 2KB5n8G6C64/ifmku71KxiIiEfYv2lolJ/a2C8HApJchL0MIv8dLHHBePxbnbwVVhNye Xzs9sWMJdnNQ0tpUF71Tn7QIQCc5LA0fTLuZQbbOzV4yod0FJk+fRZMaooqizbstnjwX M0zjfk84h2bSlAlg8brSlVkPaxwn/u120Y5S4O5ZCMP6R7XvCfZq1VzsitHlZA/0tbAH o0XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=PsaOol7ocb/iGZfJuZJyDf0wjuc8qFIf2hC77PzevFs=; fh=h3G+JKyrvGTY4IDHl3QNCgCSRyv27XxZoC2f2MnIcCg=; b=DTKFrYqVleb2XoVEq/Xipi8o5JB8qKFifepIjNe93U/XGuAqu//acwdN2tYEoep+t+ aD2djPE2TLPtp1MQzE310RdeDu7pq2pWHuN7SlBQFBkIVts6orchRsSAukO73HhiQ47Y EnpkfLlfnUeyjzXBbVqUdT2+zzWsR1uH6gmFjRABM6rRjGDLK8PJ/CLGKN3ZuzB6IpPR HFfLaHQmljIkZDltDHGAYm4Y6xT6IWqM4OdZeTZ8ASm5pH8cRwHpkESoEkl4IvvjjWqR AxwNhACqBiqmEGvvpEpPo4GImbS9OxIBwV1wmgUVWHO9eZV6UKXai7gz9MNmwdN+78XE Cssg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=gaQuH1lb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id z15-20020a170903018f00b001d00553ba44si2209619plg.446.2023.11.28.21.42.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 21:42:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=gaQuH1lb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 9D87F809848E; Tue, 28 Nov 2023 21:42:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376952AbjK2FmC (ORCPT + 99 others); Wed, 29 Nov 2023 00:42:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbjK2FmA (ORCPT ); Wed, 29 Nov 2023 00:42:00 -0500 Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEDFF1AE; Tue, 28 Nov 2023 21:42:06 -0800 (PST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AT3jmaU006444; Tue, 28 Nov 2023 21:41:59 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=pfpt0220; bh=PsaOol7ocb/iGZfJuZJyDf0wjuc8qFIf2hC77PzevFs=; b=gaQuH1lbTAHggIpox5x9SWpbbZ+ZT9V6jqYWxGBsonWiu66v5HvL8nnzxbkg4MTSW2Vp +DF81TNjvqn3l96bhoSHTDvQ9M9UnBc3a4IuMD5ebCFmDgwdyXCw+HkiiUeaKfB6fCIh 7wrvSqDq65lSRtQAQOG7/DC7lpxnellGbbWzo7vYyFhuKW02ZIaYLfWIiG4YCSDhkSmL TkFGcid58eFM76lOv+EQp8CA0blzE5F/XZgbqQQ0B1H6qtam622K9HlzcUM+DKH6J2/j DoK9SjDjeyn6q3o6LiiOiaQIH1kYajcahtRpAll2v1cT/nxPPJEsy5Dp/LJL60ijs/3O IA== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3una4dmhgw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 28 Nov 2023 21:41:59 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 28 Nov 2023 21:41:57 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 28 Nov 2023 21:41:57 -0800 Received: from hyd1358.marvell.com (unknown [10.29.37.11]) by maili.marvell.com (Postfix) with ESMTP id C4A4C3F7048; Tue, 28 Nov 2023 21:41:51 -0800 (PST) From: Subbaraya Sundeep To: , CC: , , , , , , , , , , Subbaraya Sundeep Subject: [PATCH v3 net] octeontx2-af: Check return value of nix_get_nixlf before using nixlf Date: Wed, 29 Nov 2023 11:11:48 +0530 Message-ID: <1701236508-22930-1-git-send-email-sbhatta@marvell.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-GUID: idnKMRQx-GUERl9VfTFrPLJ75Zi3pvKj X-Proofpoint-ORIG-GUID: idnKMRQx-GUERl9VfTFrPLJ75Zi3pvKj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-29_03,2023-11-27_01,2023-05-22_02 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 28 Nov 2023 21:42:15 -0800 (PST) If a NIXLF is not attached to a PF/VF device then nix_get_nixlf function fails and returns proper error code. But npc_get_default_entry_action does not check it and uses garbage value in subsequent calls. Fix this by cheking the return value of nix_get_nixlf. Fixes: 967db3529eca ("octeontx2-af: add support for multicast/promisc packet replication feature") Signed-off-by: Subbaraya Sundeep --- v3 changes: Added version history v2 changes: CCed AF driver maintainers and original author of patch drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c index 16cfc80..f658058 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c @@ -389,7 +389,13 @@ static u64 npc_get_default_entry_action(struct rvu *rvu, struct npc_mcam *mcam, int bank, nixlf, index; /* get ucast entry rule entry index */ - nix_get_nixlf(rvu, pf_func, &nixlf, NULL); + if (nix_get_nixlf(rvu, pf_func, &nixlf, NULL)) { + dev_err(rvu->dev, "%s: nixlf not attached to pcifunc:0x%x\n", + __func__, pf_func); + /* Action 0 is drop */ + return 0; + } + index = npc_get_nixlf_mcam_index(mcam, pf_func, nixlf, NIXLF_UCAST_ENTRY); bank = npc_get_bank(mcam, index); -- 2.7.4