Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4373065rdh; Tue, 28 Nov 2023 22:20:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IHKZwXL0nanH9FoLOcpsXu2sRFpHfRiedRoBsOu/rpsiJrP9Rzh/EnBiA5WZm/XCgG4HWYL X-Received: by 2002:a9d:62cd:0:b0:6ce:30ce:3c94 with SMTP id z13-20020a9d62cd000000b006ce30ce3c94mr19974930otk.4.1701238827360; Tue, 28 Nov 2023 22:20:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701238827; cv=none; d=google.com; s=arc-20160816; b=sfOpkAaW/0vdpEmVrriSefKPOXaNW5xLz777KWc2My3L0hGDyYyEfbTPOK3eOjos7w 0oNg1AXfq6GdqWfeEsypDa4ZvxEpk21+1qjSqVff+4Vmdw5+cL9ifI/6rHZ0hQnnzfaA PVerQmzoyECVcSHD80c4vNxIZYarbISr331zCQTJndvzIOgacMPF3rbRRzGQ0xXDi7rU 522foIhwNKlkq6MPIi+S/kklbpLZQt3gtZ5qd3ZTxdeZAztFp/usFyRhDJJKorpVHqQO D9c6gUqagKA9UZ23krJGzuL8RNYQW6KftjoxkS/A7j8Upn64lAz7h2a6UJQx0yMQRSuN 4+4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fTVx8N2lyLVeP/GZzmvvrZO4776iEUf9UriNFWs6nw4=; fh=0TmBxb3iK+HPjRlYDVXDLy5dPQUGD9gLiQry0et3j2E=; b=pXGuZ05sAw7V2RlzBFn/R7wgInuGgVgxddChCL5IOXqRo6TzUKMvsAtJBTZ+Hra+z4 KIhl7BzIZY1kLoGPxALcKyEkKJEtIjzHZRbaqwdLMireH0Sbu0fp4Aazb+jTroSwssmZ +cnp1XO9BTIQGLTLCuCBE55eZTElFmct8jwSR+EZJ7QjgMqJYGJvj/exLKdLKERotcXS p3Xlz+l5yOSDc0dXcsPdI3t8BcGtNAYQ7Y3PoFe5e3T5oOHUgYUqh+xMGvE39iAcr5++ Q1VdmmdEzBNVPjubCpC/N60lgzweD3hEXAydAw2glXia1EF7LrV0kMiN95vHtBGR4j1+ /9yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=btPiitC9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id bz3-20020a056a02060300b005be09a118d3si15295689pgb.143.2023.11.28.22.20.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 22:20:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=btPiitC9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 72FBE807E882; Tue, 28 Nov 2023 00:05:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344039AbjK1IE6 (ORCPT + 99 others); Tue, 28 Nov 2023 03:04:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343986AbjK1IEn (ORCPT ); Tue, 28 Nov 2023 03:04:43 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5033E1A3 for ; Tue, 28 Nov 2023 00:04:49 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40859dee28cso41748885e9.0 for ; Tue, 28 Nov 2023 00:04:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1701158688; x=1701763488; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fTVx8N2lyLVeP/GZzmvvrZO4776iEUf9UriNFWs6nw4=; b=btPiitC99qPsBgEM94E46UgZB7+GJfKZdtn6J7Gckw3he8kTGnxcUnc6GwqkSf8Dd+ Rw7WQ9nf7agG9IlppmHfSombhRYKlZw4FWXo+xXPvwKriiJ9xY+qLC6iHF+sG0NuQF01 Mhyz/R6OvjIsBK1qO0xe3rdQ5I6XK75Ifrp7G2nFrPZKHKuecDtuiod9KMAX0KrWN29/ 3z9JD3TcdzyEoMcrY79WmYjGjqiaBSoJi80veH8iHGcTQcX+6UCWzvkpwLjBapaj0YRb zOw18C8BKGHWlrDVTyy+h9V/oKQ5yCKINE6o3i0q3q1YBIPO7GW6uuX7oAg9Ck6WoFuO O3kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701158688; x=1701763488; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fTVx8N2lyLVeP/GZzmvvrZO4776iEUf9UriNFWs6nw4=; b=K6LwQQGy/z0I9oUlavfYJO4fQ98uMNhM2t3DwBRDXNUi5UHUhuXaII9pJ47ExgDY8P fu2jvw5tXVIGuQZ9xL3KLrXJHEk9tIMAF1kbqCUnqJAZ6SWv8RgjYbEc3lI9+MGTA79H tK2oi8i6oK4OE2s6D8HyklnVamzGYtU/rKS7KGO7VBtqybUWvRG3gyLcfuweAL2zsTjX Zy3CPHTomp0RStKJ9/dAIvEERhj6AhKWra4N/+gntX9uvvOZWgd/yL0aFH0sI1FEmOAa 2XkvA3XgwkaZrJqesDFBNIPs1gVHr7AHhsJf7wu5HbE1UGW52IsBwKoUPdAPxRzOHIVq 7E+A== X-Gm-Message-State: AOJu0YxenutgwmeiUqGD9HXvODDKAsMlUEYa3AJAzhQt4EVRufAhWWD3 46OHRM58Mx+VPBbrUQ/2HTIE7A== X-Received: by 2002:a05:600c:4e94:b0:40b:4c36:f80 with SMTP id f20-20020a05600c4e9400b0040b4c360f80mr810627wmq.32.1701158687784; Tue, 28 Nov 2023 00:04:47 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.125]) by smtp.gmail.com with ESMTPSA id g18-20020a05600c4ed200b0040b4ccdcffbsm1127534wmq.2.2023.11.28.00.04.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 00:04:47 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: s.shtylyov@omp.ru, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, p.zabel@pengutronix.de, yoshihiro.shimoda.uh@renesas.com, renesas@sang-engineering.com, robh@kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, mitsuhiro.kimura.kc@renesas.com, masaru.nagai.vx@renesas.com Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/6] net: ravb: Start TX queues after HW initialization succeeded Date: Tue, 28 Nov 2023 10:04:37 +0200 Message-Id: <20231128080439.852467-5-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231128080439.852467-1-claudiu.beznea.uj@bp.renesas.com> References: <20231128080439.852467-1-claudiu.beznea.uj@bp.renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 28 Nov 2023 00:05:41 -0800 (PST) From: Claudiu Beznea ravb_phy_start() may fail. If that happens, the TX queues will remain started. Thus, move the netif_tx_start_all_queues() after PHY is successfully initialized. Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") Reviewed-by: Sergey Shtylyov Signed-off-by: Claudiu Beznea --- Changes in v2: - none Changes since [1]: - collected Rb tag [1] https://lore.kernel.org/all/20231120084606.4083194-1-claudiu.beznea.uj@bp.renesas.com/ drivers/net/ethernet/renesas/ravb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 62a986b5de41..2ef46c71f2bb 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -1812,13 +1812,13 @@ static int ravb_open(struct net_device *ndev) if (info->gptp) ravb_ptp_init(ndev, priv->pdev); - netif_tx_start_all_queues(ndev); - /* PHY control start */ error = ravb_phy_start(ndev); if (error) goto out_ptp_stop; + netif_tx_start_all_queues(ndev); + return 0; out_ptp_stop: -- 2.39.2