Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Wed, 29 Nov 2023 14:12:45 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     "Darrick J. Wong" <djwong@kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Documentation <linux-doc@vger.kernel.org>,
        Linux XFS <linux-xfs@vger.kernel.org>,
        Linux Kernel Workflows <workflows@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Chandan Babu R <chandan.babu@oracle.com>,
        Namjae Jeon <linkinjeon@kernel.org>,
        Dave Chinner <dchinner@redhat.com>,
        Steve French <stfrench@microsoft.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Allison Henderson <allison.henderson@oracle.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Charles Han <hanchunchao@inspur.com>,
        Vegard Nossum <vegard.nossum@oracle.com>
Subject: Re: [PATCH RESEND v2] Documentation: xfs: consolidate XFS docs into
 its own subdirectory
Message-ID: <ZWbkbfjyDJS7jxDg@archie.me>
References: <20231128124522.28499-1-bagasdotme@gmail.com>
 <20231128163255.GV2766956@frogsfrogsfrogs>
 <20231129052400.GS4167244@frogsfrogsfrogs>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="/eNx4OrSdA7OOxOK"
Content-Disposition: inline
In-Reply-To: <20231129052400.GS4167244@frogsfrogsfrogs>
Precedence: bulk


--/eNx4OrSdA7OOxOK
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 28, 2023 at 09:24:00PM -0800, Darrick J. Wong wrote:
> On Tue, Nov 28, 2023 at 08:32:55AM -0800, Darrick J. Wong wrote:
> > On Tue, Nov 28, 2023 at 07:45:22PM +0700, Bagas Sanjaya wrote:
> > > XFS docs are currently in upper-level Documentation/filesystems.
> > > Although these are currently 4 docs, they are already outstanding as
> > > a group and can be moved to its own subdirectory.
> > >=20
> > > Consolidate them into Documentation/filesystems/xfs/.
> > >=20
> > > Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> > > ---
> > > Changes since v1 [1]:
> > >=20
> > >   * Also update references to old doc path to address kernel test rob=
ot
> > >     warnings [2].
> > >=20
> > > [1]: https://lore.kernel.org/linux-doc/20231121095658.28254-1-bagasdo=
tme@gmail.com/
> > > [2]: https://lore.kernel.org/linux-doc/a9abc5ec-f3cd-4a1a-81b9-a69001=
24d38b@gmail.com/
> > >=20
> > >  Documentation/filesystems/index.rst                |  5 +----
> > >  Documentation/filesystems/xfs/index.rst            | 14 ++++++++++++=
++
> > >  .../{ =3D> xfs}/xfs-delayed-logging-design.rst       |  0
> > >  .../{ =3D> xfs}/xfs-maintainer-entry-profile.rst     |  0
> > >  .../{ =3D> xfs}/xfs-online-fsck-design.rst           |  2 +-
> > >  .../{ =3D> xfs}/xfs-self-describing-metadata.rst     |  0
> > >  .../maintainer/maintainer-entry-profile.rst        |  2 +-
> > >  MAINTAINERS                                        |  4 ++--
> > >  8 files changed, 19 insertions(+), 8 deletions(-)
> > >  create mode 100644 Documentation/filesystems/xfs/index.rst
> > >  rename Documentation/filesystems/{ =3D> xfs}/xfs-delayed-logging-des=
ign.rst (100%)
> > >  rename Documentation/filesystems/{ =3D> xfs}/xfs-maintainer-entry-pr=
ofile.rst (100%)
> > >  rename Documentation/filesystems/{ =3D> xfs}/xfs-online-fsck-design.=
rst (99%)
> > >  rename Documentation/filesystems/{ =3D> xfs}/xfs-self-describing-met=
adata.rst (100%)
> >=20
> > I think the rst filename should drop the 'xfs-' prefix, e.g.
> >=20
> > 	Documentation/filesystems/xfs/delayed-logging-design.rst
> >=20
> > since that seems to be what most filesystems do:
>=20
> Actually, ignore this suggestion.  I forgot that I have vim paths
> trained on the Documentation/filesystems/ directory, which means I'll
> lose the ability to
>=20
> :f xfs-online-fsck-design.rst
>=20
> and pop it open.  Not that I expect many more filesystems to grow online
> fsck capabilities, but you get the point...

So is it OK to just move the the docs and keeping their basename intact (as=
 I
did here)?

> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index ea790149af7951..fd288ac57e19fb 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -23893,10 +23893,10 @@ S:	Supported
> > >  W:	http://xfs.org/
> > >  C:	irc://irc.oftc.net/xfs
> > >  T:	git git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git
> > > -P:	Documentation/filesystems/xfs-maintainer-entry-profile.rst
> > > +P:	Documentation/filesystems/xfs/xfs-maintainer-entry-profile.rst
> > >  F:	Documentation/ABI/testing/sysfs-fs-xfs
> > >  F:	Documentation/admin-guide/xfs.rst
> > > -F:	Documentation/filesystems/xfs-*
> > > +F:	Documentation/filesystems/xfs/xfs-*
> >=20
> > Shouldn't this be "Documentation/filesystems/xfs/*" ?
>=20
> ...though this suggestion remains standing.

OK, will fix it up in v3.

--=20
An old man doll... just what I always wanted! - Clara

--/eNx4OrSdA7OOxOK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZWbkbQAKCRD2uYlJVVFO
o757AQD9Ejtcv8+azDThzWPWiwdN8rQV3SamIEbhm6K4/76GngD/fxUlqtAWi9rD
XNZI+P3xF/P1UWcrtV0NE0VOBuZzhgU=
=Fq99
-----END PGP SIGNATURE-----

--/eNx4OrSdA7OOxOK--