Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4412715rdh; Wed, 29 Nov 2023 00:11:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEoSjzPLbikvFb0I0E1TTIk5KHV2BOVOWk+1SWuDBQmN3GOg0N+jTOig1wezghaSS0bKuD2 X-Received: by 2002:a17:90b:38c1:b0:285:adab:2ab2 with SMTP id nn1-20020a17090b38c100b00285adab2ab2mr13453562pjb.1.1701245500022; Wed, 29 Nov 2023 00:11:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701245500; cv=none; d=google.com; s=arc-20160816; b=qQEIjRxueHc8ipFHaasb8afYQU4aVhmLNhyH46a2p1QdAek9kh4QRtNJJfK/1vmka6 AmEhrHqa2zg8yUS5sWGAl9mjelgjXQ3Zx2Q4zZH5vZOP69a5yr71sKiPssPsnZI60aWU ZNta6qWIZHNBFlgDipzRaXwRwZ1qJtQSeX/0CxGJBbGp6vEULvBPthbhwEOxUotJOg1s 0bwBQqCHhr5sYjfo0MIqeIlqic9mmh90mr7Euw9/wL1abYDhciLdlSZSbd+YL0UkUSTw WtXwHpPrE72KmpcgKT2eYM4+R9KgxSBzLg0fh59VPVllwr4NEr3tRrMUgBmgJkhQN8kV MKrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=h8hB39U7zFZuE+RYHWIc6hAMzXdsKB0nNNKBmoc3gdY=; fh=B+n+a6RqDxPBxtMzZOKhrMNBtgUfV8pQkSKqPVvmarA=; b=giK4TFXjmvsbRl3Xvodyxo2d1NsLovfrB7ZUL6LdI99Gd+if4Sfqvbm464Eou2c8HH ghIiy47/8rxtNTpPxM4pbSUaNxNOwzdfpiNxzCFHcuNDUd2VzSzCdetUWJ+2ggBJf8oE R1jjVeXoQaupGw44DKDKr30LRLI+9LdHL1k+R5DBNnISWCOGCGvRlOwz1HAiuBjefwON HQGvXh0MtXY0ruWN1nCiBg6Mi+IzAZGq/NebB9Hy9xovsrxg9naxWRVkeh282kniI7Ik Ky0TSSeBq+OQTWKdUyQsIAxoM3QjDp6RfgX+UcvxtSJUzRdODHdp6WEgS17TDsgGh5Xz dpjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UBtBLPcg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id fu22-20020a17090ad19600b002859a8c63f4si814179pjb.160.2023.11.29.00.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 00:11:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UBtBLPcg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id E7ED68059150; Wed, 29 Nov 2023 00:11:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbjK2ILQ (ORCPT + 99 others); Wed, 29 Nov 2023 03:11:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229650AbjK2ILP (ORCPT ); Wed, 29 Nov 2023 03:11:15 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35E2019B9 for ; Wed, 29 Nov 2023 00:11:21 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-50aabfa1b75so9043269e87.3 for ; Wed, 29 Nov 2023 00:11:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701245479; x=1701850279; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h8hB39U7zFZuE+RYHWIc6hAMzXdsKB0nNNKBmoc3gdY=; b=UBtBLPcg5ywEM6sC9qlvawj6SkcikWvsZ6gRSg24AlNsrpwTBobKgoipdZG+gv15SP Oblh7k7JQHbpZ1s0zqxnKtSQv6Sz2KbDL4rPgQJPambcSVi6Ts6Sh/ha4kz26RUU/ygp 2WRs74VJrxqFE30vOEIr7NWB4pkj3OTmo0VyA8k2jyyZ8NocbPo8tN8rYCyUnzwlX8lJ PUzxXPBOqXgb9iMsbTbnqcZBW78UcnGewwOFzeAzaQLeWjQWFArZ+Ynys5ypcXyW8hPp rw45JjqZ2+WGuRXh2HX/FsKIqEensDNcQpNZ7sq6mLZf6GBcgwlXlorDt6mweiWwf+UU csbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701245479; x=1701850279; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h8hB39U7zFZuE+RYHWIc6hAMzXdsKB0nNNKBmoc3gdY=; b=AguPUjYZJvb5+pKEIAxPD+YAirRWV7uK/Ozd7gpFdNuv26zBpqfX7o956gJ1Tyfj8V QiWbPs9yrsz5bN48261oZowCq/bzOHRSxL4Z1/V8c06TH7X2cwCdsySygbPjobYdCY3i MxGRmZrXpRjgm4kHRZhU4fNn1Ya4AwOF9O26CgK8hBz95tWHjcJc7G8lumItnPp+pSI/ A8AQUyzh1JjORXzQ6L22x5YZPO9Ha19j14pzNxNzo0U0ebC/ybuEPdcP1HmdxZSzswpV XpuYB+w/W4L7ckMmG+tFDnf7an9TOUVKpDCi4y1bOJt+nrS8CuUeZYme/jYaJ6iEkj0S WsXg== X-Gm-Message-State: AOJu0Yxq8WRoqW94TeQ/fbCBJ9aYK7y28i9oP2ckNVlfvZUBykpDabsB naarvw9Qf3/vD8QOFB/+Aj9MnQ== X-Received: by 2002:a05:6512:2350:b0:507:9fc1:ca7a with SMTP id p16-20020a056512235000b005079fc1ca7amr11026901lfu.9.1701245479441; Wed, 29 Nov 2023 00:11:19 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.109]) by smtp.gmail.com with ESMTPSA id v12-20020a170906338c00b009f2b7282387sm7594010eja.46.2023.11.29.00.11.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Nov 2023 00:11:18 -0800 (PST) Message-ID: Date: Wed, 29 Nov 2023 09:11:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] arm64: dts: nuvoton: Add pinctrl support for ma35d1 Content-Language: en-US To: Jacky Huang , linus.walleij@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, j.neuschaefer@gmx.net Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ychuang3@nuvoton.com, schung@nuvoton.com References: <20231128061118.575847-1-ychuang570808@gmail.com> <20231128061118.575847-4-ychuang570808@gmail.com> <7edda3ca-b98a-4125-979f-3ee7ac718a9a@linaro.org> <7fed5d90-da04-40fb-8677-b807b6f51cc9@linaro.org> <8663d26e-32b8-4f2b-b497-9efa7440f070@gmail.com> <2fab32e6-23a4-41bb-b47b-4f993fc590dc@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 29 Nov 2023 00:11:36 -0800 (PST) On 29/11/2023 04:35, Jacky Huang wrote: >>>> Best regards, >>>> Krzysztof >>>> >>> Yes, it did pass the 'dtbs_check'. I guess the tool does not detect such >>> issues. >>> Anyway, I will fix it in the next version. >> Hm, I see your bindings indeed allow pin-.* and unit addresses, so it is >> the binding issue. >> >> The examples you used as reference - xlnx,zynqmp-pinctrl.yaml and >> realtek,rtd1315e-pinctrl.yaml - do not mix these as you do. >> >> I don't understand why do you need them yet. I don't see any populate of >> children. There are no compatibles, either. >> >> Which part of your driver uses them exactly? >> >> Best regards, >> Krzysztof >> > > I will move the 'pcfg_default: pin-default' from dtsi to dts, like this: > > &pinctrl { >     pcfg_default: pin-default { >         slew-rate = <0>; >         input-schmitt-disable; >         bias-disable; >         power-source = <1>; >         drive-strength = <17100>; >     }; This solves nothing. It's the same placement. Best regards, Krzysztof