Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4418635rdh; Wed, 29 Nov 2023 00:26:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IG/tUrDIbGWPHSxSgWoBf3nls9bNwbFM9UFyf1swvNSrnyUHCinKAiQuy112Pib8R48hXzd X-Received: by 2002:a05:6808:f09:b0:3ae:4cab:526a with SMTP id m9-20020a0568080f0900b003ae4cab526amr23084745oiw.14.1701246404257; Wed, 29 Nov 2023 00:26:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701246404; cv=none; d=google.com; s=arc-20160816; b=Y36s+bYeDWi3CgKNH7bvVgonKOU5ndHnHYmCZR0gZmmMutFABVXnJC19P4RkGpZz+/ ctDxpVuaz4hymMeAK9J/exJKrfKzjryiIpCy1Vi2+OZ6jua4cfB9Uv9Hfu+uEv8IAlow IfrsFpXfjNSyfXeCMk0TXwMiASYotW6xl1n29iOqE25k05bh5fdnLEWEUj0It0UNqjO0 LXp5LVgW+fJbYO5x1aiMyiH6s7mcOZisVGKXpUa/glIc5ZiQQF4bF5/PdPJacuJz1MnX s0iD515sCwrHtUUO8LnzaHjlyzWCbA7LXc+J5fEcDyXFFQG70rNNBRztGQqQ4Wk/fm5Q 8UsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=BUFCQFaG43VWU6BqASrwkTFYwmHUVYByYpRP7jEsSls=; fh=pLc7qPDmQ3C4DuyJhwhTj3IMi69j+FOGwbMmnHL07GY=; b=V4LrA6AlxvilZi4/jPQ16Lq1aiqAZ8WeDDy83IJNhTCmbng3LlCD4kHh7Kd4grc8jJ /TxLYvBFiSKRpX1gPwfL1s9cHXX0YK0gTI84IeLjwsRcUbgVxqxNDX9Nd5tv+SOqD72h YJd3+vNlCsRTufUe0v9FoIK/KZPCd+wd9ADSxqgA54UqOIHtyrRpzTG7a7By/sP3zO8d 20SDMZqn40jtTY87xWmTK+rps83m1Sl2XTCxYekk8hhB+hrFFto0Qi+DvnnQsTx8+/rQ Yk4k88eDq8JticyCPOdPi4OzlDIN6/UYg1DT+JhoglTzH12wxp2lKk7H5m85vD7ecdlj Aonw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jYsXg6N4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id j33-20020a63fc21000000b005be3c09abebsi5406218pgi.225.2023.11.29.00.26.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 00:26:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jYsXg6N4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 632B680944E8; Wed, 29 Nov 2023 00:26:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbjK2I0O (ORCPT + 99 others); Wed, 29 Nov 2023 03:26:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbjK2I0N (ORCPT ); Wed, 29 Nov 2023 03:26:13 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3E4519B2 for ; Wed, 29 Nov 2023 00:26:18 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-50bc7706520so191910e87.3 for ; Wed, 29 Nov 2023 00:26:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701246377; x=1701851177; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BUFCQFaG43VWU6BqASrwkTFYwmHUVYByYpRP7jEsSls=; b=jYsXg6N4fOTTnn6LbQT+7XyQfJCqOdtW+0Is/OyjNULA3vipdI+1e+f0wdaZr0QPDm H0Kth95VzqGizPPhMsvV7cVLoP1WholzDnLT/JQMm7TFQ5Kx4CBKceB2t1G4Ao33XlzJ QBdz+oouRyvhhQtLHSwd4NpYs7YAF4T+I4osZje06PpkN8yGO410Tp0z2Jx/4l0SzD7B UN8i9+y8Rw6x3HKG6DWkOcxBrzAAdIIx/P1R3aNHo108SQeLVb05VKEbzBJen3Gzhla4 cs/NArp9a/6E9uIKLtwg9TzElyU/cH0FVd4vCKBT95V5kT56T9YqxNRdGW/rn81Flx28 /utg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701246377; x=1701851177; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BUFCQFaG43VWU6BqASrwkTFYwmHUVYByYpRP7jEsSls=; b=uu3WK/A6XOUKAEjBUGazh+CY0gCWJUUW6kVr9Uml0G1ZVfvMJ7GZfWbgHrynHcWdSz YW6Uzj1KYEI9ZeS3RxujgiMc0J9vx9DdLaR8+CloJ+2TkrVg5Tz2tUNNLfJkhKZ2pOTg 2CB+nyB0V4oLigI10q5On8xZ3RCAGBz9WJx/JDgg3An3Akd+A0Gf39hxHbAzPYb0yn7Y BEkx0DyVRUtQKEhrdDFZUFbHqqtZUwZjkXCCG2rGyPOyvxduPyjZReiR1mqbY+HeI91d EwN87VpsVpf9gY/4OzyilREX2VDZYAWn20XOB0k1miazG1e1Gs3vF+xI/iIdpvybbbAm CwMw== X-Gm-Message-State: AOJu0Yx/1u0Y3T4+m4IswJ9eT68UzPO8JVQK1gzMWQFwkYoulT6dqxvW keGnDRTJG+mgGmmHKA4EU99MaA== X-Received: by 2002:a05:6512:ad1:b0:50a:a81e:4698 with SMTP id n17-20020a0565120ad100b0050aa81e4698mr10908699lfu.67.1701246376830; Wed, 29 Nov 2023 00:26:16 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.109]) by smtp.gmail.com with ESMTPSA id cn6-20020a0564020ca600b0054b2a9dc69csm4560652edb.40.2023.11.29.00.26.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Nov 2023 00:26:16 -0800 (PST) Message-ID: <8f2f241d-580a-4906-949a-b99b5a600868@linaro.org> Date: Wed, 29 Nov 2023 09:26:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] dt-bindings: serial: cdns: Add new compatible string for StarFive JH8100 UART Content-Language: en-US To: Sia Jee Heng , kernel@esmil.dk, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, krzk@kernel.org, conor+dt@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, daniel.lezcano@linaro.org, tglx@linutronix.de, conor@kernel.org, anup@brainfault.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, michal.simek@amd.com, michael.zhu@starfivetech.com, drew@beagleboard.org Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, leyfoon.tan@starfivetech.com References: <20231129060043.368874-1-jeeheng.sia@starfivetech.com> <20231129060043.368874-6-jeeheng.sia@starfivetech.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231129060043.368874-6-jeeheng.sia@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 29 Nov 2023 00:26:33 -0800 (PST) On 29/11/2023 07:00, Sia Jee Heng wrote: > Add new compatible string for UART in the StarFive JH8100 SoC. > > Signed-off-by: Sia Jee Heng > Reviewed-by: Ley Foon Tan The patch is quite different than v1. Are you sure the review is applicable? If it was given for v2, where is it? > --- > Documentation/devicetree/bindings/serial/cdns,uart.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > index e35ad1109efc..0d05305778f2 100644 > --- a/Documentation/devicetree/bindings/serial/cdns,uart.yaml > +++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > @@ -20,6 +20,10 @@ properties: > items: > - const: xlnx,zynqmp-uart > - const: cdns,uart-r1p12 > + - description: UART controller for StarFive JH8100 SoC This is duplicating compatible, drop. > + items: > + - const: starfive,jh8100-uart > + - const: cdns,uart-r1p8 Don't add things to the end of the list, but keep order. I would suggest to put it at the beginning, so before Xilinx. Best regards, Krzysztof