Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4448567rdh; Wed, 29 Nov 2023 01:38:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFRIbIeX/QvI9AIP/3RP8qgi6EVMT4vdiIZmt0xc6hf5eNpYp9/2d1jkkLjPmKZTLWtZEyU X-Received: by 2002:a17:902:7409:b0:1cf:a2e7:f851 with SMTP id g9-20020a170902740900b001cfa2e7f851mr17633287pll.32.1701250735321; Wed, 29 Nov 2023 01:38:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701250735; cv=none; d=google.com; s=arc-20160816; b=eKUk0jyTgQYcPORVhm5cr7DkFmW8jhL9Pl7/flgtkQq0DPH0NQ3opCgkOmMt+A95Z/ fThdRgL3ztv4N4GQsuowjb5FlB5vEemnwXwwufMB8wIpgh0xXudeKubnjdWUcjfLnRLG eaDrcy9h4ZfV6bbnhfWBLYhkZkZXNQcjOObHZvN3JHjw5O9rZ+pqKSVqH83ZMg+IzSpU OqEo7+rjx70lOgO58ftyjx5ej4SfePY7yvCrW0b1MOR7zEl8Zpt4+NYNHOs7U5fNi3xa NylK9zKpy4VsRKhxob7buBYkNw3yiQzw/thwIBPy//Nqesh9LPIL5KsjuIHIHicXjw3T J4RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=5iQf8HCIX4bIELCAB7Wsi7e/e75JA6+pWA/5/4r6aBI=; fh=2M7VhQjoutm7+TLSQk6KyKOMKW2hojhjH1KY0cMqkNA=; b=hvqhfVLH9KzSdr6Ah6+WD6Pumw7sErovHk06wGL2+6pmEFFC+L/z8EorML6DfONVAh 0bEApLJp/K178zxpRMTW/mg/h3YJ2GDNtAVvnmyXaIUfZiPTyQwLPtsu0fjvIaLiFOZG gRW4JEAy0gOsOn/W47PBoiK8fjO4W6edUSY3g0UZrVuT8Dq4pFG3YFJQExDJ5gDeFwie 4olDypJ0/9fqb+VJM5ScjatAb6DsiKjctniUNXlGBaQwsnoKo2cMgxEl+7ku+XRWtq9O NDUasCcnNFa68CbotltqSsGp9ubSNoM56GxaNaJeBYGuv84UVskQEjyefArbKiSN6f/i 0ypw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=zGtJOpQE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id i16-20020a17090332d000b001cfb32056besi10325104plr.416.2023.11.29.01.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 01:38:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=zGtJOpQE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id F32F6805A7EA; Wed, 29 Nov 2023 01:38:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229602AbjK2Jij (ORCPT + 99 others); Wed, 29 Nov 2023 04:38:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjK2Jij (ORCPT ); Wed, 29 Nov 2023 04:38:39 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0FE21735; Wed, 29 Nov 2023 01:38:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5iQf8HCIX4bIELCAB7Wsi7e/e75JA6+pWA/5/4r6aBI=; b=zGtJOpQEmJtQOsf6u9BE1pRaed XROlB9h+/2a6rQB1kPelKi0gU9qZuo+6dOD1NjKOM1dccN3H6OqINnhmsl8cPx36A8V/llrdStR7u h0L16jxLF8x2b7NM2eiTN9Vk9Tut4AoviWuE4J94+n3fB7Z07wJi81vgRu6+9CWtspdhB2EkpBRPz dtAdO7xUSJF8LTG5OZKFAJWSJ5hs7IuwUY5ZdCotDxVsxY9iVpANAiKTK90igbl+Nnz1zFvk8LxJP tEwXYHBViFKF2Y60yh5ZngoiFmNqC6Uv6u0mKJencaW1TlT4OMZVdhfoOJyTZw9Z4ujZjN1aLdjpV BipT7Jqw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:50696) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r8H1h-0008Vc-2V; Wed, 29 Nov 2023 09:38:37 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1r8H1j-0003rk-Nh; Wed, 29 Nov 2023 09:38:39 +0000 Date: Wed, 29 Nov 2023 09:38:39 +0000 From: "Russell King (Oracle)" To: Christian Marangi Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [net-next PATCH 08/14] net: phy: at803x: drop specific PHY id check from cable test functions Message-ID: References: <20231129021219.20914-1-ansuelsmth@gmail.com> <20231129021219.20914-9-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231129021219.20914-9-ansuelsmth@gmail.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 29 Nov 2023 01:38:53 -0800 (PST) On Wed, Nov 29, 2023 at 03:12:13AM +0100, Christian Marangi wrote: > @@ -1310,10 +1302,6 @@ static int at803x_cable_test_start(struct phy_device *phydev) > */ > phy_write(phydev, MII_BMCR, BMCR_ANENABLE); > phy_write(phydev, MII_ADVERTISE, ADVERTISE_CSMA); > - if (phydev->phy_id != ATH9331_PHY_ID && > - phydev->phy_id != ATH8032_PHY_ID && > - phydev->phy_id != QCA9561_PHY_ID) > - phy_write(phydev, MII_CTRL1000, 0); ... > +static int at8031_cable_test_start(struct phy_device *phydev) > +{ > + at803x_cable_test_start(phydev); > + phy_write(phydev, MII_CTRL1000, 0); I don't think this is a safe change - same reasons as given on a previous patch. You can't randomly reorder register writes like this. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!