Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Wed, 29 Nov 2023 12:19:21 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Damian Muszynski <damian.muszynski@intel.com>,
        linux-kernel@vger.kernel.org,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH v1 1/1] units: Add missing header
Message-ID: <ZWcQKYlCXUIAGnlK@smile.fi.intel.com>
References: <20231128174404.393393-1-andriy.shevchenko@linux.intel.com>
 <20231128180957.ac5caa884abb2b5f00ca47c4@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231128180957.ac5caa884abb2b5f00ca47c4@linux-foundation.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Nov 28, 2023 at 06:09:57PM -0800, Andrew Morton wrote:
> On Tue, 28 Nov 2023 19:44:03 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> > BITS_PER_BYTE is defined in bits.h.
> > 
> > Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")
> 
> This is post-6.6, so the fix should go into this -rc whatever happens, but...
> 
> It would be rather nice to know the effects of this change please.  Did
> some build break?

Not of my knowledge. Fixes tag here to make sure people won't forget that
headers are special and we need a bit stricter rules on how we add a new
stuff (which will require another header) or remove an old one (which may
give a stale inclusion).

-- 
With Best Regards,
Andy Shevchenko