Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Ashwin Dayanand Kamat <kashwindayan@vmware.com>
To:     linux-kernel@vger.kernel.org, thomas.lendacky@amd.com,
        bp@alien8.de, brijesh.singh@amd.com
Cc:     kashwindayan@vmware.com, tglx@linutronix.de, mingo@redhat.com,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        jroedel@suse.de, stable@vger.kernel.org, ganb@vmware.com,
        tkundu@vmware.com, vsirnapalli@vmware.com, akaher@vmware.com,
        amakhalov@vmware.com, namit@vmware.com
Subject: [PATCH v2] x86/sev: Update ghcb_version only once
Date:   Wed, 29 Nov 2023 16:10:29 +0530
Message-Id: <1701254429-18250-1-git-send-email-kashwindayan@vmware.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UEtu8bXPI2Qnr6J3OlaF+QT1PtCoRpIFjSQpn/1gCGddnsexX8Y+NwsUnH+O?=
 =?us-ascii?Q?WHrJDar1PLxhRp/nlo2D71y/Lk+QpDfOCGcuXwqoOXWIjPnbLtNNPzYW6c3Y?=
 =?us-ascii?Q?IAIL3VUc/9ZoPLuH+9UUzDJwD5/GZztA5Pb5WSsYUKXqkd6MNjLIAmTwfEbP?=
 =?us-ascii?Q?21DRRJQtGZ7V/tOztT7eVzmgJf1CSN8ff4s7IElSCBULEU9JLKwspwJvGDEQ?=
 =?us-ascii?Q?kwH8egXLdTvyfay/CCUDSnV7x7fbCjw5xCenNu1lPBGcvZf0PZ3S7xiNqm5H?=
 =?us-ascii?Q?mFlP04gqQQtiJPqSV9/BnMRoPas62rgJfA1goAL89pjhBwmG+PfNHWwvyRQ0?=
 =?us-ascii?Q?NzZVw19u+xoV0cts6zD6YFifdqB9HofDZDA8VISm6rAwFY1ItfOfrrO2lwQa?=
 =?us-ascii?Q?f4anvIPqtlJRFFrmlKSJhwTdo8hwBnbeomp/XGwprp6JhBhgwpF41QGe1gNi?=
 =?us-ascii?Q?UQ7C9m1pqeX7e2WSeOaVvUdprUs8bnF4OQQBkUH4Sb24ajOnBml7I9spiMTF?=
 =?us-ascii?Q?GY3tHBjXwFYraimw74njZnWTn54vOURpnwuhelzh3JCv7keSrLZiPHCgXdH0?=
 =?us-ascii?Q?MekgPi4YtCm4S5qvWQg6BchW5Q4V1ZmJ8qGgrRKm7VIhMGUV590GlSjsIP6K?=
 =?us-ascii?Q?nTqWPZ9QYWnLAkYOt5YcTGxN1ncn1OBIKnAQDav4DpZ9f/4z1YqHzLO/wOgT?=
 =?us-ascii?Q?77C4yVaEcLCh7MW4nmb75110svdcPu1oclmwV3L4bhJQtUnDrkcLkj7OU15M?=
 =?us-ascii?Q?iyqp/4D8S3mIOXzPAhSWj9yJIJ/mHv+rZv7iYhpYegOzbFemI1UcS+04rGw/?=
 =?us-ascii?Q?hOBj0H1PwAXvTDg5cR5vOGH7i0JgsElWZg8dZwLZT+JVvk5ZM6po5TEq/V9R?=
 =?us-ascii?Q?ke7SFRNqNIcn0i+x8nhLlJnJpvgBPTeMGBfwd0mBzqr9CRaRYsZKYvu+dlS1?=
 =?us-ascii?Q?vRmIhQkllye+i+YhVwBTiEPqbSMqOjMWonavodBl9BBcbYZVf0rh0Zpj+yEq?=
 =?us-ascii?Q?PJ8AY9Fo7bUjet/ydC6ELjZ/R1O9Xlm/jA7/DsLpmQhaIV4ZjRXN0R9y4Ke5?=
 =?us-ascii?Q?wFxZocIyc40bOAvfS5logqi1wT2+KKsJr6ZQ4gGEVzRZpSS0x/1XZPeh3Ggi?=
 =?us-ascii?Q?37H4rcrDoGswGC312lQjCZYSzp5RH2tGSAsKa62oWVOn6NTyLKzZvv+kTMk0?=
 =?us-ascii?Q?bcXf4ulpHHyukxlbxOf9D5OANiXCXPpaB5ZipkEC/PBKSVH7ighhEg5hqj+I?=
 =?us-ascii?Q?7OddB623cE7jmxbI93QcccZi3lKX/s133OqeIih6qJpl58Y5a+k69Bf33ImO?=
 =?us-ascii?Q?6D1kN1qghrdcH4Fuux6AiDOEGe5GhLhQmeSkq4IZpgPZbMGAhUWYmeq7u61O?=
 =?us-ascii?Q?z2DkRMT5po4qPrlXd+9HojxJavhqgufbfBRHBkhtl6aacAIZhMTb2Ugs95BO?=
 =?us-ascii?Q?z/0Z0sxIiAGMZN7ouiqiVuCv+lxYVI/Sb3r2Rp+gmDXU3ai5CJ22SpvdIbad?=
 =?us-ascii?Q?hiPgHofSAHOb3RASEMaBPRoaS8v/IRnk10QLdmBE+pn/W8hiApkEgdjeqrmu?=
 =?us-ascii?Q?k4L+CPe6NtkyWy9ZJrrTfw/9v8d4sQhYeyCjexdBc/R4zw4WsLrcA2nz1FsW?=
 =?us-ascii?Q?ig=3D=3D?=
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39b39c6c-aad2-4cbd-e2de-08dbf0c79f9c
X-MS-Exchange-CrossTenant-AuthSource: BL0PR05MB5409.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 10:40:37.1218
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ESOjEIImYKyoZODsoECSwG6ejuPvZm/JeaAT+VPwGI5q/TsSFMb/ZiLVKvfwCVd64ZJFOrZ7J7Gaa7TCKOh/aQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR05MB10176
X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 29 Nov 2023 02:40:51 -0800 (PST)

From: Ashwin Dayanand Kamat <ashwin.kamat@broadcom.com>

kernel crash was observed because of page fault, while running
cpuhotplug ltp testcases on SEV-ES enabled systems. The crash was
observed during hotplug after the CPU was offlined and the process
was migrated to different cpu. setup_ghcb() is called again which
tries to update ghcb_version in sev_es_negotiate_protocol(). Ideally this
is a read_only variable which is initialised during booting.
This results in pagefault.

From logs,
[  256.447466] BUG: unable to handle page fault for address: ffffffffba556e70
[  256.447476] #PF: supervisor write access in kernel mode
[  256.447478] #PF: error_code(0x0003) - permissions violation
[  256.447479] PGD 8000667c0f067 P4D 8000667c0f067 PUD 8000667c10063 PMD 80080006674001e1
[  256.447483] Oops: 0003 [#1] PREEMPT SMP NOPTI
[  256.447487] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 6.1.45-8.ph5 #1-photon
.
.
.
.
.
[  256.447511] CR2: ffffffffba556e70 CR3: 0008000667c0a004 CR4: 0000000000770ee0
[  256.447514] PKRU: 55555554
[  256.447515] Call Trace:
[  256.447516]  <TASK>
[  256.447519]  ? __die_body.cold+0x1a/0x1f
[  256.447526]  ? __die+0x2a/0x35
[  256.447528]  ? page_fault_oops+0x10c/0x270
[  256.447531]  ? setup_ghcb+0x71/0x100
[  256.447533]  ? __x86_return_thunk+0x5/0x6
[  256.447537]  ? search_exception_tables+0x60/0x70
[  256.447541]  ? __x86_return_thunk+0x5/0x6
[  256.447543]  ? fixup_exception+0x27/0x320
[  256.447546]  ? kernelmode_fixup_or_oops+0xa2/0x120
[  256.447549]  ? __bad_area_nosemaphore+0x16a/0x1b0
[  256.447551]  ? kernel_exc_vmm_communication+0x60/0xb0
[  256.447556]  ? bad_area_nosemaphore+0x16/0x20
[  256.447558]  ? do_kern_addr_fault+0x7a/0x90
[  256.447560]  ? exc_page_fault+0xbd/0x160
[  256.447563]  ? asm_exc_page_fault+0x27/0x30
[  256.447570]  ? setup_ghcb+0x71/0x100
[  256.447572]  ? setup_ghcb+0xe/0x100
[  256.447574]  cpu_init_exception_handling+0x1b9/0x1f0

Fix is to call sev_es_negotiate_protocol() only in the BSP boot phase (and
it only needs to be done once)

Fixes: 95d33bfaa3e1 ("x86/sev: Register GHCB memory when SEV-SNP is active")
Co-developed-by: Bo Gan <bo.gan@broadcom.com>
Signed-off-by: Bo Gan <bo.gan@broadcom.com>
Signed-off-by: Ashwin Dayanand Kamat <ashwin.kamat@broadcom.com>
---
v2:
As per the review comments given by Tom Lendacky,  did below changes in v2,
 - Moved sev_es_negotiate_protocol() after initial_vc_handler if-check in setup_ghcb()
 - Added Signed-off of Co-developer
---
 arch/x86/kernel/sev.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c
index 70472eebe719..c67285824e82 100644
--- a/arch/x86/kernel/sev.c
+++ b/arch/x86/kernel/sev.c
@@ -1234,10 +1234,6 @@ void setup_ghcb(void)
 	if (!cc_platform_has(CC_ATTR_GUEST_STATE_ENCRYPT))
 		return;
 
-	/* First make sure the hypervisor talks a supported protocol. */
-	if (!sev_es_negotiate_protocol())
-		sev_es_terminate(SEV_TERM_SET_GEN, GHCB_SEV_ES_GEN_REQ);
-
 	/*
 	 * Check whether the runtime #VC exception handler is active. It uses
 	 * the per-CPU GHCB page which is set up by sev_es_init_vc_handling().
@@ -1254,6 +1250,13 @@ void setup_ghcb(void)
 		return;
 	}
 
+	/*
+	 * Make sure the hypervisor talks a supported protocol.
+	 * This gets called only in the BSP boot phase.
+	 */
+	if (!sev_es_negotiate_protocol())
+		sev_es_terminate(SEV_TERM_SET_GEN, GHCB_SEV_ES_GEN_REQ);
+
 	/*
 	 * Clear the boot_ghcb. The first exception comes in before the bss
 	 * section is cleared.
-- 
2.39.0