Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Donald Robson <donald.robson@imgtec.com>
To:     <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        <llvm@lists.linux.dev>
CC:     <frank.binns@imgtec.com>, <donald.robson@imgtec.com>,
        <matt.coster@imgtec.com>, <maarten.lankhorst@linux.intel.com>,
        <mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
        <daniel@ffwll.ch>, <nathan@kernel.org>, <ndesaulniers@google.com>,
        <trix@redhat.com>, kernel test robot <lkp@intel.com>
Subject: [PATCH] drm/imagination: Fixed clang warnings for initial upstreamed patches.
Date:   Wed, 29 Nov 2023 11:20:14 +0000
Message-Id: <20231129112014.137407-1-donald.robson@imgtec.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IUxjkFt0pkBYqiRRGQ7wNRGVlln8sCV5RfGncYUXzMKrvt4KbVEzPeSAexwg?=
 =?us-ascii?Q?/uHlkl19GHx1dkhTEPCdNukO0CipAJk6spJK+U9/rh2VnvPU9bIQGG+fm6I+?=
 =?us-ascii?Q?YS2ahhb4GzMYcGLOU+o7WKPKFn6MZHpFXvsjZcdaubvqxot6cAUdronptvMJ?=
 =?us-ascii?Q?374pBnyw45Vaf0Hs8M+7xI/9q9V+BZPo6IfEMDzSs+D/yV5x9Snl6vvgbs/F?=
 =?us-ascii?Q?xbDe1n9x0aQGAmQAX03Qf2C/o3s50+FgL5BPHNc1FOyDt1S010rbDVqnh7nt?=
 =?us-ascii?Q?U8i5h5qgmtI0cG7sb8pdTF8h/qQde6pCBTbfJ7C4eLT6odTrsBLKALBXwv/1?=
 =?us-ascii?Q?bAW0iydZC36CHbTgchFVNhfjC2M7Nii12fscBDDn5YAIlwcEWZJdYawHLLJ+?=
 =?us-ascii?Q?8M3loyHi/ZbVu1SpZdbbo7K9nXStZMM0tVpmgNqUZI0Lc3ZqcRsNOs86qTW6?=
 =?us-ascii?Q?hLmdkxt99KtiJZrZTV7E08V8pTPk+Lna9U4CJY/D3617lM6IIyJ6mK8sIovx?=
 =?us-ascii?Q?Aynok4Z5fy8BWubNzwNicWAnhJWaAMKpsgUDOEMQBB6SALnQUAWqAQlDmwtw?=
 =?us-ascii?Q?3G4pFOBtKORpHNTaH6JwqQGhlVrcwwoWzfDd8hbo8Sk7UvsvnYucKo3EP7Br?=
 =?us-ascii?Q?496FkHPMdVL4JiAgOc+QoHyIP7A2kjwFmzSFrF559a121VwmTwQPPjmkE85F?=
 =?us-ascii?Q?sDkrh4OXP+u4oDiWXAM4IhIFV3lD6cWzKLVNfdL529KiZ5FgFVqWG8apaZY5?=
 =?us-ascii?Q?d4MhbudZefAIjaMPhHv/I9Dd6joYHJwMRjoNvzmnxkSBVZUr5KOjWwYi7BEk?=
 =?us-ascii?Q?IqBo2HwdJxPIP/xF6pWXwZDHYfuhMZFqM6F3DpXUhM3cTdUT0vtDJi23bqlf?=
 =?us-ascii?Q?IsZV+j0Ldp9qj+HR9cbPQIoF27a6WhKFw94z10ztf4UmOkHxkraK6A4beY/9?=
 =?us-ascii?Q?U/dTJftHCCOhJGWbIdjmpq1CGhcBAXXjxYWl16lm3oceOT6ZYV/CTaGJJ8QY?=
 =?us-ascii?Q?aW2rfxIHqqiUMKyzR6/Y9olXzoQ60zedRMNsi3/JVBIMOdMUapLbIikTWSJ9?=
 =?us-ascii?Q?5b2YHDNvBxmAUh7k57uJ/aYU6aGHyEmpjSlVIPf4d9mcEtjyDcCBUFqPWd+X?=
 =?us-ascii?Q?qg56Vlhe8eeFqL+seHtQl/qYQqlNPKNnHpNcC9rEhI8nHFo6c9O9oh/Bweef?=
 =?us-ascii?Q?ibcv9qKmaEtJC4Rdd1MhWwmpiL7GkWA4qhE46oiL51Y+ZUah12X5A4gQU1xv?=
 =?us-ascii?Q?g/LuKAlBMOTGIToFpKv/1bGP7UZKUsFXiClZCbc4yhru9slvR8glPgVnvLrE?=
 =?us-ascii?Q?b7O683Xh/91JPnejHg4eEdxUM5kDmbtQ1GHCgDVdo+6q7MlAxWtoJNR2vxhI?=
 =?us-ascii?Q?8p2r/DtOT4SJZsE/sYdEhV+XvI4u/q3sWnq3gxleTT9aUNBZHWm+Ve5DYXKw?=
 =?us-ascii?Q?KkUHZQW06v04Zbz8GwYE4hi7rgk4UveXKTwsArLk83SaNkwTXLbVGloPKUSQ?=
 =?us-ascii?Q?7eFrUOruEBenNzfnMsF95qxJ0Igb1Ub29sr33mxe2fTn8RlHsu9oEDS9YuS7?=
 =?us-ascii?Q?hel5AwqOT01co5CY2TXv2lp9RL/Vz9Vod4Ir4r4VWsEfvJRuDHSMPDP5UPhi?=
 =?us-ascii?Q?Rw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cda186df-7b76-4f1e-8d66-08dbf0cd2ea4
X-MS-Exchange-CrossTenant-AuthSource: CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 11:20:24.5902
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b7H3unJaClP0Bd5zBUEYuYoIvI56Z9Q3ns+eXiqScGhOOOdNmOuR+mOAzD9ejHQ1v5sY4XAPFjlIn3vfHxetf15lOp7yBKRkb1SWa4TQgh0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB6113
X-OriginatorOrg: imgtec.com
X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631
X-Proofpoint-ORIG-GUID: 0IrFqjJtDUtC4c6ytEYp0JcMW6zxB19K
X-Proofpoint-GUID: 0IrFqjJtDUtC4c6ytEYp0JcMW6zxB19K
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 29 Nov 2023 03:21:21 -0800 (PST)

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202311242159.hh8MWiAm-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202311241752.3iLyyFcA-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202311250632.giVEx7MU-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202311250226.Da2yiSKp-lkp@intel.com/
Signed-off-by: Donald Robson <donald.robson@imgtec.com>
---
 drivers/gpu/drm/imagination/pvr_device.c      | 2 +-
 drivers/gpu/drm/imagination/pvr_device_info.c | 3 ++-
 drivers/gpu/drm/imagination/pvr_fw_meta.c     | 1 +
 drivers/gpu/drm/imagination/pvr_vm.c          | 8 +-------
 4 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/imagination/pvr_device.c b/drivers/gpu/drm/imagination/pvr_device.c
index 8499becf4fbb..048eba776cf2 100644
--- a/drivers/gpu/drm/imagination/pvr_device.c
+++ b/drivers/gpu/drm/imagination/pvr_device.c
@@ -127,7 +127,7 @@ static int pvr_device_clk_init(struct pvr_device *pvr_dev)
  * This is called any time we receive a FW event. It iterates over all
  * active queues and calls pvr_queue_process() on them.
  */
-void pvr_device_process_active_queues(struct pvr_device *pvr_dev)
+static void pvr_device_process_active_queues(struct pvr_device *pvr_dev)
 {
 	struct pvr_queue *queue, *tmp_queue;
 	LIST_HEAD(active_queues);
diff --git a/drivers/gpu/drm/imagination/pvr_device_info.c b/drivers/gpu/drm/imagination/pvr_device_info.c
index 11e6bef52ecd..d3301cde7d11 100644
--- a/drivers/gpu/drm/imagination/pvr_device_info.c
+++ b/drivers/gpu/drm/imagination/pvr_device_info.c
@@ -227,7 +227,8 @@ int pvr_device_info_set_features(struct pvr_device *pvr_dev, const u64 *features
 	/* Verify no unsupported values in the bitmask. */
 	if (features_size > mapping_max_size) {
 		drm_warn(from_pvr_device(pvr_dev), "Unsupported features in firmware image");
-	} else if (features_size == mapping_max_size && (mapping_max & 63)) {
+	} else if (features_size == mapping_max_size &&
+		   ((mapping_max & 63) != 0)) {
 		u64 invalid_mask = ~0ull << (mapping_max & 63);
 
 		if (features[features_size - 1] & invalid_mask)
diff --git a/drivers/gpu/drm/imagination/pvr_fw_meta.c b/drivers/gpu/drm/imagination/pvr_fw_meta.c
index 119934c36184..c39beb70c317 100644
--- a/drivers/gpu/drm/imagination/pvr_fw_meta.c
+++ b/drivers/gpu/drm/imagination/pvr_fw_meta.c
@@ -4,6 +4,7 @@
 #include "pvr_device.h"
 #include "pvr_fw.h"
 #include "pvr_fw_info.h"
+#include "pvr_fw_meta.h"
 #include "pvr_gem.h"
 #include "pvr_rogue_cr_defs.h"
 #include "pvr_rogue_meta.h"
diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c
index 04f7d0cf4188..375a03707f4e 100644
--- a/drivers/gpu/drm/imagination/pvr_vm.c
+++ b/drivers/gpu/drm/imagination/pvr_vm.c
@@ -108,12 +108,6 @@ struct pvr_vm_gpuva {
 	struct drm_gpuva base;
 };
 
-static __always_inline
-struct pvr_vm_gpuva *to_pvr_vm_gpuva(struct drm_gpuva *gpuva)
-{
-	return container_of(gpuva, struct pvr_vm_gpuva, base);
-}
-
 enum pvr_vm_bind_type {
 	PVR_VM_BIND_TYPE_MAP,
 	PVR_VM_BIND_TYPE_UNMAP,
@@ -528,7 +522,7 @@ pvr_device_addr_and_size_are_valid(u64 device_addr, u64 size)
 	       (device_addr + size <= PVR_PAGE_TABLE_ADDR_SPACE_SIZE);
 }
 
-void pvr_gpuvm_free(struct drm_gpuvm *gpuvm)
+static void pvr_gpuvm_free(struct drm_gpuvm *gpuvm)
 {
 
 }
-- 
2.25.1