Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762742AbXK3Jba (ORCPT ); Fri, 30 Nov 2007 04:31:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751029AbXK3JbW (ORCPT ); Fri, 30 Nov 2007 04:31:22 -0500 Received: from mtagate5.uk.ibm.com ([195.212.29.138]:1447 "EHLO mtagate5.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733AbXK3JbV (ORCPT ); Fri, 30 Nov 2007 04:31:21 -0500 Date: Fri, 30 Nov 2007 10:30:32 +0100 From: Cornelia Huck To: Kay Sievers Cc: Alan Stern , Greg KH , Kernel development list , Jonathan Corbet , Randy Dunlap Subject: Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init Message-ID: <20071130103032.6393d846@gondolin.boeblingen.de.ibm.com> In-Reply-To: <1196368000.7903.28.camel@lov.site> References: <1196367597.7903.25.camel@lov.site> <1196368000.7903.28.camel@lov.site> Organization: IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Martin Jetter =?ISO-8859-15?Q?Gesch=E4ftsf=FChrung:?= Herbert Kircher Sitz der Gesellschaft: =?ISO-8859-15?Q?B=F6blingen?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.1.0 (GTK+ 2.12.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 34 On Thu, 29 Nov 2007 21:26:40 +0100, Kay Sievers wrote: > On Thu, 2007-11-29 at 21:20 +0100, Kay Sievers wrote: > > On Thu, 2007-11-29 at 15:09 -0500, Alan Stern wrote: > > > On Thu, 29 Nov 2007, Kay Sievers wrote: > > > > > > There's another good reason for not assigning the name in > > > > > kobject_init(): Code that uses kobjects (like the driver core) doesn't > > > > > set the name until later. > > > > > > > > That can be done at any stage, I guess. We will rip out the name in the > > > > struct device anyway. > > > > > > Are you also going to change all the places in the kernel where the > > > device name (.bus_id) isn't set until after device_initialize() has > > > been called? Hmpf, ccw does this as well... > > > > Yes, I already have a patch that does that for all stuff that was needed > > on my boxes. > > To be exact, bus_id will be removed from the device, and the device name > will be set and retrieved directly from the kobject. I guess you'll have accessor functions for the bus id for use by higher level code? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/