Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <e43fc483-3d9c-4ca0-a976-f89226266112@intel.com>
Date:   Wed, 29 Nov 2023 14:40:33 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v5 13/14] libie: add per-queue Page Pool stats
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Michal Kubiak <michal.kubiak@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        Alexander Duyck <alexanderduyck@fb.com>,
        Yunsheng Lin <linyunsheng@huawei.com>,
        "David Christensen" <drc@linux.vnet.ibm.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        "Paul Menzel" <pmenzel@molgen.mpg.de>, <netdev@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20231124154732.1623518-1-aleksander.lobakin@intel.com>
 <20231124154732.1623518-14-aleksander.lobakin@intel.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20231124154732.1623518-14-aleksander.lobakin@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dENRSGJCTDJaTUxOY3daZlJjOWJlNUI3Z2V0d0dUdkpwQm5yZkxzOSs1NnNH?=
 =?utf-8?B?c211dVBscGVRcnVGQ0IwemtYVGpVL2FVRytodlBCRCtIL1o5TS9BK2lONHNs?=
 =?utf-8?B?TUdDYmhkSzcxYkdkWjcxZHNFV24xRmFFaWgzVjJxRkpham5MckFDQjd0Qkdz?=
 =?utf-8?B?c2hMMEE5Sjd0K3dZcUhlK3lzL0tHRUc0RVBWRDRhYlJXR216QjNoNlk2RUw2?=
 =?utf-8?B?WWxWTThRWGFrMUZiRnZab2gwbDdyWGNqUVI3SFRNQjI1SHprbFc3WTFGSVRR?=
 =?utf-8?B?Y3haZmJtK21ta081dVJEOHVrRXpTTjFwUTdDVXZMOGwreXRhU2JxQWlLNHBK?=
 =?utf-8?B?TWVRWjZNM2pyVGpMR21uTk84TkY1RXZuNlhuQ1RpbXVVa2oyNTV3dzdUQnJX?=
 =?utf-8?B?WnNsWnZieXJvOEVXRjY1QjIxUmsxbGQzT1VIOUZ1akJ0djNHM3JEc1ZmOXdB?=
 =?utf-8?B?VXkraVZBK0V6TE1UWGt6OG5FYW5EbC9JaTdUd3c3V3dlSmc3U2RIUEdHdkYw?=
 =?utf-8?B?QmpENEdmelc4dUxWOFpHcHB5cCtGVTdsSHhTUVpXUktLRk40bEpKdE52VVRY?=
 =?utf-8?B?eDNWeHhJYndVeHNPN1pQK3g0UHlQQlpFSWdCR29BbjJVY0NNZnFLcDFzYWty?=
 =?utf-8?B?K0V0dnNZNDJydFZoak5zcXZxckJyeTlkZW1BSC9qS1lmZXhHUXRHUlRnVzBw?=
 =?utf-8?B?Y0hER1oreHlnM1RHOUdkKzZ0dXM5UHViV3dvblJDQ2tCaC9MMTRCMTUyY3pG?=
 =?utf-8?B?UnhBbFAyRTRkQUgzc05wVnI3MlBzL0dka0I3RUlkMDkxR1VZTWQ4bFVGTklm?=
 =?utf-8?B?YUoxSVFWTkV0UE5uT0M5a1ZGUGF0VHZHVm1PUlZyWU9yc2RGMERzd2hldHB6?=
 =?utf-8?B?U2ZlSXJnbm9Kb2drR2lEdmdtUUk2b2tKdnVqak5YUVFDSm5tN3lmclhmY3Y5?=
 =?utf-8?B?U2o5blY4WnJ0SDV6UWlsSHIwTU02YnduRUtjVlV0allDd01PSVdXWU1nRlhU?=
 =?utf-8?B?Wld0eFJuamdDMFNFaVBVdUE3dmxzK0ZTR25WcTlLRmszRUxBdkgwWFlRVGNt?=
 =?utf-8?B?WTNOTk1kL2Y2TlViTGJNYUdrSFdXaFFGMDM0SjFmYzltM0o1V1lRSjVrUHE3?=
 =?utf-8?B?b3RNS3ZsOFV0OUNjS2FxZGdTWXIzYXMyRWlLcGNiOGQ4d2lGSnBsZEdVbk9N?=
 =?utf-8?B?MzBETmh6UVIrZ05HMjdoaVBGTmlld29vUTcrTElTcE5DZUdMTThIKzB2Zm90?=
 =?utf-8?B?ZW5wL05oTGR0L2dQSzdIa3VIMEplUHZuQVNyNUlVTlVlZFY0VTdiOTk0VkE3?=
 =?utf-8?B?ZGVDUUhqU00xcEQyKytSaldMZENWNmQwSE0yMWV0SjFlQlFoYUhmSUVhZWRt?=
 =?utf-8?B?Qmo3Ni9CNmRwZGxQN1VTMXVDb3o2aWo4L1h4K1d5SzU2bHFUNTUxMXdtN0g5?=
 =?utf-8?B?V1JqM2VIazJQQStGVjlMa3BlNjNQWFZ1K3hUTlZNOWlpN2p0ZDZzbU5kQ1lL?=
 =?utf-8?B?RkxISmFlWlRQK3NJeERkQVVYYysvaU9HeDQxWmd4UXg5cklIcVdnaS9LR3pO?=
 =?utf-8?B?WklkaUYzbkVOTElEYXRvVjllZGwrRFJyQnNJV0dxZ1RJdHU4MXJwZlprajFZ?=
 =?utf-8?B?MU15Y2xjMGRWYWJYZUZKbCszWEd2T2pEczFTdkZlaHpHczJzem1Ta1hETXZM?=
 =?utf-8?B?WFd6c3VZMmF5T3ppTGV2eVZLbDdGRHNzVGlwMnNpdnVSSkNVZER3SjJmdExl?=
 =?utf-8?B?UmRCTlFObE54VUhvR0N6ZzhVQ243eXNGNWc2SzZYWFE5RnNUL0NKRmhGK3dB?=
 =?utf-8?B?S29RbVByaTdaMGJGSnErVVdYeE1hL2RxNDRrUVBKL3Z2dnFTR2pleDVtVXNr?=
 =?utf-8?B?VGViRE1uY3R5TUdwTGJsdFdNWm1FOXU4YVM3b3BJTUlQbkZOWW9XVFBuYnU1?=
 =?utf-8?B?ZUdSRmRKeDM0MHB1RGRWSktCZmxlR24rOFhwc25Kb2RHdUpZWnlGM1ltK3F4?=
 =?utf-8?B?TEcxc1lXeit5UHBkcHZnTzgyQWxqWkd1UW04YzhwWGg5d2d1M0JkM3c1OWZa?=
 =?utf-8?B?NEY1RlNNNTVzTlorWkhKaEExVVBDZytFMml3R2VET1F6cGgyaUVLeGRWSHBK?=
 =?utf-8?B?SmRGZmhNdlJJdCsvdG1KbVNkdU4vczY0eVJNa1dWb1hSS2ZNWXI4WmpOS0pQ?=
 =?utf-8?B?amc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c911fd5-d558-4b9d-7768-08dbf0e0dc92
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 13:41:16.9221
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: npAg3UsFp+/HO0KZDWdFRGCnLsesEcKimXsqYKjtjm0daH5yhrJz4h6U03199zZKoekJyAoRgN4hmGTezNjNmqdtPoFed3UHHvFB5MUh5ik=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7676
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 29 Nov 2023 05:59:15 -0800 (PST)

From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: Fri, 24 Nov 2023 16:47:31 +0100

> Expand the libie generic per-queue stats with the generic Page Pool
> stats provided by the API itself, when CONFIG_PAGE_POOL_STATS is
> enabled. When it's not, there'll be no such fields in the stats
> structure, so no space wasted.

Jakub,

Do I get it correctly that after Page Pool Netlink introspection was
merged, this commit makes no sense and we shouln't add PP stats to the
drivers private ones?

> They are also a bit special in terms of how they are obtained. One
> &page_pool accumulates statistics until it's destroyed obviously, which
> happens on ifdown. So, in order to not lose any statistics, get the
> stats and store them in the queue container before destroying the pool.
> This container survives ifups/downs, so it basically stores the
> statistics accumulated since the very first pool was allocated on this
> queue. When it's needed to export the stats, first get the numbers from
> this container and then add the "live" numbers -- the ones that the
> current active pool returns. The result values will always represent
> the actual device-lifetime stats.
> There's a cast from &page_pool_stats to `u64 *` in a couple functions,
> but they are guarded with stats asserts to make sure it's safe to do.
> FWIW it saves a lot of object code.

Thanks,
Olek