Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <e8b77875-d7a2-4898-94d2-248e32b6ebf4@intel.com>
Date:   Wed, 29 Nov 2023 22:12:59 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 05/26] x86/fpu/xstate: Introduce fpu_guest_cfg for
 guest FPU configuration
To:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
CC:     "Hansen, Dave" <dave.hansen@intel.com>,
        "seanjc@google.com" <seanjc@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "john.allen@amd.com" <john.allen@amd.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "Gao, Chao" <chao.gao@intel.com>,
        "mlevitsk@redhat.com" <mlevitsk@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20231124055330.138870-1-weijiang.yang@intel.com>
 <20231124055330.138870-6-weijiang.yang@intel.com>
 <742a95cece1998673aa360be10036c82c0c535ec.camel@intel.com>
Content-Language: en-US
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <742a95cece1998673aa360be10036c82c0c535ec.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0Vkbm1wTUV3M0IyakhzQnJNUmRVYlkzRm5QczdReDV1c0ZOWm1tMjFkYU1x?=
 =?utf-8?B?VTZxMm5aQmZVelBBYldPYUxGeE5URkg1cmNTWVhSNC9KMjFuaVdXZ09kUFBV?=
 =?utf-8?B?OXc1ZGxlSWJNTmZyQjlaRTJsVjlwdFFTb3JqTzdmZUNCQURYMDR0dmlwU3lp?=
 =?utf-8?B?UzV3dURwTndTbElwQXVsS2J6RFNaYVFTSndmYUtqdjJQajluU0EweWYyQjVC?=
 =?utf-8?B?S1NaTFk1ZEdtMFJTajVTRyt6WFFhRSs2ZkFsQzJQZG9JZ3RzVmRSNTB5dVoy?=
 =?utf-8?B?V2I2LzE5cnJ1Qmd2eWtRZjNNOTEyTk4zaEF6V214eWtZdGZqMC9BbkdQRkg3?=
 =?utf-8?B?aVg1VGRicU9vUU9xZUVGSDZmRTNPUEQ0OXZQTk9MNWc4Y3AvTE5lYUY1Nmhs?=
 =?utf-8?B?NmtETUVmSVViYXk5ZXlZNkhuMkdJZTUvTDRDblJoUVlIVzlBa00zV0Jld1JU?=
 =?utf-8?B?UE0zcFZxbGZzUk51b3o1c2tHSnhvQjZJSSs2WWpHK0E0S0RmQUVlRjhDMHhl?=
 =?utf-8?B?ZmxiZEtUamdsd0h0dTRnVmdDN1JaS0Y3a1N2QlkyU1htKzYrRW5UcWhVeXoy?=
 =?utf-8?B?UXhKNXZSbENZM2JFN0wyczdHQnE4OXo1UUlsZjJ5SDl6SW1icGh4TUxtcmxB?=
 =?utf-8?B?MXg0YmdSbnYrbTN2aFdpTGpHVVM2RG9kNzZpblBoTTVSV0tCZU9LMHlURXgv?=
 =?utf-8?B?WVFXZHhtbUdjYldqUUF3TVh0T1ovWkVtQmFvcTVWdGVYb21LWHFyNmF0UDNJ?=
 =?utf-8?B?SUtVVndqaGJiZVpwU3o5cWgyMnFzZEc2NHhvaU1tSGxWdHYxVnZzUGFTbWhR?=
 =?utf-8?B?bFBORjlYc0VKaUY5T3Z5bEdCQ1VkanNwUHZySFZkUExTQ2tQK3NqUGVLa2lz?=
 =?utf-8?B?V0piMFFHRDRWTTFXYm14elhyeDBsMUI5c3c2bHNUQmxlSm5CT3JaNEVFM0hT?=
 =?utf-8?B?d3FuRVY5L2c0NCs2dzRvQ1k2M1JCcUQrbzc1YnQxSUg4WTByVG1yYUNRa0g0?=
 =?utf-8?B?Skp5SCtMK1llaU94QUJrcWFDY1VZMFZWckIrbjdhWUVHUHhqNEpIZ00zYThQ?=
 =?utf-8?B?QW9DQnl6NlpwcnkzdVRYT2RQZ2Q0cVpMRG5FVnZLRkJSckdSL2QrazNocThC?=
 =?utf-8?B?QVpPYnF5OUJ5SlRWWG1NeDBVWEtoSm9vNjE4SVlZcUZoZW1wM090U3lrTHFQ?=
 =?utf-8?B?OHB3RWxKTGpadElnTUk3Q05QRGI3U2xBZnYxb1BDd3o2NGNxSjZabmVtdXIx?=
 =?utf-8?B?blNkWFFYdjViUzFUamlTeTYyekxLNGRhLzZ1bzNYb3NiOXRRSU9kNUcvVmJ3?=
 =?utf-8?B?MVdMbERRVlFvbVA3am9zcjU0VndkOWU3ZlJsbE9xYjNoYjlTNHdRVnp2TUQ1?=
 =?utf-8?B?eUdhaVZsbnYvcjc1Z2J5ZG16ZmpLamhLWjRvUG5pZTdvWVBJcHRvT2hxRHc0?=
 =?utf-8?B?cWFjNnozb0p6clN5alRvUDM1a0I0QmNYSXk5UGNJZXpiN1RqMlNqRC91WVZQ?=
 =?utf-8?B?ajNCOFZEbWszdzVBN1I3ZXlXZ2FKeDhXRUd2V1hLdXFNZzlCRmhtU25aQTkv?=
 =?utf-8?B?TTVQT0lVK2FnUER3bWlnbk5FRll2Z2lLN2hUTk0xWXVUQ25lbDRjYm9HdThS?=
 =?utf-8?B?VzN6ci84MHVycWt6SHRFRStrU3NUTTFsa1JwWkcyODZxZGt4ek94ODZBbXhF?=
 =?utf-8?B?dk5vOU5SY0h4bEplMTErdXY3L1dDYllUMmFMTkd6eEt2REhRZXIxWGJxVFF2?=
 =?utf-8?B?UFpobWlmMTVlR25qVG5pSjVYc2p3Zm5HbWJXK1B6dHFwK1B5T3I0R0U5VEJL?=
 =?utf-8?B?NU5HUnpKbUJHZk96OG0xOWNpR1dNUmRCQWp4RXVGSWRYY1NBNkFWUUhyYUxH?=
 =?utf-8?B?MFN5OFlnY3VxUkFzTnJtZ0RVZlk4VGtZNE5ybVRjSEFBczJtc0VLcGN2MVNs?=
 =?utf-8?B?VUZZOFU1MFcwUG1nc2Zxbk1DT2dKY1AxYTdLMkluODJIOFAvOCsvVUFxTkE5?=
 =?utf-8?B?TlVIditlbW5FTW9KTXhadFJSS05JaVZxcERWazdqMGpQa0szcWlid3FMK2tp?=
 =?utf-8?B?QjFFMTRsTDNYQnB1UFpOLzVzM1J4ZDVQZ3l6Tk5mOGU3ak1ZMW5ab1pXR3VY?=
 =?utf-8?B?bG5YR2FzYU1XTUpCR0QralBrZk9oTTlwYnpwWFdqZDVQaXkyaFM0Smg3cXZ0?=
 =?utf-8?B?UUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c7d5ea84-5936-4e84-00b3-08dbf0e5503f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 14:13:09.2358
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wp5HgZp4bV4bo4lav2+d0P6LSEyIqjWnDjuZBZPxxVEx3e4DpAMuQ/O2KrpEd2G3NrcQBN89rMJ7GVovIWUEmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8167
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 29 Nov 2023 06:13:30 -0800 (PST)

On 11/28/2023 10:58 PM, Edgecombe, Rick P wrote:
> On Fri, 2023-11-24 at 00:53 -0500, Yang Weijiang wrote:
>> +       /*
>> +        * Set guest's __user_state_size to fpu_user_cfg.default_size
>> so that
>> +        * existing uAPIs can still work.
>> +        */
>> +       fpu->guest_perm.__user_state_size =
>> fpu_user_cfg.default_size;
> It seems like an appropriate value, but where does this come into play
> exactly for guest FPUs?

I don't see there's special usage of this field for vCPU in VMM userspace(QEMU).
Maybe it's mainly for AMX resulted usespace fault handling? For vCPU thread,
it's only  referenced when AMX is enabled via __xfd_enable_feature() .