Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Wed, 29 Nov 2023 16:16:58 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Petre Rodan <petre.rodan@subdimension.ro>
Cc:     linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Angel Iglesias <ang.iglesiasg@gmail.com>,
        Matti Vaittinen <mazziesaccount@gmail.com>,
        Andreas Klinger <ak@it-klinger.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v5 2/2] iio: pressure: driver for Honeywell HSC/SSC
 series pressure sensors
Message-ID: <ZWdH2rNSmj_jisuv@smile.fi.intel.com>
References: <20231129070452.1521-1-petre.rodan@subdimension.ro>
 <ZWcUPkzfGqxYsysp@smile.fi.intel.com>
 <ZWdB-vU2MAptRk8d@sunspire>
 <ZWdHYsWN-RWr75T6@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZWdHYsWN-RWr75T6@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Nov 29, 2023 at 04:14:59PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 29, 2023 at 03:51:54PM +0200, Petre Rodan wrote:
> > On Wed, Nov 29, 2023 at 12:36:46PM +0200, Andy Shevchenko wrote:
> > > On Wed, Nov 29, 2023 at 09:04:49AM +0200, Petre Rodan wrote:

...

> > just to have the privilege of using match_string() on hsc_triplet_variants.
> > now, which is worse for maintenance? a handful of lines of code that do a
> > loop of strncmp or the clutter depicted above?
> > 
> > I can go either way, but I want to make sure you see where this leads.
> 
> That's the suggestion, yes.

Btw, if you have any idea how to make a generic API that suits your and
similar cases, I'm all ears!

-- 
With Best Regards,
Andy Shevchenko