Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <68664795-87bf-4934-bbcd-f6d8701d051a@intel.com>
Date:   Wed, 29 Nov 2023 22:16:32 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 06/26] x86/fpu/xstate: Create guest fpstate with guest
 specific config
Content-Language: en-US
To:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
CC:     "Hansen, Dave" <dave.hansen@intel.com>,
        "seanjc@google.com" <seanjc@google.com>,
        "john.allen@amd.com" <john.allen@amd.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "Gao, Chao" <chao.gao@intel.com>,
        "mlevitsk@redhat.com" <mlevitsk@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20231124055330.138870-1-weijiang.yang@intel.com>
 <20231124055330.138870-7-weijiang.yang@intel.com>
 <cf078e1600a1ead27ee382ae184aa9ac168205ad.camel@intel.com>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <cf078e1600a1ead27ee382ae184aa9ac168205ad.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVhuL2NNU0xZcEJSUVAzbGl6Z2lvNHhaOUlmbzRqa2pEc2EvNm8zeXJ2VGlC?=
 =?utf-8?B?R2NhV1ZMNlppVFlvenFQR2ZFZVVKMXIyMzRoeVpxeTdrZ0IybTUvN0IveExL?=
 =?utf-8?B?LzQ3enZpeExVVlJxY0ZwZ2NTT1FOUHZ0dGpYZWI5ZkZTS2VsZSs5ajZ6ZnEw?=
 =?utf-8?B?VktXQ3FZbEZOOHNqWUFPY0ZhSnNyUmZzVXludTlQdW93OW5ua1R6cTFmbnpG?=
 =?utf-8?B?dU8zOWVzcHcwNDl5b09rdUZsN2oxWnZYR081d3pOTGx6a0lMajhobTR1c09u?=
 =?utf-8?B?RmNoNXhOQjIrVWpjeFhQUDJybGhiVGN2T05XOE5BN1FKcGFyUVg3ZmljQ01Z?=
 =?utf-8?B?NFRiRlEwK3lBcjNwTDRpNEZIL1RHdEpIN3d5bzQ5bkNFRUhHTW1nTUU5OFNZ?=
 =?utf-8?B?T2F3SHRXaDNmV1l6Z0lGSnpSM0dDNzhGa3dtMkdTS1Y3V3REZ0RUT2tGWHJS?=
 =?utf-8?B?VWY2aDZTczVnT2xhNU1RV0NqUGpiQ1NEU1hsWFdtSkxwdDlyMjJRZm82WEg3?=
 =?utf-8?B?Z2ovcDdvaGVZOW9BUWNMU0wzcFBQbEJrbExDM2t0bitRU2dhT3NvT2pTaUJk?=
 =?utf-8?B?WnBRdGdCUzR5amNhTkZMTS80eWtFZU0vMmNHaVVQWkhPd09PZnJRSzVtMEFY?=
 =?utf-8?B?dVA3QnAybTF6YjlhT0FVY2ZEWGdpdklISlh2Y2ZRemZUbk9tRzZpcUdxZGVT?=
 =?utf-8?B?OXNyTUJOS3FJMEdSUEFrOVRzK2xnQkNWVkI4bDhvWjNTcnNTdERreSsveEU4?=
 =?utf-8?B?VmRMU3U4V1NMUTRHTW92WFRCcENocVI5R2V0dTg0dGMxeGU1RTZXdXZjd05M?=
 =?utf-8?B?RzMyaU94WDBsSDV6UmRkbklHbzg3OGt5RkZOMUQrL0g1WTB1ejBrdGorOTQ5?=
 =?utf-8?B?UlJCRkxCM1FBcFBYNjZ2Z25aYm5ZVVdpdGNmTG1EMFV1ZDlyYzloZ25sZTJM?=
 =?utf-8?B?TE1zV2h3d3A0eVUxOW4vSWltMGJzSU1LcFNLMkRpSTlOS2l0YnRNRkY1UmFI?=
 =?utf-8?B?NzN2L0dhM2gyZm8xOEhrY0Q0S2JBTU9UUEY5TXoxOE50RDRwc3ZDVGJkT21S?=
 =?utf-8?B?RSsvZVpBaEU3cnJmUVZiSTh3bG5yaFNIWEV2bDRUQmY4cTB2ZlV6dE5SQ0Ry?=
 =?utf-8?B?VlRZb3lOcUNvTE5lTHBUbWYvWEV5WkZuTlUrZUFzNUtyTnNKbHNISkM2T0ty?=
 =?utf-8?B?S0RMcWY0aEdCMFkzZm1DcjFHRHNLTE4wakxMQjV0UzJ4L1dUVEdnWnQzdnhI?=
 =?utf-8?B?eExuTHdiS3R3K1FITkhmYko1ZEVnZ01NdE12ZEVwZ3Y1OExJNmFYVnhLdzVD?=
 =?utf-8?B?WndweHFmbUdwS285NE5uK044SWkvR0VPV1RHMExEOXhPOTA5bnJxUlFxWXlT?=
 =?utf-8?B?Slk1NDU5SjlLSStPRWxhZHk0WW1Tb0h1UGJNM1BFMXhZai9KSnZldlpLR2tn?=
 =?utf-8?B?bmt3Y21KV0xxR1NsMXN5VWcwakszQURzcEFpM0VZV1ZheUVuZTNqWWtjY1lk?=
 =?utf-8?B?WXlyMlhGTkFzenhkeTVMZUlFdW1MT3AxWEtvcklzMXY3aG5GR3lMYjJOczNs?=
 =?utf-8?B?OCtiK0E2K2Nsd2NOcFhEc2hZeWUwRkVXNWc5RVNkVXMzdzFQaTJjZlE3aHQr?=
 =?utf-8?B?UjRqK090UlR2QjJWd0xpQzcveDltYnhUNWFSS1FHeUJCWHhmVEljWUovN2lx?=
 =?utf-8?B?YzRaM2NCb3BzZTdkVmlKa0RqdjRmOTZIbXE0Nld4TjJmWm15TVFaenNUeEhy?=
 =?utf-8?B?T0ZIWjhvSjQxWTRNb3Arb2xOdWo2cUNyYk9ORlcxUlZTQ0tHRUZoYzliaVAz?=
 =?utf-8?B?ZUtZaDI1bEVUcDFwSmxnVUtjdUlZYmtYYXVxY0JnaGgrbkFBUkx5cGNqbUhE?=
 =?utf-8?B?VFBjYk9xSW5aellvUC9XcmFsZWtXamVVL251UExQS2JqV3NNTjlXa1JHSHpa?=
 =?utf-8?B?empIcFVYUjN0ZUJYcm93RlhpMDNSbjlZYzFGYldHWVdrQjhHY1pISFZSSWpX?=
 =?utf-8?B?MlJ4bHNnZzdUeENlcEU5RVc5YTY0a3lCbDRNUWtpa1RnenM1cmJhSkJCZjA3?=
 =?utf-8?B?THMwOHF2dTlySkhydUNmeFdYZklCTXhyNnNUSlJlWWh4cUVVaGIxQWU1MDV1?=
 =?utf-8?B?UEo0YUZiOE52c0RhWE5udkNUYTJkb1dtK3ZvdzExMjNNNGNPS0taODFBdjNx?=
 =?utf-8?B?TVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c9bdc02-a3a1-4962-883f-08dbf0e5cf1b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 14:16:42.2213
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bVJoCddPMkcmtdCQRxj21YudBO+15a2sk4WRJUMKLqK+4S4QSpUO7EMz9IrlX8t+KPS5mFOsxjXf8DB1Vin3bQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8167
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 29 Nov 2023 06:18:10 -0800 (PST)

On 11/28/2023 11:19 PM, Edgecombe, Rick P wrote:
> On Fri, 2023-11-24 at 00:53 -0500, Yang Weijiang wrote:
>> +static struct fpstate *__fpu_alloc_init_guest_fpstate(struct
>> fpu_guest *gfpu)
>>   {
>> +       bool compacted = cpu_feature_enabled(X86_FEATURE_XCOMPACTED);
>> +       unsigned int gfpstate_size, size;
>>          struct fpstate *fpstate;
>> -       unsigned int size;
>>   
>> -       size = fpu_user_cfg.default_size + ALIGN(offsetof(struct
>> fpstate, regs), 64);
>> +       /*
>> +        * fpu_guest_cfg.default_features includes all enabled
>> xfeatures
>> +        * except the user dynamic xfeatures. If the user dynamic
>> xfeatures
>> +        * are enabled, the guest fpstate will be re-allocated to
>> hold all
>> +        * guest enabled xfeatures, so omit user dynamic xfeatures
>> here.
>> +        */
>> +       gfpstate_size =
>> xstate_calculate_size(fpu_guest_cfg.default_features,
>> +                                             compacted);
> Why not fpu_guest_cfg.default_size here?

Nice catch!
I should use fpu_guest_cfg.default_size directly instead of re-calculating it with the same manner. Thanks!
>
>> +
>> +       size = gfpstate_size + ALIGN(offsetof(struct fpstate, regs),
>> 64);