Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Wed, 29 Nov 2023 06:28:01 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        "Jonathan Cameron" <jonathan.cameron@huawei.com>,
        Shiju Jose <shiju.jose@huawei.com>
CC:     Yazen Ghannam <yazen.ghannam@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ard Biesheuvel" <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH RFC v4 5/6] firmware/efi: Process CXL Component Events
Message-ID: <65674a71ef4d0_a1b25294e4@iweiny-mobl.notmuch>
References: <20230601-cxl-cper-v4-0-47bb901f135e@intel.com>
 <20230601-cxl-cper-v4-5-47bb901f135e@intel.com>
 <7ec6d2af-c860-9b05-7eaf-c82f50f8e66e@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <7ec6d2af-c860-9b05-7eaf-c82f50f8e66e@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZMcwOpFdY5cy/utLHmBQwpB5cWE2Hu/F4b8Nb7+a+HNUJnmB/edha9Cr2Hq+?=
 =?us-ascii?Q?ocgdiofV1F9LhUPDHsjPeBZvhUaaCEIdhBGvMGMBHrqS8MQkL1tn6MfotCtD?=
 =?us-ascii?Q?Hwtq+7FwJPoYc8uebWdqsKODPMGIFWPxWo+7CY/BAh4si4FNbRByahNW9sb5?=
 =?us-ascii?Q?IhJbbJ2rRoSYQSF7EXJxtOj5NBrUi3OolDFTrGg7Cb8u4/oW8HTxnubY1giE?=
 =?us-ascii?Q?wYqHmGJsfJGPlreqgX4hddGSI7Io8ZP4KKb/K6/q9ja/0r8Ctjmg3bPR7guM?=
 =?us-ascii?Q?zw7GgnXpT2kFTwBVdLxeCzQZZ+5srJAKffEV6XaMofdNWINEO5BAWaTasuYJ?=
 =?us-ascii?Q?HcSdVzMHYPSHh29bEjFj3sjy02sqwRh45qPXgj+OfRUunwASDrHDWVApgYBI?=
 =?us-ascii?Q?yyIGbTdiGEcRIETPFpovsamjUbYi/esFP1Tww+NkKGjdY5PKxc+HMISWJ4Wg?=
 =?us-ascii?Q?2pClg1xHD7WeJ5yg1GnmW4bPlS22Q86dt6LFjZ7UJwrdSgwpsMXEvww9jBy2?=
 =?us-ascii?Q?z2Vy+UuWcHrzuxiEHD7kOrduw7EUHO4lld9Fj2k1HZFnkkFUqt2FjRnPK6PW?=
 =?us-ascii?Q?gsScN6stxKq7AHo3SwuGM052iITf3UIBfyPt0nLp8C/Ip7M4NGCDwy5nPo/t?=
 =?us-ascii?Q?PjMNPmC9TAzfywchfPYNB0GTvnPhd9UFXTUYLfBJTdpoFYonslpU/VcloI2c?=
 =?us-ascii?Q?H5nf4hPP4Tp+T2gJogts3/L49YqjfdlgO28nGUIFsNohisTiCtXHO8Ne32SO?=
 =?us-ascii?Q?jWFwEmT2aZYKtpL1SfTvbSyp30RTQbDZFoSQFSbf/wOHNNNhjmxUVQsRTeK7?=
 =?us-ascii?Q?EVb8w/7TUYuAGq5H5IlVMSy3NvljcWXs8+aXmqsYgd5UJYz9Fx/BoaQ8XhC9?=
 =?us-ascii?Q?PV3m2uwDOAX4TlIBxnnDojJVsbPIlPoBb3lpvtOiC/hM0azsNWVi5RRAry1Z?=
 =?us-ascii?Q?hrBVMrM2ePDWHPrNQz6wWLdsT9DBiMyUnPViTHEhYFhiZJbKvARE9UHg5RL9?=
 =?us-ascii?Q?KyHVGwlmJwrSGUOimBLxNW/WBuWpMj3i2+RI3EkqB+4aQBpdPIm7xcTNry/5?=
 =?us-ascii?Q?diuspguCwdSjTSPv8bsAthCi2A8E6QIolasLg/zaGlc/PrW5qJO/cPKNoRiu?=
 =?us-ascii?Q?szVXUzbeGm1Vl5cgrb7aGSvZ30F9xHaakePPjUXVorPi44vz9K2YZFEq03KY?=
 =?us-ascii?Q?x+01ipsW65lANy0meNIBl9CL0Dy7j7uNFRITDIh06jk9VbN+ddkKWhsGYVWW?=
 =?us-ascii?Q?3D33zX2gMhZSw78l3nCd8frE8R5JOsSYv3e2uVgitpdIjhUx4cK2jYOyqT7Y?=
 =?us-ascii?Q?CQ0/AnKFdpUZlzsalke6nz6Ts6V4IC9h2DLveFwf9VSE2jkrLgWlMgOtb0Dn?=
 =?us-ascii?Q?bzJfde6838+c73U0sk3BMtSrHcbA3oDzI0TZSQ8hbaX1Obtxm21erchikE1O?=
 =?us-ascii?Q?t184uAi4Xq28h/ZbbLl2vF+A62g3fSSG/7Yjk/oxiQnGshclhbu1Q1Oej21v?=
 =?us-ascii?Q?iPoOrd4cgzl3JLE8tsnjnwDK8v8tFpi1pjsxehGPVVXx3pV7T0K1RSj+GUDM?=
 =?us-ascii?Q?Q65GoVhPZ0VGkBNOnVKwEsao+i6IheojtLrMKwT6?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c4eb5e3-fa4f-41e5-0e7f-08dbf0e7667f
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 14:28:05.3119
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ODX4bF8EbzIsuY9InePWPJ3n3GtVpSMe+E5yVV3a1vMnTztuqMYQcKEPspyqJx9wLvA2/Hbrj12mIS9Wr9ojZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8282
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 29 Nov 2023 06:29:26 -0800 (PST)

Smita Koralahalli wrote:
> Hi Ira,
> 
> I tested this out. Just one correction below to make it work.
> 

[snip]

> > +
> > +#define CPER_CXL_DEVICE_ID_VALID		BIT(0)
> > +#define CPER_CXL_DEVICE_SN_VALID		BIT(1)
> > +#define CPER_CXL_COMP_EVENT_LOG_VALID		BIT(2)
> > +struct cper_cxl_event_rec {
> > +	struct {
> > +		u32 length;
> > +		u64 validation_bits;
> > +		struct cper_cxl_event_devid {
> > +			u16 vendor_id;
> > +			u16 device_id;
> > +			u8 func_num;
> > +			u8 device_num;
> > +			u8 bus_num;
> > +			u16 segment_num;
> > +			u16 slot_num; /* bits 2:0 reserved */
> > +			u8 reserved;
> > +		} device_id;
> > +		struct cper_cxl_event_sn {
> > +			u32 lower_dw;
> > +			u32 upper_dw;
> > +		} dev_serial_num;
> > +	} hdr;
> > +
> > +	union cxl_event event;
> > +} __packed;
> 
> __packed attribute just for cper_cxl_event_rec still fails to properly 
> align structure elements. Looks like, __packed attribute is needed for 
> all structs (cper_cxl_event_devid and cper_cxl_event_sn) inside 
> cper_cxl_event_rec.
> 
> Seems easier to use global pragma instead.. I could test and obtain the 
> output as expected using pragma..

I did not know that was acceptable in the kernel but I see you used it in
cper_cxl.h before...

Ok I'll do that and spin again.

Thanks so much for testing this!  I was out last week and still don't have
a test environment.

Ira