Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4618672rdh; Wed, 29 Nov 2023 06:29:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHyrgX2wBQE3B2nGBN8H3xvxmAxTiuITz5IFb1x4UzRk6C2OBBOhFxuEjZAYcQFNspiEArf X-Received: by 2002:a17:903:2303:b0:1d0:1e4:cd5a with SMTP id d3-20020a170903230300b001d001e4cd5amr7524869plh.3.1701268188861; Wed, 29 Nov 2023 06:29:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701268188; cv=none; d=google.com; s=arc-20160816; b=TjD2CjQy74YOPHdXOvdGP4VZtIXq8LdiSsCIfuaG+t09AIaCmPmeP061aDMO1ERFVW aqvXMu3mofeiXH4zzcG7ln2WBmsRdu5jqGG9EBgDSv9Y65cYsLQzEkR+wEYd+8lthWNC fzgihX0jzYCWFmK7vix7yWF/xn1c+QaXyhChjzpBWGmOtjrVKrFXNJwD6sIDtdI3gNdc 101Df47kTbSLpm6WDNMOlbYPBeQQ0xCKY2A4xc5xW99XJYkLXG95ytXOgMTt6hL3ePxd JGFV77J/ECIF3fZAwwyk3V2ExlD5dEh86QI0JUGGKVfzgLel3fmMSkcZ8VqGsk08NYSx ryog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=7OXsoP9CHA9ZezVYSl8hYnUI9hcWQw4jMvzOXG7rAOE=; fh=oZLMSOHRQ2zSitqdPyplCkgCmKQjKn/gJ/DymR+mK+4=; b=yUCZla2oXIfSbCi0eMbP4Xep1CdK86Eh3550pJoiT7/czbNL4eodvsPjI6sc0U0N+L Q+8w0YrC0XO2luVn+rHbERAl5Ooxh45c73jtdBlCjizM15swKF2OrBHwl0xNx8LavFRA ihX2i154RZf8JcLX75wbwKKq5f3vKkih76lbh/V/qqH/7SsWHnUvc5Su0CEwU8WDKXyo iD4yfbG9fm6VkjHLnms1PMejcKf9fCeHKWA2+sSe1ptwXlA+hp7ozy9hx9G2Q7pwujLD uT40AVPp9h3g3vwR2czBMnEOBA2ZylkHk5AdQQ7rozNi8/BSNKNqUM47MA1fwidweS8i QhAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i3O7voHE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id u10-20020a17090282ca00b001cfa70f3a47si11417494plz.158.2023.11.29.06.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 06:29:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i3O7voHE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 6971580403AB; Wed, 29 Nov 2023 06:29:46 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234391AbjK2O3S (ORCPT + 99 others); Wed, 29 Nov 2023 09:29:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234343AbjK2O3L (ORCPT ); Wed, 29 Nov 2023 09:29:11 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30004D50 for ; Wed, 29 Nov 2023 06:29:17 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 382C7C433C9; Wed, 29 Nov 2023 14:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701268155; bh=TeXzHb7rxKXQGXucrw/Ty/eqYEy5dqm0uu/JKO7RDCs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i3O7voHEX9nwvQnJXx+x/l0uWqkVQvdAG5q4p3bznL6GqphqcrWs3xFHrQ8QI/oPi lNmWjgwa9JSdXyIuoBuXqerZJuECGpkCKl+ZH+M4+4WdrDS6HtsTg176EV4ShNUCW5 74vO/32ri773Hg8T1+F7X62xkD1hHHTvOHaVEMEz+B5Pu2Lc94AamDXFejMn5DgGVK 74kTTH2DyszHJFugM9TQ9/a5NIFzY+8wnrbrtwAXkgCspTtViqeF+Mf1HxL2Bs4rzi K1XKEAxa6HRKtIqP31DRapZ0z0qUqTCdIRHAVe/eJoY6N8ZxHzb/zX810zld/zkWC3 feN0/SCLMbyRw== Date: Wed, 29 Nov 2023 06:29:14 -0800 From: Jakub Kicinski To: Alexander Lobakin Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Maciej Fijalkowski , Michal Kubiak , Larysa Zaremba , Alexander Duyck , Yunsheng Lin , "David Christensen" , Jesper Dangaard Brouer , Ilias Apalodimas , "Paul Menzel" , , , Subject: Re: [PATCH net-next v5 13/14] libie: add per-queue Page Pool stats Message-ID: <20231129062914.0f895d1c@kernel.org> In-Reply-To: References: <20231124154732.1623518-1-aleksander.lobakin@intel.com> <20231124154732.1623518-14-aleksander.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 29 Nov 2023 06:29:46 -0800 (PST) On Wed, 29 Nov 2023 14:40:33 +0100 Alexander Lobakin wrote: > > Expand the libie generic per-queue stats with the generic Page Pool > > stats provided by the API itself, when CONFIG_PAGE_POOL_STATS is > > enabled. When it's not, there'll be no such fields in the stats > > structure, so no space wasted. > > Do I get it correctly that after Page Pool Netlink introspection was > merged, this commit makes no sense and we shouln't add PP stats to the > drivers private ones? Yes, 100%. FWIW I am aware that better tooling would be good so non-developers could access to the PP Netlink :( I'm thinking we should clean up YNL lib packaging a little and try to convince iproute2 maintainers to accept simple CLI built on top of it.