Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4623430rdh; Wed, 29 Nov 2023 06:35:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IFLETtg8EhZeXfZjm6jtepH57+deGBjNJE6DDMccUyfvxtr8PXivv01RBZP7+dFT++G3h8L X-Received: by 2002:a17:90b:38ca:b0:285:bacb:775d with SMTP id nn10-20020a17090b38ca00b00285bacb775dmr10359069pjb.48.1701268530584; Wed, 29 Nov 2023 06:35:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701268530; cv=none; d=google.com; s=arc-20160816; b=AgebAXT4gSmoM3WNz/bJnr019ocOAC5yVJxyBEL5NpfSWZ/xmDIs76sgam79kg6nkL KEBDkoKvFbbNMgugkUbm3Ktb3EqEu/5dWog5p9KSgkXHRx3SLt+UATdU13ErsugwtldH M8Q7GljEjktVmzTUunQuNFZ+xN9Xq6Em25mBhKcvQB052tsSFe5elBwuYreKlzAwLCwl 3jq6EofVG4XES4eI5Bc7LAHzUKWbQlv8m+ZjpCji7fkuvYu7ljJVpgKaTgMkkWiZc2zh ULUwtUOFIY2y7o97CC3oyIKBn1ssYYWW+RnLiQ0jdqkKJITs0Wo4qtfbaCH/6u7kKpkq tbxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=xNVxZr2PGXk5Amnu5ijH+LBpR+6BGyEPiBFMmHwdOq4=; fh=HJCxKJrADEEWLw8a8FFNCrPY3LoVAy30QIjXpzIzSNs=; b=m5rN0Lo5E3iXhWkGMvVDvYIuB/S88IbU3fQEQI74TdftqPx5mB2KWxMoeQ8/iOPb3J Y5Gb239FsAPKchWSI0n2FZL+ZFBoTz5zJxnYh5hKQShcjxQZrUr2Qgus1H+V6l9mTXOu dMF2xMS7ZdLkGiN/Q0ElHBsHCJxGoRvCitDC2gnBB/WxGsiQDxSlo6tB0SBlirFVcs5D 7HILVhVf7R+T0FLsjJg33vgYlnLX6ISgoGlJ0s89ccGSuDN/+JlvpC7jUJWIUUrwGWJE oFx8Y4dWYzB8CzKiYA8/Ok3KhGi8+nVVwAlNeLG2UHZ/ddOSjddSyeGiAQZtaype/Ocf Syjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FW8ygdnd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id i5-20020a17090a974500b002860ab2ad3dsi1387452pjw.57.2023.11.29.06.35.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 06:35:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FW8ygdnd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 1490D80C8D72; Wed, 29 Nov 2023 06:35:28 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233859AbjK2OfQ (ORCPT + 99 others); Wed, 29 Nov 2023 09:35:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231737AbjK2OfO (ORCPT ); Wed, 29 Nov 2023 09:35:14 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 355ADD54 for ; Wed, 29 Nov 2023 06:35:20 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-50bc8e37b5fso393789e87.0 for ; Wed, 29 Nov 2023 06:35:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701268518; x=1701873318; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xNVxZr2PGXk5Amnu5ijH+LBpR+6BGyEPiBFMmHwdOq4=; b=FW8ygdndbfXbds1FutGJGnMhBXS2doU3Gxcafe6mdrmEpthBni1lSgyVjSYFybytPG w4OzwYySeoXqaWXhvbWc7riXH5UCBMbBQZ+w6RL1gS/iove59B1u9rPveAwqK0743uO2 IDQgRj6he0q3yAdL3Nw6ulJYUmdiMjeOj42UQU2Q1FOH8MYKhY9FomBeQFmCWE3HYRMA TKlzIT8ZlJNJrjqZcdX7k5L+txUrSMew6Pea6t29l//UChCERWFfEqyMLCsaIvQLWIE0 EbNZzdSj7cDYa0VkE2eancyKgCtLf+9nl7q0V7QcxAJAk6qXqGSRp+xSFleGzurcYwxC Hw7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701268518; x=1701873318; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xNVxZr2PGXk5Amnu5ijH+LBpR+6BGyEPiBFMmHwdOq4=; b=GXdkhM/3y6af4N/Egk2b3AZ1puaVv5Ok/1pLtedoH756/8N69bGGBRGFy9nJI5HRgq eaE4lbHg9URmZ3JKjmuS9zjTg8wnD2lQSPp/4QDxUW2JYG3RkOxQgG5ALnkvqc6K3FXe RLEr69urdpIiI7p1XpDHjzvPs7+o5PoAbyp/BTPNQtD8xTHhqgtkHnohsxWTLk0JqR2P eh9fWgeeHzhUxcinbKpE/yfbZbfflTucz9wVH4GiRswvA5hnIz8+Qr0BLlooH/TJHXGS UOtRaQlorfUKmZyrDTHkFG6mqfzUefqvkzqNdkLPdFmEpM1nFJuKBm91iKpXOaEsnZaW +yYA== X-Gm-Message-State: AOJu0Ywxj3dfRY8ikFNnzygjaF6ZYVExe2se1ieo3FC1oqngkM5zxljc 1WcxfXRuRejK5rFPYk1zQQrC67sNAs22X+C0QaQ= X-Received: by 2002:ac2:5608:0:b0:50b:c4fe:a794 with SMTP id v8-20020ac25608000000b0050bc4fea794mr1237217lfd.24.1701268518458; Wed, 29 Nov 2023 06:35:18 -0800 (PST) Received: from [192.168.209.173] (178235187166.dynamic-4-waw-k-2-3-0.vectranet.pl. [178.235.187.166]) by smtp.gmail.com with ESMTPSA id cd19-20020a170906b35300b009ff783d892esm8084893ejb.146.2023.11.29.06.35.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Nov 2023 06:35:18 -0800 (PST) Message-ID: <3ec70fd9-11a3-4bd3-bd8c-a73c3d44dcde@linaro.org> Date: Wed, 29 Nov 2023 15:35:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8550: correct TX Soundwire clock Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Neil Armstrong References: <20231129140537.161720-1-krzysztof.kozlowski@linaro.org> <20231129140537.161720-2-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20231129140537.161720-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 29 Nov 2023 06:35:28 -0800 (PST) On 29.11.2023 15:05, Krzysztof Kozlowski wrote: > The TX Soundwire controller should take clock from TX macro codec, not > VA macro codec clock, otherwise the clock stays disabled. This looks > like a copy-paste issue, because the SC8280xp code uses here correctly > clock from TX macro. The VA macro clock is already consumed by TX macro > codec, thus it won't be disabled by this change. > > Fixes: 61b006389bb7 ("arm64: dts: qcom: sm8550: add Soundwire controllers") > Reported-by: Neil Armstrong > Signed-off-by: Krzysztof Kozlowski > --- Interestingly, downstream 8550 has qcom,use-clk-id = ; which doesn't seem to be used in techpack Konrad