Date: Fri, 30 Nov 2007 11:54:50 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Metzger, Markus T" <markus.t.metzger@intel.com>,
       linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de,
       ak@suse.de, suresh.b.siddha@intel.com,
       Michael Kerrisk <mtk-manpages@gmx.net>
Subject: Re: [patch 0/2] x86, ptrace:  support for branch trace store(BTS)
Message-ID: <20071130105450.GE9941@elte.hu>
References: <029E5BE7F699594398CA44E3DDF5544401024075@swsmsx413.ger.corp.intel.com> <20071129155940.7df70ac2.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071129155940.7df70ac2.akpm@linux-foundation.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 866
Lines: 22


* Andrew Morton <akpm@linux-foundation.org> wrote:

> The patches were horridly wordwrapped.

yep, i already tried to check how well it integrates to x86.git:

 http://lkml.org/lkml/2007/11/29/93

the code does not seem to be layered correctly: i'd suggest to read the 
discussion between Roland McGrath and Alan Stern on lkml, about kwatch 
-> hw_breakpoint, to see how a more general debugging framework 
can/should be built. These things shouldnt be limited to user-space 
alone, the kernel could probably use hardware tracing even more than 
user-space could. (because it's a much harder to debug environment)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/