Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   "Doug Smythies" <dsmythies@telus.net>
To:     "'Rafael J. Wysocki'" <rafael@kernel.org>,
        "'Jiang Yihe'" <jiangyihe042@gmail.com>
Cc:     "'Jacob Pan'" <jacob.jun.pan@linux.intel.com>,
        "'Len Brown'" <lenb@kernel.org>, <linux-pm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        "'Zhang, Rui'" <rui.zhang@intel.com>,
        "'Artem Bityutskiy'" <artem.bityutskiy@linux.intel.com>,
        "Doug Smythies" <dsmythies@telus.net>
References: <20231129143132.32155-1-jiangyihe042@gmail.com> <CAJZ5v0jfEsNVu=fg+Xa118F=hCGGB33U5SbiqWeCMaVMqNpUEA@mail.gmail.com>
In-Reply-To: <CAJZ5v0jfEsNVu=fg+Xa118F=hCGGB33U5SbiqWeCMaVMqNpUEA@mail.gmail.com>
Subject: RE: [PATCH] intel_idle: add Cometlake support
Date:   Wed, 29 Nov 2023 07:45:34 -0800
Message-ID: <001701da22db$180872c0$48195840$@telus.net>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: en-ca
Thread-Index: AQGdZaOMTCAu85nrZizeQdO70JhFLwDSqyoEsQRR5tA=
Precedence: bulk

Hi All,

This proposed patch has been submitted at least once before.
(I think more than once, but only found 1)
Reference:
https://lore.kernel.org/linux-pm/20200227013411.1.Ica3bb9fa898499d94e0b0a=
2bfa08ec46c89d84fa@changeid/

I have a Cometlake processor and am not in favor of this patch.
Reference at to why not:
https://bugzilla.kernel.org/show_bug.cgi?id=3D210741

... Doug

On 2023.11.29 07:19 Rafael wrote:
> +Rui and Artem
>On Wed, Nov 29, 2023 at 3:32=E2=80=AFPM Jiang Yihe =
<jiangyihe042@gmail.com> wrote:
>>
>> Since the Cometlake C-State is supported, support for Cometlake =
should
>> be added to intel_idle. Just use Kabylake C-State table for Cometlake
>> because they share the same table in intel_cstate.
>>
>> Signed-off-by: Jiang Yihe <jiangyihe042@gmail.com>
>> ---
>>  drivers/idle/intel_idle.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
>> index dcda0afec..f83f78037 100644
>> --- a/drivers/idle/intel_idle.c
>> +++ b/drivers/idle/intel_idle.c
>> @@ -1418,6 +1418,8 @@ static const struct x86_cpu_id intel_idle_ids[] =
__initconst =3D {
>>         X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE,             =
&idle_cpu_skl),
>>         X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE_L,          =
&idle_cpu_skl),
>>         X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE,            =
&idle_cpu_skl),
>> +       X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE_L,         =
&idle_cpu_skl),
>> +       X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE,           =
&idle_cpu_skl),
>>         X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_X,           =
&idle_cpu_skx),
>>         X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X,           =
&idle_cpu_icx),
>>         X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D,           =
&idle_cpu_icx),
>> --